{"id":24209,"url":"https://patchwork.libcamera.org/api/patches/24209/?format=json","web_url":"https://patchwork.libcamera.org/patch/24209/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-26-96f4576c814e@linaro.org>","date":"2025-08-24T00:48:38","name":"[v2,26/37] libcamera: software_isp: debayer_egl: Make DebayerEGL an environment option","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bb96e51b2b0e665a524530259915d457800d7e79","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24209/mbox/","series":[{"id":5400,"url":"https://patchwork.libcamera.org/api/series/5400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5400","date":"2025-08-24T00:48:12","name":"Add GLES 2.0 GPUISP to libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/5400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24209/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24209/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3379DBEFBE\n\tfor ;\n\tSun, 24 Aug 2025 00:49:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E4B969335;\n\tSun, 24 Aug 2025 02:49:32 +0200 (CEST)","from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF1CF69318\n\tfor ;\n\tSun, 24 Aug 2025 02:48:59 +0200 (CEST)","by mail-wr1-x432.google.com with SMTP id\n\tffacd0b85a97d-3c6abcfd142so521730f8f.2\n\tfor ;\n\tSat, 23 Aug 2025 17:48:59 -0700 (PDT)","from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"W9fTnZj5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996539; x=1756601339;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=cGnuc3oH2Zv0CIpm6TpMDmVr85UAoXc4ZgYEook1x98=;\n\tb=W9fTnZj5o6sMfbmMayBlJvNehIiQ98SLkbSfZST8ZyqmUvaGtcCfQ6MT7Rf3hwmb+4\n\tc7VxTZeVzjeo5r+aAG9nCdTDpw68wuNqcdRtDpaJpctGA7roNt8qvXVC1gihk0NBLkKM\n\tRBUBAQiaQ68TaJ9ZOYezsXfqjEqK9p7b218oI+7MfFgqQkcIpXljJCeY+OO77AzRIy+l\n\tA3/fY5LxczXkoR1qqeWm+DDTdiGwAGz3fmnYcXfDTvC77fkxPGmr2MPITDTteHKr9Ral\n\tkhIncRNy3vNPdnoOnknWkbwxBdLDSs/fOB81kMeSOpRFx+AITDR7sr70pYqQdDPIZQG7\n\twZcQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996539; x=1756601339;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=cGnuc3oH2Zv0CIpm6TpMDmVr85UAoXc4ZgYEook1x98=;\n\tb=W0nxce0VDbRFTrF5GKYGjAnyfmX/jDJ/yM5PoT106ruSXbeYK3g/QutfU7nAJb1V0D\n\tQzNXhsaTRyaVX8U1MzKr5ottcv6SuBhpzvQDxp5FeRcjlHf7biY7DQGlxTvHHf1tt0tg\n\trEUGzaFUQmw0QsLR/z9gjzrpwDpViLT/shY4xAbdvwQWwB/BTmqV3XQKXC+bM8oJoCEE\n\tGgomrSqkAjZThx/EQALFcK7T8EbLdtFYEMwmc69KhBQPZADqIyDLqkkFqY+77QfVq60J\n\t2tRqvUCBXosscEOWnUs56gmcW+1FbqkvkQNmN44hc5wphTmiFwbZEdEsFciHEXgVvspv\n\tBkFg==","X-Gm-Message-State":"AOJu0YxZfqTm6DfMeBF5alY+5XhI2dNgmvE317t0jgyCxiA2/ODeEKJL\n\tE2ui01SZIE3ZlOmq0I3iM6TpHOi9Zy6yEds4Y1C68plewSF5SiD2F8ZXuieg26xSkGE=","X-Gm-Gg":"ASbGncsSwL3c4NgDj7AKkfkl1Zfid+Is65SwSIhwNbSToWX5+DUFkGNZupeffdJ+EW/\n\tnsWbyxBPXDhTx6Kft+fsbOVkRELxlSaQ/dtAELRWZWzKykAK4D1IdfU45LmG+4iQ8i4ghJUJ1o2\n\t3dTWBvWmynaCv0bg6hmIMD885fHu1eca0eFizog2WCsarWpAQSBBW35hwUQ/UZAJRxtLqh0sI1J\n\tf6JE8hpKYCtX/2oZ72jg4W3QvwYiyzMPRdiiDfBMmzjHlCoW1aa2r/am4ijNb5MIJBJnBj3Pw3w\n\tyXI5TH3sWw9mdkpUrZr6E02HYjI1sDbGX0cOEkXUYVouZPA1i1sJJgFf51ccEePZeXhjxhbAeAh\n\ttNqFLDcBjB8YGRygUqy4k0UsW/iKIk20Nfm0hKB+RH1VEHKQCF6DAD8IqQrsjkowrMv/c84WxaN\n\thxjZQijLY8Ei0dktKqoBcgg/9MJdxYyRA=","X-Google-Smtp-Source":"AGHT+IGZUlWIRSduMFuwzidZXW9fNNd17+UNu/ghKCIcwOsdWhTItZryN63/FtXEwMgzHFqYN96BmA==","X-Received":"by 2002:a05:6000:2902:b0:3c7:c94f:6630 with SMTP id\n\tffacd0b85a97d-3c7c94f6996mr1470303f8f.19.1755996539412; \n\tSat, 23 Aug 2025 17:48:59 -0700 (PDT)","From":"Bryan O'Donoghue ","Date":"Sun, 24 Aug 2025 01:48:38 +0100","Subject":"[PATCH v2 26/37] libcamera: software_isp: debayer_egl: Make\n\tDebayerEGL an environment option","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-26-96f4576c814e@linaro.org>","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2003;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=S+AGi1xySbJ7v3eeQdyrHBWqFirnsX1ibi33DOs9eFI=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFhwMkoZmCmvPqvOYIbA2A+SmtvhPpUxAglo\n\tO+t4mB2T0GJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphYQAKCRAicTuzoY3I\n\tOn2lD/4iUX7rTUtiS2krUP2S67wtkSIfRt+wHrzun4B5yhDszWcKXMPX1Exq+zf3WKn7gwazqmv\n\tED28QlVL/vvqu6i7hlNymL58T03kwBlo86fEpZ0VREmN41RFWUWE5XT6xw6MiVqR9dkP2aOm0t1\n\tIHg1ZosmfDG/0UJ8Bm5xlWb41DEdc59H4X93ZbruJxIbZhlqI9QEGrMHEqM3mAlOKvKHMAqedy4\n\tJUNctll9IdJv4+m1JVxpVTA836wRc4P5qvBPwOzoi4EpZKjvEEz3BKFp6yD83a2FZ9O+k3UxUM2\n\tYdHMIItnZKvfGpjuTusEtiMnmR37xirhAFvVqNlttFPZtAZFnbqeFpo0L2tkMzmeNd9+Mw/lWbS\n\tTjehgYowKXo1E0yuYUXNgnlvAw+NuHdDKIkZs6vCrE/XquUhEelnwD9nJfA42ma+QPKlChrokEK\n\tTvI+xBKwrhozOLYGu8wNIvYumYtyZi3VEDo9D2efaNcYo7tHmj8btUvduSQBt68EI85mULI30pY\n\th2fYysTTU4ppzSd3rBJqJp0IiZyf5xitEfwVQ1zBaqj/LrEU92rkvH91yVsFGxF2DxUNqhEK30p\n\tiqOjbm6MhACIOgJfSXO3TYAegVVu+3zQzsX8/qi3R2HuSb6F/t+6cqQMVlVZe+edJYxTRCQ3Loz\n\taj81O+om0BpGfVA==","X-Developer-Key":"i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If GPUISP support is available make it so an environment variable can\nswitch it on.\n\nGiven we don't have full feature parity with CPUISP just yet on pixel\nformat output, we should default to CPUISP mode giving the user the option\nto switch on GPUISP by setting LIBCAMERA_SOFTISP_MODE=gpu\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/software_isp.cpp | 19 ++++++++++++++++++-\n 1 file changed, 18 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex e6bf76f214280194bc20aaaed4b5bc96598436fb..583f16ebb2b0f08ba1df055fbe08c44b5aac5a01 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -15,6 +15,7 @@\n \n #include \n #include \n+#include \n \n #include \n #include \n@@ -25,6 +26,9 @@\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n \n #include \"debayer_cpu.h\"\n+#if HAVE_DEBAYER_EGL\n+#include \"debayer_egl.h\"\n+#endif\n \n /**\n * \\file software_isp.cpp\n@@ -114,7 +118,20 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t}\n \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n \n-\tdebayer_ = std::make_unique(std::move(stats));\n+#if HAVE_DEBAYER_EGL\n+\tconst char *softISPMode = utils::secure_getenv(\"LIBCAMERA_SOFTISP_MODE\");\n+\n+\tif (softISPMode && !strcmp(softISPMode, \"gpu\"))\n+\t\tdebayer_ = std::make_unique(std::move(stats));\n+#endif\n+\tif (!debayer_)\n+\t\tdebayer_ = std::make_unique(std::move(stats));\n+\n+\tif (!debayer_) {\n+\t\tLOG(SoftwareIsp, Error) << \"Failed to create Debayer object\";\n+\t\treturn;\n+\t}\n+\n \tdebayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);\n \tdebayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);\n \n","prefixes":["v2","26/37"]}