[{"id":35575,"web_url":"https://patchwork.libcamera.org/comment/35575/","msgid":"<85qzwyl1qz.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-08-26T12:13:24","subject":"Re: [PATCH v2 16/37] libcamera: software_isp: debayer: Introduce a\n\tstop() callback to the debayer object","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> The eGL class wants to be able to teardown its sync_ data member\n> properly but, doing so in the destructor means we can't make the eGL\n> context current and thus can't tear down the sync primitive properly.\n>\n> Introduce a stop() method to the debayer class which triggers from the\n> softisp's stop method, allowing a controlled and appropriate tear-down\n> of debayer-egl and egl class related data well before the destructors\n> get invoked.\n>\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/software_isp/debayer.h | 1 +\n> src/libcamera/software_isp/software_isp.cpp | 3 +++\n> 2 files changed, 4 insertions(+)\n>\n> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n> index 214bcdd3c535bae7851d6e0221ba68c19785507d..352ffb89ad9d5a32ed1bbb14253af5e3f21d508c 100644\n> --- a/src/libcamera/software_isp/debayer.h\n> +++ b/src/libcamera/software_isp/debayer.h\n> @@ -47,6 +47,7 @@ public:\n> \tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size) = 0;\n> \n> \tvirtual void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, DebayerParams params) = 0;\n> +\tvoid stop() {}\n\nNot virtual?\n\n> \tvirtual SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) = 0;\n> \n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index e8fa8a17a11c63ebab1338a90df204f4a888c4d6..e6bf76f214280194bc20aaaed4b5bc96598436fb 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -363,6 +363,9 @@ int SoftwareIsp::start()\n> */\n> void SoftwareIsp::stop()\n> {\n> +\tdebayer_->invokeMethod(&Debayer::stop,\n> +\t\t\t ConnectionTypeQueued);\n\nThe line break between the arguments needed?\n\n> +\n> \tispWorkerThread_.exit();\n> \tispWorkerThread_.wait();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 595BFBEFBE\n\tfor ;\n\tTue, 26 Aug 2025 12:13:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C511692F0;\n\tTue, 26 Aug 2025 14:13:32 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9ED3692E1\n\tfor ;\n\tTue, 26 Aug 2025 14:13:30 +0200 (CEST)","from mail-qv1-f72.google.com (mail-qv1-f72.google.com\n\t[209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-315-iKSIB9FRMvuiho_LmLcnVQ-1; Tue, 26 Aug 2025 08:13:28 -0400","by mail-qv1-f72.google.com with SMTP id\n\t6a1803df08f44-70baffc03dbso85595026d6.0\n\tfor ;\n\tTue, 26 Aug 2025 05:13:28 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb ([85.93.96.130])\n\tby smtp.gmail.com with ESMTPSA id\n\t6a1803df08f44-70ddadcf6b5sm1033036d6.37.2025.08.26.05.13.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 26 Aug 2025 05:13:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"hrHVLfTY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1756210409;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=3zbvpR8WgZRAu8qPw/T98qLr94Nb0j2dy08BKEzTkF0=;\n\tb=hrHVLfTYRWC/FMijdETbR2SkzgDdKdDZlzHfH1jD63cbXTFEu9TmQHABmktAIVWpSW42gt\n\tAt6tAMbqW4NnN7XZohEIz3qIhRUe24jlLBv7ar1a7Sl29UubTLMH3mxkdMoZ9SxpN/bAjl\n\tVC+7ogjltM/KhTXgUKDkQJK/yrxFUnw=","X-MC-Unique":"iKSIB9FRMvuiho_LmLcnVQ-1","X-Mimecast-MFC-AGG-ID":"iKSIB9FRMvuiho_LmLcnVQ_1756210407","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756210407; x=1756815207;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=3zbvpR8WgZRAu8qPw/T98qLr94Nb0j2dy08BKEzTkF0=;\n\tb=hER+5cqwc/wsOKR4Kh63boYEbXOlMfKqrFpPyZSGqv0QU9WwU77CKJJZucIuXxaOFP\n\th4WT7evZhEN3T/KRbhG5Ndg2jyYBh/eKLw4ZmaRfNZILiehZ1RDD2C6tG2MQf2T7vFi3\n\tax+FYs6c8hwroc9n98RyO6WyDhpdgB1PuIZLzhg6CgMijQkNan4ZOdwBgOY332lIsFhX\n\tWPQT6zniyBX2pBzOrUK+YcYlWio8dhWB+T6QFJSC2XTlRJv3U1RxT6zl3QqlMw9R/Vuh\n\t+XpY6OfaCbl4qnHtvCqRbxcZ0GMdPEyj/X4WhE1TOqKzpAEOlFcRLBBdyikazbGUeppz\n\tSYAA==","X-Gm-Message-State":"AOJu0Yw7g37/wRvKjJxpGdBJjn9BJW16lH4ZeQMRWr/k5sDmiNsTinMs\n\tIYz+szj4wJxBRsYlABE+HvInwgt0mqlx8NzOMB9xGfEO2TCswtwtI/NgvbTuQz4Eln57oMbG4Vr\n\tBvgf40XNPlh8ZlA743yjgdBqluYtY8UmAo8+G1Ps6QByb+5O9kKwSfRhmR4XpCc+D1GuWLnxz5E\n\tCZC6Tm9X0BgbphapwI6F21Q7/DXGpgcm0MqGsT3Xa67N24jDUhg/TOyfdPt5g=","X-Gm-Gg":"ASbGnctugxJBNHOXx2oTjpZ2gBE8rj5DsJ832sF9n0rzfFTiQI+WyW3bq7kFK8zPITv\n\teWG/mFo9so/nXoFmN691/AoPCt+EbdcJk98tClbn7rGhJyhyWJbkxRXSNpqhOlYqipAjgLumHOc\n\t04IH+heq8xY5ZX8XjGIcak/ZqmIfzAjHX46rt6tBe6lud0iUmEHgf5R5kL1EchQQb1zXYdecCSR\n\tJG8xNKDyYJd62gcH/Eiub1vhiVMIcW93RcI5SDbZAItvjNOM7QLs1wu3ozqK3rzRCJDNarwz6JU\n\tojyLC+cbRR0uDay62EO1HHyPNu9fA0lK/TVisUUHgk2ZLo/Te2k7jzg6lMDIMh6d","X-Received":["by 2002:ad4:5bcd:0:b0:70d:9f19:2ab3 with SMTP id\n\t6a1803df08f44-70dd59c0741mr10499316d6.19.1756210406740; \n\tTue, 26 Aug 2025 05:13:26 -0700 (PDT)","by 2002:ad4:5bcd:0:b0:70d:9f19:2ab3 with SMTP id\n\t6a1803df08f44-70dd59c0741mr10498866d6.19.1756210406175; \n\tTue, 26 Aug 2025 05:13:26 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEWWPRi2pGivKEOoHn0XmPe8eF+vSXbtZA0SK1sy/Yk2nrxBbI88wRfnWzS6ALuxWHuwM6aPg==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 16/37] libcamera: software_isp: debayer: Introduce a\n\tstop() callback to the debayer object","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-16-96f4576c814e@linaro.org>\n\t(Bryan O'Donoghue's message of \"Sun, 24 Aug 2025 01:48:28 +0100\")","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>\n\t<20250824-b4-v0-5-2-gpuisp-v2-a-v2-16-96f4576c814e@linaro.org>","Date":"Tue, 26 Aug 2025 14:13:24 +0200","Message-ID":"<85qzwyl1qz.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"Y5f2rcQtmx4gQNKj2P4rzNVMDikT1HqcMbJNNbOGrq0_1756210407","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35577,"web_url":"https://patchwork.libcamera.org/comment/35577/","msgid":"<3a671244-84a8-48f2-bfba-3d7db121dae5@linaro.org>","date":"2025-08-26T12:27:25","subject":"Re: [PATCH v2 16/37] libcamera: software_isp: debayer: Introduce a\n\tstop() callback to the debayer object","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 26/08/2025 13:13, Milan Zamazal wrote:\n>> +\tvoid stop() {}\n> Not virtual?\n\nDidn't seem worth implementing in cpu_debayer.\n\nI don't mind changing thought.\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4052BBEFBE\n\tfor ;\n\tTue, 26 Aug 2025 12:27:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15E42692EF;\n\tTue, 26 Aug 2025 14:27:30 +0200 (CEST)","from mail-ed1-x531.google.com (mail-ed1-x531.google.com\n\t[IPv6:2a00:1450:4864:20::531])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F1AC692D5\n\tfor ;\n\tTue, 26 Aug 2025 14:27:28 +0200 (CEST)","by mail-ed1-x531.google.com with SMTP id\n\t4fb4d7f45d1cf-61c91956560so1278538a12.3\n\tfor ;\n\tTue, 26 Aug 2025 05:27:27 -0700 (PDT)","from [172.31.14.217] (static-243-216-117-93.thenetworkfactory.nl.\n\t[93.117.216.243]) by smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-61c5010e151sm5307638a12.4.2025.08.26.05.27.26\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 26 Aug 2025 05:27:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"FBQWa3i8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1756211247; x=1756816047;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=34aUHq8QgWse0gF7gMdzQhs4i77g7t2HAbVCGoQs+xk=;\n\tb=FBQWa3i8TfXqPBCd71g3SWjQr1ORACFsDgZbII8Mv+r42LxJa7LVaAvxC1QSQdi1gz\n\tImKJX2bXN7o23JZ4/rM9wd2NOjfW2oob/efQJy1Uyt9VDnUlPVXgmFck9NrVlnRtuuYv\n\tEcmkRlfDc0Jf4sE/qArgxzId6/1svfTunptlkB8QX0kFt5fAr9A6aEje7wvNTzdR1Kvm\n\tGqyNikaidZyqdYrof8K1/x7P84tSxnZeF+4raNJNzU7mQO22dXmq/xy9flqvX0XfJaDF\n\tqQoaXlgSWkkwlOzz7SxByzdrr8dcDZMCutE5wmL+75Iuj53fZUjfw7s6OjVIfxQ8+ZRC\n\t7Oaw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756211247; x=1756816047;\n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=34aUHq8QgWse0gF7gMdzQhs4i77g7t2HAbVCGoQs+xk=;\n\tb=WhGw5nIPugSEHRhDaMLp0mLg6JG/p1INnKOrBjfI11/6CKejIokhmLhCDuWblBi/CZ\n\tZOKe8m2VIofNnbdwN76F6yL7WKA40wzmumHMJCMPEDBAzv44O0Ve19hNWbt1qA5jnczi\n\tz+j7O0rmB4Xk2uIQE5VbBuht/QVWzd419jX+nM0x6/o37xondaeNKNgEcscfIQ7fDkWx\n\tnqfts5sPgqdXxJ9da0LSIPm26nK3q91TW0JPJ7LFFSvjzME3uXUcLI4qArqtWnWqg89R\n\tV6ZJZ4IddRCcLbKf3OD5EPJ3w5w5SvidPhcpfd1e1iQ7PsQ23e5rt9ciznnsJ9F9B+5R\n\t0QfA==","X-Gm-Message-State":"AOJu0YzpPlViB9beuelBKo/RGI9bSkvwwq8r7/DxzkPJOlLZ2iME3nFy\n\tSG4brsb/pcMsONPRQ4Mn9ylCmcYtG60MTqH1D0jmCkwygfw74CxgzScAIMyuVP0bcvQ=","X-Gm-Gg":"ASbGncuPnWG5gZhUZUNpx1kuuDUqIUuldWK7xNihocy07rySMxGLhrAmMXa1/uS7TTW\n\tP4LENdxaKdE/X5fLAkVQSHT/hGnbBKjT1+6xQ17+UUeQwqzNnKn7voJkzTBjyMknvXWmnHRVt1o\n\t93s9Z9tZy3eXrN68SlCx87SiOGU+piD6L8X/FfLxAGpYve3fXScE8M7bNJcWsek4/gQROfkXXAn\n\tA6rTaBNwKREqh1ILSeZZ+QFQy2aDuTvdkOvbNInck0Dppha22wPhM7isV4h8VM+ih93f/6C3PSN\n\tu48D0h0jRLXTx7Cg0abR4CYD0BA/nIqhNeIaFEni7/G6Prl9frZpjoREBh/br7+p9WuHIgeCn2v\n\tdxU5HHos3eJExDQtlyMdZHLKGpEiLmVJjBXBGnBG9KLOYei3fFXcWDueyo8ig8fJgcSprZadURa\n\tcj1ND8LNMO/qzM0DQYN4Vs2WYBRn4oY5FLnuz33HgHhw==","X-Google-Smtp-Source":"AGHT+IFSeLvBoCrdr90/AK+IZ1Oo57CxAQe8lwk/7NbapEDKrzS7NVjUKRIcvLip3WRVR0DIteZ14Q==","X-Received":"by 2002:a05:6402:2711:b0:61c:768e:a885 with SMTP id\n\t4fb4d7f45d1cf-61c768eaa4cmr4788595a12.10.1756211247357; \n\tTue, 26 Aug 2025 05:27:27 -0700 (PDT)","Message-ID":"<3a671244-84a8-48f2-bfba-3d7db121dae5@linaro.org>","Date":"Tue, 26 Aug 2025 14:27:25 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 16/37] libcamera: software_isp: debayer: Introduce a\n\tstop() callback to the debayer object","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>\n\t<20250824-b4-v0-5-2-gpuisp-v2-a-v2-16-96f4576c814e@linaro.org>\n\t<85qzwyl1qz.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<85qzwyl1qz.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35578,"web_url":"https://patchwork.libcamera.org/comment/35578/","msgid":"<85ikial0ec.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-08-26T12:42:35","subject":"Re: [PATCH v2 16/37] libcamera: software_isp: debayer: Introduce a\n\tstop() callback to the debayer object","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> On 26/08/2025 13:13, Milan Zamazal wrote:\n>>> +\tvoid stop() {}\n>> Not virtual?\n>\n> Didn't seem worth implementing in cpu_debayer.\n\nIt can be inherited there. The main problem is that\n\n debayer_->invokeMethod(&Debayer::stop, ConnectionTypeQueued);\n\ninvokes a wrong method for GPU if I'm not mistaken.\n\n> I don't mind changing thought.\n>\n> ---\n> bod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0ED4BBD87C\n\tfor ;\n\tTue, 26 Aug 2025 12:42:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D509E692ED;\n\tTue, 26 Aug 2025 14:42:43 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7ED6C692D5\n\tfor ;\n\tTue, 26 Aug 2025 14:42:41 +0200 (CEST)","from mail-qv1-f72.google.com (mail-qv1-f72.google.com\n\t[209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-146-FSlkA38WOaWsuwA-mTIoNw-1; Tue, 26 Aug 2025 08:42:39 -0400","by mail-qv1-f72.google.com with SMTP id\n\t6a1803df08f44-70d9eb2e970so111895076d6.0\n\tfor ;\n\tTue, 26 Aug 2025 05:42:39 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb ([85.93.96.130])\n\tby smtp.gmail.com with ESMTPSA id\n\t6a1803df08f44-70dd6a9a706sm5716926d6.17.2025.08.26.05.42.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 26 Aug 2025 05:42:37 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"MG0V5Ell\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1756212160;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=niv4q2KCYJ76c7NDFxWR45ajVu6wV36fCmzBt7lwx7A=;\n\tb=MG0V5ElldSJ0BUnQiQHGvZMGYfePGDRd4ZzefbBrco512pVgEUPNCervrxJ3LE92hhVIes\n\tLb/sKzZscvdbFvzPD2bm4DesdcxF1C4dhh9OWooZq0vJ2w+A2rvjACa3DWAiuzP+9dEIWt\n\tU+bghHsZmVK5r1dmj6z3C9rdGK7A45g=","X-MC-Unique":"FSlkA38WOaWsuwA-mTIoNw-1","X-Mimecast-MFC-AGG-ID":"FSlkA38WOaWsuwA-mTIoNw_1756212158","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756212158; x=1756816958;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=niv4q2KCYJ76c7NDFxWR45ajVu6wV36fCmzBt7lwx7A=;\n\tb=UYq207+oUuqxANR8lCqFWr36U1rDla0rCuwynGfMxsoRVMmaYlGVVXX1C/QRahgy5a\n\tBjS406sJhPFTBqY65s8VoxOcikwV4bEuFDNUjY7lhNpBErcUpIx+YZH01p3LM1EeV+J4\n\tGh9OyIRLoKVMKTc3zgAQke5AbF2+eMIoS3nweQTc9j9qCi6to10AAOV8ZrM2bGrmR63z\n\tCHCZZILfGzPG6QY3A6p9CElvvkH4SWc/F8JCA0cOMkHN/Lhs33YptXW/GTHJb28B4LiT\n\t53gk/Eqg7khtQu1KrKDxwpD+NsVry58gNNzjHd/EPP/7lbYiO3HCqe+7tiYx5sE5xaDq\n\tDoJg==","X-Gm-Message-State":"AOJu0YwobnBDnp82OZZxqxfbkgjehbcbbCvzqqt/8gEnnzXqjnECnfYw\n\tGYXw/GmKVj1kArJjkeMapzh2FJY1Ud3WKsNBaKdmmj7+skhhdZh9qNmh6hBF46mrMhe2MPCq58y\n\tVFz3bsLupiiVspwL0KaISMBiH+Xr5HY3brHv7NEmGSkeWzD/u8L5A0UpwNEBM+oXzACHm20tAD4\n\t673FzLsvZEhtU0v1BAK3jo9j6y81399UlOzzZM1DL49a/pVFqxYzXi79mW2k4=","X-Gm-Gg":"ASbGncsC3io1bTXqESTe4vE6qHo25nZAPDHPu28QhI2EMr1R+tUfjy6hvraCO2iMJdo\n\tQnrTMf3VqM5EQHfX9+2raoLEJg6DN3H28VadQ6SIMz3mK8+7AaPD2tW4PKK0hKtbSueM6P4zu9B\n\t98qs4z+SI+l/me9To/zQYbrishh6+V7/I4TJZHtXYk+ajvzcLo+akg1ijICq8QFVlyJkTmlI5to\n\tTx6zxXk248z8cIMflh4fv8Ukirm9W926fB57m8iUbaRxSa+fs0QxTuOhp6LuB7tag1mWAPLeLXU\n\tN1HoJ4AhhtFI1azfS5wqvqSXeCDNxjvjhONbTc8+HXvnPVqvEb1IK+MQROf5bGL+","X-Received":["by 2002:ad4:4eae:0:b0:709:8749:927a with SMTP id\n\t6a1803df08f44-70d973763c6mr208656886d6.50.1756212158183; \n\tTue, 26 Aug 2025 05:42:38 -0700 (PDT)","by 2002:ad4:4eae:0:b0:709:8749:927a with SMTP id\n\t6a1803df08f44-70d973763c6mr208656576d6.50.1756212157650; \n\tTue, 26 Aug 2025 05:42:37 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGDU0AKMjikukGrJBmU8XmLt0rT8SI2bQGYTqzanop6CtvSJv6AGZamJsksDuH4W24wTVNWJQ==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 16/37] libcamera: software_isp: debayer: Introduce a\n\tstop() callback to the debayer object","In-Reply-To":"<3a671244-84a8-48f2-bfba-3d7db121dae5@linaro.org> (Bryan\n\tO'Donoghue's message of \"Tue, 26 Aug 2025 14:27:25 +0200\")","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>\n\t<20250824-b4-v0-5-2-gpuisp-v2-a-v2-16-96f4576c814e@linaro.org>\n\t<85qzwyl1qz.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<3a671244-84a8-48f2-bfba-3d7db121dae5@linaro.org>","Date":"Tue, 26 Aug 2025 14:42:35 +0200","Message-ID":"<85ikial0ec.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"rVdwgNfjRa8pdo1itIuArMrQryoatUnXBF1Acxn4-yQ_1756212158","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35579,"web_url":"https://patchwork.libcamera.org/comment/35579/","msgid":"","date":"2025-08-26T12:44:17","subject":"Re: [PATCH v2 16/37] libcamera: software_isp: debayer: Introduce a\n\tstop() callback to the debayer object","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 26/08/2025 13:42, Milan Zamazal wrote:\n> Bryan O'Donoghue writes:\n> \n>> On 26/08/2025 13:13, Milan Zamazal wrote:\n>>>> +\tvoid stop() {}\n>>> Not virtual?\n>>\n>> Didn't seem worth implementing in cpu_debayer.\n> \n> It can be inherited there. The main problem is that\n> \n> debayer_->invokeMethod(&Debayer::stop, ConnectionTypeQueued);\n> \n> invokes a wrong method for GPU if I'm not mistaken.\n\nNo you're right :(\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE250BD87C\n\tfor ;\n\tTue, 26 Aug 2025 12:44:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 69FEE692ED;\n\tTue, 26 Aug 2025 14:44:22 +0200 (CEST)","from mail-ed1-x531.google.com (mail-ed1-x531.google.com\n\t[IPv6:2a00:1450:4864:20::531])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDB20692D5\n\tfor ;\n\tTue, 26 Aug 2025 14:44:20 +0200 (CEST)","by mail-ed1-x531.google.com with SMTP id\n\t4fb4d7f45d1cf-61c7942597fso3297997a12.0\n\tfor ;\n\tTue, 26 Aug 2025 05:44:20 -0700 (PDT)","from [172.31.14.217] (static-243-216-117-93.thenetworkfactory.nl.\n\t[93.117.216.243]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-afe7c93b86dsm54823866b.21.2025.08.26.05.44.19\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 26 Aug 2025 05:44:19 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ceeTkHkH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1756212260; x=1756817060;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=f4xnyliTG1wE4san/dAZ6IaatrKowY3df5jCYz230mA=;\n\tb=ceeTkHkHU2UhN/lsrmo4ZwVuscj9aDnxInEsBVzmIdNG9Bh+FIX+ZKV1bqd3htBqPP\n\thodzYVf57lgvgn+qqOo+z85CGtmQ50zQe1m73b9topggmx/X+SEeM9YLtD7zpW7PKbSI\n\tOUytjxNrQ64uZE1FV2SsPe0D4O2+YHMLFTHBU8Bv8pRivAvlLzFdT05ostdPZQ3KPTox\n\t7pp5P5+lhPPaitGtZ56X6nOZF96yq3mzK2SXxCgri0LNAK6IndUepbD6Rc6PMK3pDChI\n\tjZbnwXTZz918l8rPIHwUcM7nKPrF1Kff8+2gPN4V/RYky94ydaGP0zXscsZC/EedT3sH\n\t3ZRQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756212260; x=1756817060;\n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=f4xnyliTG1wE4san/dAZ6IaatrKowY3df5jCYz230mA=;\n\tb=n77LDQvcYkeyxeFEgvAk9y0faON/RsObyd9Abfzc6wkUWfWfJySTNw6CNhZDAfgQri\n\tafe6KR9TLUD5f8fAIgKo/fmUH/ucoet4l6G/mIwP41o0988Q4gQjlH11k00xFPN4cQZO\n\tDelHH2NSbHGOaBlPXeni/XRmKXf8IXGuCNllwjotmNGlHuNNtUAb0DSB7iWWROfzgnRM\n\tTbAGNFxPcfHSSoQvI8GeRwb3IZY5HYPFq/4DRg5cj/66QxgpfoXLadq5wHye043pE1Od\n\tAFKOH2cQTvp5vPv82WdlHLnhq4JktcELSQ8RPDToxTKjD12dFxrBwhFCVQiiZTTaQG/t\n\tloKA==","X-Gm-Message-State":"AOJu0YxpWDy/r4A8cJMbRRlj0fZ/lHnVIAjdb2M20iQw0uiViU6hgFwV\n\ts+8XYNGJlYEPNu5bpVkXGNmrHCj2EBp0q++00gdpZOoaChvAKLGeY9cbqBKSBfZWn9Y=","X-Gm-Gg":"ASbGnctfVoMxsBOrosa9uhXyGHGwT4rshlyciUAJDJ7RsABnKiTNbvZesULFkJevqLH\n\tW9pj334XmC/7EY6+g6JofT8TOwUarrAhkxwHfxYOyjfT0OhXQM5BtiAIjC5aCHAt7tEgyRdG1cX\n\tRYq5ErpNXdcaorbzzpuYdRuab2VoJk3CkRl2Ln5ZZERpD+s5jyYExnNAo8Nnx2Rsc6Q0S5C7bmp\n\tXQS8jkn4X27nRUHljBuzOfURBSvmlJ87mJSrSqrL1cUn5nrYuCjUXMkn/E0mKrYyJOxDXHE55Ln\n\toCCHlT0o7q8sKxstTgGTRQZ6nlrfQJp55NKlg/M0TU47rmnRGhkAc6PnOw9J3qVYOrNq0dmRhGX\n\tW/gtb3bL13Z9+hxcNdr0Gl5hrSN2o4RldIpGnjDt+4RRFVodHTq8GfTtTk9X7OHRGy+wFHiIAFT\n\tOMd9CZRSV1GuzdIop/qDkfKOCVXfioZGGyJdmeGPqr1Q==","X-Google-Smtp-Source":"AGHT+IH2jF4NNRy8Cd229fhSX69pDjyYuGlETBXJtppOkGz4tlpqAZjSXvgiQSzPHa+K0ISmRepjkg==","X-Received":"by 2002:a17:907:7f9f:b0:afc:aac3:6d2 with SMTP id\n\ta640c23a62f3a-afeafecb0f7mr145280466b.2.1756212260232; \n\tTue, 26 Aug 2025 05:44:20 -0700 (PDT)","Message-ID":"","Date":"Tue, 26 Aug 2025 14:44:17 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 16/37] libcamera: software_isp: debayer: Introduce a\n\tstop() callback to the debayer object","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>\n\t<20250824-b4-v0-5-2-gpuisp-v2-a-v2-16-96f4576c814e@linaro.org>\n\t<85qzwyl1qz.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<3a671244-84a8-48f2-bfba-3d7db121dae5@linaro.org>\n\t<85ikial0ec.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<85ikial0ec.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]