{"id":24195,"url":"https://patchwork.libcamera.org/api/patches/24195/?format=json","web_url":"https://patchwork.libcamera.org/patch/24195/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-12-96f4576c814e@linaro.org>","date":"2025-08-24T00:48:24","name":"[v2,12/37] libcamera: software_isp: Start the ISP thread in configure","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1578d8bb23a077b2af27ae5277ba772b5d83063c","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24195/mbox/","series":[{"id":5400,"url":"https://patchwork.libcamera.org/api/series/5400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5400","date":"2025-08-24T00:48:12","name":"Add GLES 2.0 GPUISP to libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/5400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24195/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24195/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C7C7C32BB\n\tfor ;\n\tSun, 24 Aug 2025 00:49:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2746E69303;\n\tSun, 24 Aug 2025 02:49:03 +0200 (CEST)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE72A692FF\n\tfor ;\n\tSun, 24 Aug 2025 02:48:47 +0200 (CEST)","by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-45a20c51c40so26179695e9.3\n\tfor ;\n\tSat, 23 Aug 2025 17:48:47 -0700 (PDT)","from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:46 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"qaZziY0M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996527; x=1756601327;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=TfqtxqIsqCyESJnF4snpoyUimWkfpfXPHPpywJRlG8M=;\n\tb=qaZziY0MGAFqB7rKcFX+R7n15UofoSHdoZ7L4JACONYe3FpcK0gZviw7Mm5Bte61ew\n\tYYNG3NodYgWurLmslKs4/UUAnnE+tGI7EjDaQduNctaiepbmoy3P5cPuOJrH7UtSRVlu\n\tPdYBJ3Ek+S96U3Y5fYREVdZBIrW69xsYz03r9MRnIo0PgD9VtMY5QS05+r7abIFvEKMf\n\tp3lD1mUZZfOfmhXYBJnkwNp5D/rFfOXFexgiqI0rPLV98OejJN1dmmBvzoi8s0j3iDN9\n\tA6ejvK5tjY4fNqwUJtWQZJFMHWk3Vt9UUsA+tU1PnXam+/N7VlVNqtaX+3xWhP92NMah\n\t+6dg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996527; x=1756601327;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=TfqtxqIsqCyESJnF4snpoyUimWkfpfXPHPpywJRlG8M=;\n\tb=X1lmNGbM3b4nBRxM3QtuyEq71kTmKiaG2xTS1QDmEcBKBuUzHV1D4ITlUgH8j0RzVu\n\t/fMFBLrTPZ0x1QDRYsOLo/0La4KTapkNjYspXU+2AscCm2Wh/+MTEkMNPwGmQPm9fRtB\n\t0b5Gl9p3mXX7NzIMn7T8QS6LhH8tewsguainZrNXv/jhQprghbyWO5d3yKaeDoyd6Ah+\n\tCSqt2dV9oTuJvVZEYZiMHN+RmbzdqaIgxqpY99xu1GmCTthXfcSydFESKhHqsSIq/yde\n\tf+wVy55HWRtqaWlSlhMXjVAsIsXaTcRMXoscA2I6nWR+mc5tWXbo5kUH39+4pCgnpB0E\n\tOfWQ==","X-Gm-Message-State":"AOJu0Yx1/9kIJZQHBsk3b8hhth6fyvGFNU453Q+Yw6sxzLB88R98LA6a\n\tmJ3toBR5cykPhgbs/gH4+q/iAgTEujX3uw3nf9r8vsAdr25ocv1KbzFb5xiBiduZM1O4GFxE4l5\n\tiuD5V0qU=","X-Gm-Gg":"ASbGnctV4xD9XiXHEdJaGlAy7SWhfz6Ms45HGxqGmOIMxi570J+70tjsGZEF9BQYfDo\n\thGTtVu9l8udBuMEOLYrGR+r9fQ5FvZLSutWRZkMrPZ3qQSgdzC1jQ9BhrcYc/5D8NUQhf6EzWR0\n\t7tP8b8WPk8Uw1nsMT9nM/XSazJnEpdlVIBAKzx5AYW4oLLRFvpl2oQ2LVy4JEzaOn+ybwRHv99L\n\tqOoairF9q9UdS0Bmq4Flb0dRNSXSszi5b9TfGJJmrpAkS8CcO8llnM7j9UzDZbXKFW4H9CMi3fp\n\tw1z78N699ZwwOUGwtTFebnMDaZGTmPUvSbr4QGAUdAyVgRqEEqZTu3iaSsGUWkEQQdkt3toMXvp\n\twh7h0nomtHub7kBBhAdxh28iRK4PNsiG98grVdX7uL3oSyqVcT0SAUg0gE14sH2CPaGRQhki+pI\n\tGyv5ouuoK9yYsvjJO2DAzl","X-Google-Smtp-Source":"AGHT+IHVYpyMhUzef8/MU7qtnMuTb0LPjXYvgtnuFBz2R27BdOn6KOb+hvZPwlh9bYKpS9glrGXD3Q==","X-Received":"by 2002:a05:600c:3212:b0:459:df48:3b19 with SMTP id\n\t5b1f17b1804b1-45b517c5df0mr47197135e9.18.1755996527241; \n\tSat, 23 Aug 2025 17:48:47 -0700 (PDT)","From":"Bryan O'Donoghue ","Date":"Sun, 24 Aug 2025 01:48:24 +0100","Subject":"[PATCH v2 12/37] libcamera: software_isp: Start the ISP thread in\n\tconfigure","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-12-96f4576c814e@linaro.org>","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1811;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=TJz2c1i4gj5Q/xRIyCEfIizExQxLMBanHSgh1qaIxXA=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFeekoGOrHPNkZ23S1I4csSplTg6EZM/0FRj\n\tK8OWRwCG6GJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphXgAKCRAicTuzoY3I\n\tOlr9D/oCpMP0uAlk4rPKyyfK2eU6NEJ/aPMkKwtNSAgZhKdcdr35jlLFcCmLJ4XyR7mxiInPSml\n\tg2qbY/Gfo8OG/hR1JJP/0eYuer+DpaT+lf+a3eIuLdHcHbjhiwJDqjD1u5EIWQ8CR0As8klsews\n\tlsxc2BWdk1zWCG/Fif9ZiMTxtQCr4tEHGbwXsI/u+fLxEwtS9aeekTTe+fkZ5v0bBqNkJay1pvj\n\tJDNHpmw2z54/9Pxd5F8ElH4LWqDAh/kAYW1v27AGnnd83bb9b5Cst/1zbcPmwGzfjwR70HOS6sT\n\t8t5VeVsdkD6HiwxhFMe5sbkBYJLnuidEBtCjgBn95hF3m/M5F+f2t9eE/fJjfw7usyym1mItOfH\n\tek1uSS1WJBCECT0S6yIp+ZfY7mHSHfWyti0J60cgXVlmCPdC1WBxAUwGrxeEQsGdxD7o+GdtJ0d\n\ttmt1EijDeFcQKuCxauuYerDKZhFlILogBXwYOMK1395j6/fh9RkEg9wY6PNH6WuMcDXvQ7PcJ0F\n\tpJ0k4uJ8ujaRRm1lQ7Yb01hpuyGm6rHSBRgKJvAksrLmfQ0yXzi5IwliLfZTh3NePTbx0lDZOeQ\n\tntXzngzcS/0xEmSg4SW3Y+jnkKZkCQKJDYj8SmQSeD2b840qn8t++nPuqy4MsbIMQz09bKV06rB\n\tzDs/c+F7csbI4Og==","X-Developer-Key":"i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"EGL is not thread-safe and in fact associates invisible handles with the\nthreadid of the calling context.\n\nAs a result we need to make Deabyer::configure() and Debayer::process() in SoftISP execute on\nthe same thread.\n\nWhen we call Debayer::configure() in the egl class this will setup and egl context\nfor us which is associated with the calling thread context. Hence when\nDebayer::process(); runs it must run in the same thread as\nDebayer::configure() or the hidden Gegl context handles will not point\nto the same place.\n\nMove start thread into configure() as a first step towards this.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/software_isp.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 28e2a360e7e6d5071e7b97c2bffc60478d245a60..7bee8f0681dd5cedcd81950ed49f611b514e763d 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -159,8 +159,6 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\t\t\t metadataReady.emit(frame, metadata);\n \t\t\t\t });\n \tipa_->setSensorControls.connect(this, &SoftwareIsp::setSensorCtrls);\n-\n-\tdebayer_->moveToThread(&ispWorkerThread_);\n }\n \n SoftwareIsp::~SoftwareIsp()\n@@ -262,6 +260,9 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n+\tdebayer_->moveToThread(&ispWorkerThread_);\n+\tispWorkerThread_.start();\n+\n \treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n }\n \n@@ -343,7 +344,6 @@ int SoftwareIsp::start()\n \tif (ret)\n \t\treturn ret;\n \n-\tispWorkerThread_.start();\n \treturn 0;\n }\n \n","prefixes":["v2","12/37"]}