{"id":24193,"url":"https://patchwork.libcamera.org/api/patches/24193/?format=json","web_url":"https://patchwork.libcamera.org/patch/24193/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-10-96f4576c814e@linaro.org>","date":"2025-08-24T00:48:22","name":"[v2,10/37] libcamera: software_isp: Move DMA Sync code to Debayer base class","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3087afce55889349598627daa37109e2c5eeb6a9","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24193/mbox/","series":[{"id":5400,"url":"https://patchwork.libcamera.org/api/series/5400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5400","date":"2025-08-24T00:48:12","name":"Add GLES 2.0 GPUISP to libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/5400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24193/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24193/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEFBCC32BB\n\tfor ;\n\tSun, 24 Aug 2025 00:48:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6383B692F7;\n\tSun, 24 Aug 2025 02:48:59 +0200 (CEST)","from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36EDB692E2\n\tfor ;\n\tSun, 24 Aug 2025 02:48:46 +0200 (CEST)","by mail-wr1-x431.google.com with SMTP id\n\tffacd0b85a97d-3c6ae25978bso1067835f8f.0\n\tfor ;\n\tSat, 23 Aug 2025 17:48:46 -0700 (PDT)","from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"rtzYDCwb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996526; x=1756601326;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=ljHxrgf3vZvddQcR/4+c7ZdyCTTapW6dccH8trXoUgo=;\n\tb=rtzYDCwbAmp/QxYJSzKmAZjUfjkkJnAC8iyvEtHQT6VUqiQKQzQhE9UASKCsgObBbr\n\tV7966q64Nup7VY9QfSIBi9PBOmYUPu4N/vvEwsx+4guOqmXxBYhQaS/o9YkdYytStCtX\n\tDJSIJi9AXTWAcE1PtCVI1/987tthW09IM+0XYqtqwx9c+EKtBASj7YhC/9wY1+e6r7lE\n\tckplbHLDEscXxT/XtzUWHKadqcE/P9SGHieX79VW2zEdzwQcGUCFJN+6bZ32jZONCGmc\n\thTy7j4CIik5P9h5NCdHplisaoDze5GUl5OO6KtA830r9REXqcaQenWcGj8EG1MoWaTk+\n\tqcHA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996526; x=1756601326;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=ljHxrgf3vZvddQcR/4+c7ZdyCTTapW6dccH8trXoUgo=;\n\tb=GouO7DSedz8D8iUN4lOJMODZEh3o2vOpegYgoi3H4ZZ0UkSRm1oOZFib/LVfJ6ElWE\n\tQ0AKbvo2miI8Q50dljAhcee+VJ3v3DyRs0nwXdRmjsxW28Hqz+/nSJfurMAVyISBoBAY\n\tz2OyLA2cQem4Ieykx5l0E7n9wnK8ipxoyaEly7u5OyMtWmZkKQv1cELbPXP+aewParYb\n\tqKJfGSsi5JkOhPnT93w16mpUw3RLTO2obv0sNK7JU/ISGS/VWBXcdRgnrXP3ScD56UQP\n\tepgZ6mhXR8PaseTVCE7KdYN6wWICGTytd6/1E1z5M1NoQXfvvpiX5H55ttmQ8VXDgouv\n\tir4Q==","X-Gm-Message-State":"AOJu0YzCARA+Bc+ib+wUv+6SxyXZkauzTraon5vMDwsYqpum47QJQj1Z\n\tfwnDdVa8Y2smo0S1AzNCBkCw7joEQzaV5+EpH8d98oV0kZliRhx1bQK9yHcxk9FE7oVvGfG6jto\n\tS/sgMgVI=","X-Gm-Gg":"ASbGncuQxXWfmM1q4F/BCmy0kkJ4B8W4gNmRo5iGr4kWyVRqPj3DeQ5cgU6LEN1zA6o\n\tv4qya/HY8a3IF1Ut6ReNMop4aeTSu4cCz8nhnsdpUbQ++QIzb6SHfyKKdSCTtaReCXfXCnNbqND\n\tLu2u9I5U1cyQaNulUMDtIlShzmlt/87jaNa24lNZWJtjS4luU7gnmfPUjzWxfcMMNJa2vQYaLUD\n\t7DfYgJTl32fxcLwgqA2DQPSX4IWrTM6ECwfY034Ey2K6LJ2yXDYewHyZDQlmGwRZlx1o8qFYDkO\n\tpUYkKSBHUHnpBluB6mkJSMBOZPAGpMkLq/ZuHAU5YMJVEQtt+rkMZ7+Ew949ghn66yO4LfwxcO6\n\tL38GQjYoqeI7COLBM/AA3utBecPZR2Y2+i8S+I5SZ/k1rD/s+9ziiB5qONK9Qj8KKe6XF+M4t6P\n\t+li43aG4+AidtEFWVXnHNu","X-Google-Smtp-Source":"AGHT+IHiwnoFbPKEtdZGCt1uh+N1+bkxc1Ggnw5aDqBq0a7xCPAhiyRKaI1PKa2WNUO2Sn3FehphWQ==","X-Received":"by 2002:a05:6000:2f81:b0:3c3:7cba:6d18 with SMTP id\n\tffacd0b85a97d-3c5dd6bbcffmr4802218f8f.55.1755996525612; \n\tSat, 23 Aug 2025 17:48:45 -0700 (PDT)","From":"Bryan O'Donoghue ","Date":"Sun, 24 Aug 2025 01:48:22 +0100","Subject":"[PATCH v2 10/37] libcamera: software_isp: Move DMA Sync code to\n\tDebayer base class","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-10-96f4576c814e@linaro.org>","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3124;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=rTghYOVfOgNztjAsM9CLcURyL9hv4snptnXuCiaB0w4=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFeX1fb9ALVtB1N0+AmBzwxeX8HY+16k21N7\n\tyscyrcrjcWJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphXgAKCRAicTuzoY3I\n\tOqTgD/4k84tx6SeH5JbiA+OJaY0kFn4zX9bzoYrqUGwdvc67+kd0Veic/wX2oVjH79OtLc6yllr\n\tLJ8LHWbNnax7e0mqgHd34W+xSX3zPF/CIvrfaRck6Xu3WPw9NamjSYbne7P+GHkdgknvxVmhMnY\n\t+CjzUh5auaNqZlXjPxJtII46l2bmCXBZ91HiaMu+N+QDUZYI2Ai7W+8xCX0SdGOwDbVeMP4wyDK\n\tYotpZpH2SfEeq6cu/elNKDzGrrfnzu+Km/AdoK3KTmIpRXRe38vAHyhhB+xkQ7ZPykSONTIZMX+\n\tVKE4LCJ36A8XaSMO2BYWar3BVEmr87/RV4jG6P6noQJ1nlzBpKmOHw7hJbJW8umTJd5GOOA82Oz\n\tYPnEt8muHR3VRkZtNPNrMc8Y5jMeIgISqbkTEnh2Cq1Q9Oxg7ryK6KUtmTD+cjfijT5QmiXlqzk\n\tuBTn1VIV68jILATH415IsIDnFrgUDgWvTnqoPipepWDTdJ8RZ3rHbVumU89pSK20Ko9qBdZMB4U\n\tFd3BJhGmiMjjfzOFmWet3Z7iK9lrBMHeTTcBO2tO8SqWIaA0iTvo15SNlolR7xSEDYQJHIz+sMQ\n\tY4A+QwiquSOaWfBETV+mvZfkTDaA8N9y5cVnUy3i0GWiEpTG2JajiMgH7jITciqv91iBDvThJ2C\n\tjGI0vLocL+TJEqA==","X-Developer-Key":"i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We can reuse the DMA Sync code in the GPUISP. Move the code we need to\nthe base class.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer.cpp | 13 +++++++++++++\n src/libcamera/software_isp/debayer.h | 2 ++\n src/libcamera/software_isp/debayer_cpu.cpp | 6 +-----\n 3 files changed, 16 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex fc2438c0d0161a36da2769d95836f282836b143d..75e4bffab0f082bdf6e5bdf3030b9f49d4877524 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -214,4 +214,17 @@ void Debayer::setParams(DebayerParams ¶ms)\n \tgammaLut_ = params.gammaLut;\n }\n \n+/**\n+ * \\fn void Debayer::dmaSyncBegin(DebayerParams ¶ms)\n+ * \\brief Common CPU/GPU Dma Sync Buffer begin\n+ */\n+void Debayer::dmaSyncBegin(std::vector &dmaSyncers, FrameBuffer *input, FrameBuffer *output)\n+{\n+\tfor (const FrameBuffer::Plane &plane : input->planes())\n+\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Read);\n+\n+\tfor (const FrameBuffer::Plane &plane : output->planes())\n+\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+}\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex 5f692bcbdeec1447c596ebbdc984585948a34880..0af66b556bbf8993a66042a3a76cd50582209bce 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -20,6 +20,7 @@\n #include \n #include \n \n+#include \"libcamera/internal/dma_buf_allocator.h\"\n #include \"libcamera/internal/software_isp/benchmark.h\"\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n \n@@ -85,6 +86,7 @@ private:\n \n protected:\n \tvoid setParams(DebayerParams ¶ms);\n+\tvoid dmaSyncBegin(std::vector &dmaSyncers, FrameBuffer *input, FrameBuffer *output);\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 6ed17e9fc144bc7c3472d999b1e9c23236020963..9fce2a143ac9585eadcea41744d680bc9589c507 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -22,7 +22,6 @@\n #include \n \n #include \"libcamera/internal/bayer_format.h\"\n-#include \"libcamera/internal/dma_buf_allocator.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/mapped_framebuffer.h\"\n \n@@ -740,11 +739,8 @@ void DebayerCpu::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \tbench_.startFrame();\n \n \tstd::vector dmaSyncers;\n-\tfor (const FrameBuffer::Plane &plane : input->planes())\n-\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Read);\n \n-\tfor (const FrameBuffer::Plane &plane : output->planes())\n-\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+\tdmaSyncBegin(dmaSyncers, input, output);\n \n \tsetParams(params);\n \n","prefixes":["v2","10/37"]}