{"id":24192,"url":"https://patchwork.libcamera.org/api/patches/24192/?format=json","web_url":"https://patchwork.libcamera.org/patch/24192/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-9-96f4576c814e@linaro.org>","date":"2025-08-24T00:48:21","name":"[v2,09/37] libcamera: software_isp: Move param select code to Debayer base class","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5c86a0f719ecc9ddd3bf345138568e668d75648b","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24192/mbox/","series":[{"id":5400,"url":"https://patchwork.libcamera.org/api/series/5400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5400","date":"2025-08-24T00:48:12","name":"Add GLES 2.0 GPUISP to libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/5400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24192/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24192/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EDB8BEFBE\n\tfor ;\n\tSun, 24 Aug 2025 00:48:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 03918692E7;\n\tSun, 24 Aug 2025 02:48:56 +0200 (CEST)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A655E692F7\n\tfor ;\n\tSun, 24 Aug 2025 02:48:44 +0200 (CEST)","by mail-wr1-x435.google.com with SMTP id\n\tffacd0b85a97d-3c51f015a1cso1518124f8f.1\n\tfor ;\n\tSat, 23 Aug 2025 17:48:44 -0700 (PDT)","from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:43 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"mIdSf5PY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996524; x=1756601324;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=YCvAN3AkHvBrZEDLQ+W3FSbEc9RScQY0mqKdSYiufr4=;\n\tb=mIdSf5PYlLLLU6JRwRZBi/CuHBa3Sj9kF2ufCyS1VnJs6MhFOPeoQJdqmThoTjz4XV\n\t00O8NptO/JPKH79jU9qRZ0YxZeFhyJNSP+UvzvElrwijRy7ktIfsXrlsbJcvGRKNoTk4\n\tsOtO/5tLvJfAAqzF4v70WIU0FS2PBo0KlWnIu/gDpgUawvoJ32W2FK1Oam+LY4sW9ByR\n\tgqMruVN3yLZUR/MGw5Jqx+nj+33NcUQtezcc2r1bptjsQIgcfAy2mJX8usuWA6BkHPX9\n\tpiWdpKK72PT6zjrmxLD7Uqxra3WYyaqrGT/E9OgCvk5Sv08b48JzaM1qXX7aDZasj7By\n\tImzQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996524; x=1756601324;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=YCvAN3AkHvBrZEDLQ+W3FSbEc9RScQY0mqKdSYiufr4=;\n\tb=FwFJK3ucGoCPBM2kPaVemuviYkPnYuh0gLRlqdccX4J1u32xYD+7LVC+dkrU943b7m\n\tF+f8RlsimiKWcPeA+raTC/TWBUGww7g/Zzg0Af3IMPTs61WCRdMrxTtGyOcTu+RafEI/\n\tKA5aQk7r/iezCyN0Kf1g4E/0EZqaDvhydd/7gtqMndSBBMWCj7muwE08src+PyMSFXQN\n\tigRQRx9BoEZOKjPzrGq0j/JpdBnGU3wxLfsl80C1pjsD5e6H1cWMiQ2ePxEz/elX8xCM\n\tGJOitCE1B1g3ajuRKLV03qA6yzdRB5900fBCDzDLLR1aQ6Ws5OTvFXz449fN9dOr8M+U\n\t9Fxg==","X-Gm-Message-State":"AOJu0YxHqUhrAe9G7asw1ke2CwmYy1xlQSBYsbDfKVsnLJxl2DRhxv8C\n\t975CIcTzT4etmfzZ8DDLVpOhjtGTH4srTshM2cRqOYurAP6MCYhHZ8M9SBUGaRBNn4eqrdq71oa\n\tXA3hTIe4=","X-Gm-Gg":"ASbGnctJVGsDIAxeJ8KOj6PYesYDaNnHJkY8CfhCb9LQ8oKVqcNTG0/xQGKbeVFRBzP\n\tp74TVLfAMEDM8izvEHso1rpHzLSq4qC/zc7BAmXs7MW6GhTCs/ymfsN7ROl5LNqBA79t/+geGvP\n\tSe+3kJlr4lUZHzVocBt4RovcWKvKzJ/TVsERcdM8FjV9BLBa5PSg5XP85cJOzWvMKCca75k3pfk\n\tabyT7qSMmC6muU/1gmIpT3k9IWC920ZvzEWgIe8WIUr7E5pYuhB4+KLs6a7W0ygBMXekEqkyPD8\n\tebInGTDNGiIY496lqAgxxx4xb42vLykQMllZkZXKecNih1968kiTbYdJJ+0LNnDUYtvMqXu3Pyr\n\tah9gQPmyoKiZFlKXjjpcwJ/R5bo42LDIbI4rmSRnTBw1hZmvq2fiJG0RitMLPgMEIWk01NCPeeM\n\t43nYjSoCZxim1C0ZiXm0Ph","X-Google-Smtp-Source":"AGHT+IESa23UAxq9VCu+jvTGqSlESjTR7NMbN0WDJEfInZOuXDm31O4UG7BSWG9OP9aECnh3UXMPYg==","X-Received":"by 2002:a05:6000:1788:b0:3c3:5406:12ad with SMTP id\n\tffacd0b85a97d-3c5dcff73c7mr5206682f8f.61.1755996524146; \n\tSat, 23 Aug 2025 17:48:44 -0700 (PDT)","From":"Bryan O'Donoghue ","Date":"Sun, 24 Aug 2025 01:48:21 +0100","Subject":"[PATCH v2 09/37] libcamera: software_isp: Move param select code\n\tto Debayer base class","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-9-96f4576c814e@linaro.org>","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3263;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=4PFBU4wyuVCiot0OIoWB+yVFv1FF9Up5n3zwiCDX61s=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFdqFqkgWXzExU1MZG2X5WcIPy/YsIohsoEQ\n\tl0oHi/frKiJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphXQAKCRAicTuzoY3I\n\tOnloD/9kj1Cl+/4xDAEWoyWz65qgDHDdxhdFIs2ZjzwaHcTAI02Ts4qWFXUZkdJzyzAlrSHM6X5\n\t1TLPEyVnz5hfJpnmd2fjPzXoiN/7qLnPg6PpvsXAy25NZLQdxieXhNrDuPLHkKI4m2U7wC0s7YH\n\t659xAzPSmvILmA05sEmNv0qInm3fH33xbH8jiXTWB9F0iIc+RSOb1h0+0R8n9UvhZgTJnIEpYsn\n\tNTFFgnTugEs41vpWfolw7hpjAM1aJnKNFziV12p1R8B78xc2INgtpc43dx4TtrjHWD2Hiifqfw/\n\t50VxYzM1m0Ji0QgdaqBisCFzLsPSG0hquKwD77Rli8EBK0861Lk1C8Z3YDFUaa2TNVetgiJeuiU\n\thXiGsdznHoZDCRsbLKVbRImHOJpQcpassuzsc5FXrmcBjIdaCCu0+5W3bh4J9UHLXIglZ2nTW+8\n\tmUhFstZbLd04oIfGrYUjoc/KUiHqD9rBAIAHaxxD+qySOcmgfmvUZE5S3SY/rZz7INDvINQOZ1k\n\teqSgV3DvpdD+/sN7sWuwIop2By7VtCkrYhhKUpELyRd1ejnqzVjfV0qhcul/whZoxhxP4dr30V5\n\t4ZAkmby04dcU5jhO1tlEY7tNX217xhduf2Li6F4PpYmQEmsFTIZEj/J4oWseYyHs6wjEs9Oi3I/\n\tbgKiNofFg3RaNmQ==","X-Developer-Key":"i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Move the parameter selection code into the Debayer base class in-order to\nfacilitate reuse of the lookup tables in the eGL shaders.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer.cpp | 27 +++++++++++++++++++++++++++\n src/libcamera/software_isp/debayer.h | 3 +++\n src/libcamera/software_isp/debayer_cpu.cpp | 19 +------------------\n 3 files changed, 31 insertions(+), 18 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 29fdcbbfd4eba4a23c520b22784bf003f22a93f4..fc2438c0d0161a36da2769d95836f282836b143d 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -187,4 +187,31 @@ Debayer::~Debayer()\n * \\brief Signals when the output buffer is ready\n */\n \n+/**\n+ * \\fn void Debayer::setParams(DebayerParams ¶ms)\n+ * \\brief Select the bayer params to use for the next frame debayer\n+ * \\param[in] params The parameters to be used in debayering\n+ */\n+void Debayer::setParams(DebayerParams ¶ms)\n+{\n+\tgreen_ = params.green;\n+\tgreenCcm_ = params.greenCcm;\n+\tif (swapRedBlueGains_) {\n+\t\tred_ = params.blue;\n+\t\tblue_ = params.red;\n+\t\tredCcm_ = params.blueCcm;\n+\t\tblueCcm_ = params.redCcm;\n+\t\tfor (unsigned int i = 0; i < 256; i++) {\n+\t\t\tstd::swap(redCcm_[i].r, redCcm_[i].b);\n+\t\t\tstd::swap(blueCcm_[i].r, blueCcm_[i].b);\n+\t\t}\n+\t} else {\n+\t\tred_ = params.red;\n+\t\tblue_ = params.blue;\n+\t\tredCcm_ = params.redCcm;\n+\t\tblueCcm_ = params.blueCcm;\n+\t}\n+\tgammaLut_ = params.gammaLut;\n+}\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex 01b6e916f2a7199c592abd8a57ef549eaf388a8b..5f692bcbdeec1447c596ebbdc984585948a34880 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -82,6 +82,9 @@ public:\n \n private:\n \tvirtual Size patternSize(PixelFormat inputFormat) = 0;\n+\n+protected:\n+\tvoid setParams(DebayerParams ¶ms);\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 408ce2baa5e8a23902cbf0ca2b9ea87e73b4e882..6ed17e9fc144bc7c3472d999b1e9c23236020963 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -746,24 +746,7 @@ void DebayerCpu::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \tfor (const FrameBuffer::Plane &plane : output->planes())\n \t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n \n-\tgreen_ = params.green;\n-\tgreenCcm_ = params.greenCcm;\n-\tif (swapRedBlueGains_) {\n-\t\tred_ = params.blue;\n-\t\tblue_ = params.red;\n-\t\tredCcm_ = params.blueCcm;\n-\t\tblueCcm_ = params.redCcm;\n-\t\tfor (unsigned int i = 0; i < 256; i++) {\n-\t\t\tstd::swap(redCcm_[i].r, redCcm_[i].b);\n-\t\t\tstd::swap(blueCcm_[i].r, blueCcm_[i].b);\n-\t\t}\n-\t} else {\n-\t\tred_ = params.red;\n-\t\tblue_ = params.blue;\n-\t\tredCcm_ = params.redCcm;\n-\t\tblueCcm_ = params.blueCcm;\n-\t}\n-\tgammaLut_ = params.gammaLut;\n+\tsetParams(params);\n \n \t/* Copy metadata from the input buffer */\n \tFrameMetadata &metadata = output->_d()->metadata();\n","prefixes":["v2","09/37"]}