{"id":2419,"url":"https://patchwork.libcamera.org/api/patches/2419/?format=json","web_url":"https://patchwork.libcamera.org/patch/2419/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191209163446.32381-9-jacopo@jmondi.org>","date":"2019-12-09T16:34:44","name":"[libcamera-devel,v3,08/10] libcamera: camera: Add Camera properties","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d42e42b88bcd970ed7d15984727774c91356bfe8","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2419/mbox/","series":[{"id":586,"url":"https://patchwork.libcamera.org/api/series/586/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=586","date":"2019-12-09T16:34:36","name":"Introduce libcamera properties","version":3,"mbox":"https://patchwork.libcamera.org/series/586/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2419/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2419/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14E9E60BFE\n\tfor ;\n\tMon, 9 Dec 2019 17:32:47 +0100 (CET)","from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 32EFA1C000C;\n\tMon, 9 Dec 2019 16:32:46 +0000 (UTC)"],"X-Originating-IP":"93.34.114.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 9 Dec 2019 17:34:44 +0100","Message-Id":"<20191209163446.32381-9-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.24.0","In-Reply-To":"<20191209163446.32381-1-jacopo@jmondi.org>","References":"<20191209163446.32381-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 08/10] libcamera: camera: Add Camera\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 09 Dec 2019 16:32:47 -0000"},"content":"Add a method to the Camera class to retrieve the Camera properties\nregistered by the pipeline handler.\n\nWhile at it, reword the Camera::controls() operation documentation to\nspecify that the camera control information are constant during the\ncamera lifetime not their value, while the camera properties value are\nthe actually static information.\n\nReviewed-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/camera.h | 1 +\n src/libcamera/camera.cpp | 16 +++++++++++++++-\n 2 files changed, 16 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex ef6a37bb142c..72d5d62cc902 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -85,6 +85,7 @@ public:\n \tint release();\n \n \tconst ControlInfoMap &controls();\n+\tconst ControlList &properties();\n \n \tconst std::set &streams() const;\n \tstd::unique_ptr generateConfiguration(const StreamRoles &roles);\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex e810fb725d81..afc401c65fec 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -551,7 +551,8 @@ int Camera::release()\n /**\n * \\brief Retrieve the list of controls supported by the camera\n *\n- * Camera controls remain constant through the lifetime of the camera.\n+ * The list of controls supported by the camera and their associated\n+ * constraints remain constant through the lifetime of the Camera object.\n *\n * \\return A ControlInfoMap listing the controls supported by the camera\n */\n@@ -560,6 +561,19 @@ const ControlInfoMap &Camera::controls()\n \treturn pipe_->controls(this);\n }\n \n+/**\n+ * \\brief Retrieve the list of properties of the camera\n+ *\n+ * Camera properties are static information that describe the capabilities of\n+ * the camera. They remain constant through the lifetime of the Camera object.\n+ *\n+ * \\return A ControlList of properties supported by the camera\n+ */\n+const ControlList &Camera::properties()\n+{\n+\treturn pipe_->properties(this);\n+}\n+\n /**\n * \\brief Retrieve all the camera's stream information\n *\n","prefixes":["libcamera-devel","v3","08/10"]}