{"id":24185,"url":"https://patchwork.libcamera.org/api/patches/24185/?format=json","web_url":"https://patchwork.libcamera.org/patch/24185/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-2-96f4576c814e@linaro.org>","date":"2025-08-24T00:48:14","name":"[v2,02/37] libcamera: swstats_cpu: Drop patternSize_ documentation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"59741e75c523b0031de9169f512623c1b3987ba1","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24185/mbox/","series":[{"id":5400,"url":"https://patchwork.libcamera.org/api/series/5400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5400","date":"2025-08-24T00:48:12","name":"Add GLES 2.0 GPUISP to libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/5400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24185/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24185/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14627BEFBE\n\tfor ;\n\tSun, 24 Aug 2025 00:48:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA075692F1;\n\tSun, 24 Aug 2025 02:48:42 +0200 (CEST)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E984613BE\n\tfor ;\n\tSun, 24 Aug 2025 02:48:38 +0200 (CEST)","by mail-wr1-x436.google.com with SMTP id\n\tffacd0b85a97d-3c607029266so1163906f8f.3\n\tfor ;\n\tSat, 23 Aug 2025 17:48:38 -0700 (PDT)","from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:37 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"fxbN69N0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996518; x=1756601318;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=UIYO3EkjhnRwMnWRgND5s05n9C0e5DjPX83wUdOOlmw=;\n\tb=fxbN69N0gzN/UAuN1AJQskcNMZsBWP6tkXmoAcpFzZA2kcL8PGVhyq6VJC9U5OK/eQ\n\tppnRqKfGxAGCmd3uwvi+81i5CLKzRL4JflZCD/PUWTOqC8uWnp/CuVRmq6lXxXH9ZP5O\n\tbaMF5lRcXSlvZyntJ3pHugUayXwQhxZCRtaOB3Yz3XLDixNCvcE30LWO2S3f1c8Qlc0Z\n\tFPKy4lbKngIcFs89P5T3h/VGmKB6GCnJRma1qO/ioO+RdrRlLMLDgJGNMp0jRyfQnyXz\n\tWUggKhHCut0FlisL468GbnDbYj6hvZLj4lNYpnaDvVpJE53sQluK6RqI2Ds2HPVl76iH\n\tL+Gw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996518; x=1756601318;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=UIYO3EkjhnRwMnWRgND5s05n9C0e5DjPX83wUdOOlmw=;\n\tb=lz0IVEvcwzWH8rOHeNmsuI4SilI+3lK/6XBQxb74hoMw3fRfUVvAx4e6wwCsbnhHI7\n\tp5zAUn63kj4QW153GbXa6mvmStppw1yLdj0TVDtJGnjeLhGq4v/9cvU0tjXpaM6wANYl\n\tkNL3+cQ9JYWV922BBgnxZG5MF30lVpMsk6UOvPhDPZbn5WIbPCKANinEp1064n+YADAl\n\tejVO8YphLuIoJ8nhsSFRuG/N8Rp5DzKotlC+l+CLl54TTj18vbdcdirEd+KwQeW+5ISZ\n\trg2xvtBeYi4vjzWLZ5veFCJo73euSI8+RCFFafcE3b1Wna4+drKrwQAfPWGi4tRVkF+J\n\tvKEQ==","X-Gm-Message-State":"AOJu0Yw4cK+bejN40jiwS6LqsM9hj/RSjHndVxoG4Bznv1QvAVAUy/sL\n\tJfNTZtSJmLBixnvd2ae681YS1B6GYDSlze+zbbF4wZqOMPFRXGgV8D581iLiVrAqkbI=","X-Gm-Gg":"ASbGncuWD5rLKwMzniD7XHcFhVHUb66oCi21VPFP3cZPNRH51Fq6Wyhqh/J26Tqs1wl\n\tI256rYbmRpkXYyvZulzVBkLLP06O/swbEVwiKVuJrEu8STqXIOdfIvSKfJsu6nmo4bqmzfvCXRT\n\tPK38xuIRYHkLMLyjUlZD2wfOKLtan5IxGCy9gH1AuwX7h6+gMYBsaFq4cwgO3QPe9hZaWborjpX\n\tZJh438ZARTjOFHh8EfjGFHSc9YFI/uaNIf/mAmC8SThQeZCY568/7H5KgzEv3dRfrYwok7pWQOi\n\t+rnm3/ylMAmL4GWkRoZBx/KZueIzrxTA3IeViWCfZm5DIxDV0q00tNSK3r2ujqDgZiN6vptECle\n\ttw/GIUXWq/EItY1cHcM5ESsdjFWRZ0s+gNf22XFGFDC1+trIgeJfojDKUCfT0WiOZraLik6uSiO\n\tDqcdYJQ25h+l/VgRnq7LbL","X-Google-Smtp-Source":"AGHT+IFyH6/ACHzITJmeU3+cfUPSt5xWwgI6+oM38eA/CLNZr+RuxEJI7PDZTxjIId2EmXOLIe8FHA==","X-Received":"by 2002:a05:600c:1f1a:b0:459:dde3:1a3d with SMTP id\n\t5b1f17b1804b1-45b517cc0e3mr56337735e9.26.1755996517958; \n\tSat, 23 Aug 2025 17:48:37 -0700 (PDT)","From":"Bryan O'Donoghue ","Date":"Sun, 24 Aug 2025 01:48:14 +0100","Subject":"[PATCH v2 02/37] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-2-96f4576c814e@linaro.org>","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue , \n\tHans de Goede , \n\tKieran Bingham , \n\tMilan Zamazal ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1644;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=AUh7v0KwOEfEEf8ZmV0YJu3Q4see9tGXXz688gMGyT4=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFcQyG95YbDig9N3x6S4Tf9y5UX1ZWRRkehw\n\tfsHvc20SDSJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphXAAKCRAicTuzoY3I\n\tOsGHD/9AcAnRlWsmrCx2r/9WQp42mP1Z25eBZBB47ZufmvYvSTmgz12BDmnYIUhDWqVm+RunDzr\n\thqD8o2lBj5y+hUF9k6osN8E+IjpSvSZoH75ZwggGPHzW2UseWuEjWLkzDZdigcpH1+w+5KgwAOE\n\tdC29ytZbLMr00rTibZQ9gRufwagixrdx7pZtBbp0skhIgmF1D8O4MdKVwq+kM51Uwf4BWsp2j6D\n\t0wTjlnhbxOOnJwCb81NuRVL+NUMG9ZBhg2b8Dg4quMoWE+MgvF7miWHQi2hUvTeKzp9rgU9HGR2\n\tq2d+5XDAFf1dY7EQ6xeBCsAaSjIkvBMTAP7+mQLlmq4l8oEPKX51rBZAecXs/+thrFCkG7IAVm+\n\tfXqbfLR5NU68Q6lp4Svd3Cxn7WNrTQYU8D1ugC84KfqHl6T+1xnpvBVEdIXC4Bj6aMudVMzeiej\n\tJ09aZVepBn44jhfGmy48vDvC51JcGkRpO7BU5QXGEeDTgBF6bdLJ9eYfOZ/RP72sgdadw0y94zi\n\tkoMNtvTpy+FHn1bATVU7Yz2n3z7G0zNdO+ti4efEKVFk4BvmBhL9Is05yvixpbnvUalZsnxAuHi\n\tMnzC559hDNDO5lDAsEbyVgZsMmODwjn1PT3xWWKhxOYPGm62xxaewXP8W6bKUSkyrLikiPsY6tn\n\taHUjeHgti/WjV9g==","X-Developer-Key":"i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Hans de Goede \n\npatternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Hans de Goede \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 4c078cc26d9d23daab5358a920a473cd09f123b3..98c23389d7ebf08ba492e610e5775e500420fde6 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -112,13 +114,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n","prefixes":["v2","02/37"]}