[{"id":35566,"web_url":"https://patchwork.libcamera.org/comment/35566/","msgid":"","date":"2025-08-26T07:14:17","subject":"Re: [PATCH 6/6] ipa: rpi: sdn: Remove legacy denoise warning","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nOn Fri, 22 Aug 2025 at 13:37, David Plowman\n wrote:\n>\n> We use the legacy format for the VC4 platform, and are not planning to\n> change this. So remove the warning.\n>\n> Signed-off-by: David Plowman \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/ipa/rpi/controller/rpi/sdn.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/src/ipa/rpi/controller/rpi/sdn.cpp b/src/ipa/rpi/controller/rpi/sdn.cpp\n> index 619178a8..594ea701 100644\n> --- a/src/ipa/rpi/controller/rpi/sdn.cpp\n> +++ b/src/ipa/rpi/controller/rpi/sdn.cpp\n> @@ -37,8 +37,6 @@ char const *Sdn::name() const\n>\n> int Sdn::read(const libcamera::YamlObject ¶ms)\n> {\n> - LOG(RPiSdn, Warning)\n> - << \"Using legacy SDN tuning - please consider moving SDN inside rpi.denoise\";\n> deviation_ = params[\"deviation\"].get(3.2);\n> strength_ = params[\"strength\"].get(0.75);\n> return 0;\n> --\n> 2.39.5\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65F35BEFBE\n\tfor ;\n\tTue, 26 Aug 2025 07:14:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BF3E692EB;\n\tTue, 26 Aug 2025 09:14:55 +0200 (CEST)","from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com\n\t[IPv6:2607:f8b0:4864:20::e2e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96462692E1\n\tfor ;\n\tTue, 26 Aug 2025 09:14:53 +0200 (CEST)","by mail-vs1-xe2e.google.com with SMTP id\n\tada2fe7eead31-52175ed7b08so101841137.2\n\tfor ;\n\tTue, 26 Aug 2025 00:14:53 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cB8pWS45\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1756192492; x=1756797292;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=cCLyJ3xUIZkCL+CNFu9yYwSz3TKS513KWMukwuFpE88=;\n\tb=cB8pWS4542WuIHL5QTJi9Q1OiF3zVaN45yJ1784RtD+DEvrw16f7fr/0kka4Xto3aV\n\tKf/RAUSl9JaVFJGK5fFBDDKeJE4qpDV3RC3lNnMUqdC90Lh31q9kcit1m+2CpU/fhq1X\n\txApgu+fFDS/dEpgC8GhD9vsWoCxqvEwGGPgr6NGyNL3lhEOTF13fl2kT6Di3twWG5yjE\n\tBpw29tC8L7s7WfCPheREh6iAszjYlpB5mu4atLofkEFb1CXocoTQ6AeSJx52LSjxzzMl\n\tqozZumM6v5avOqaG4rCORz+m9iLUbjL0H/Zm2rfrIR5pDD6VD/cQ2VXpHwDslHXnIlfL\n\tTqkA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756192492; x=1756797292;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=cCLyJ3xUIZkCL+CNFu9yYwSz3TKS513KWMukwuFpE88=;\n\tb=S+2joX65m9FEl+mIiwkAIfPxh3Mf5LvZmd++mCwLBKazcO3WuRyle+kTMKjxLLDxte\n\t+ASDsO+PbC5ujLRpaDPtKz5HmoTPeF1gL3LXQP35/jf7TWfyOeOr9tL6V6ZfN2KWJU24\n\t6KbQIaxTwT8mjPPd+42+uevLoG1bmQNVMUuZCa+AM1CJu/AtMmjch+pEC4MnwuHHiBYh\n\tt5rFs8WFbT5UgGBEUktJ+V4t+9X0c4bAtab6MfLjKGU++Z3QpdxrtxKCI7bQeTotCV1j\n\tX7l3Xjv8yLBiQGleZDqh6w+FgpiLONEF9MjjrNMRIO3SBzS+NitYFn+n7CFfd7ZNYrKE\n\tB2pQ==","X-Gm-Message-State":"AOJu0Yx+8N0SBPLq/yBNP+eF5sSkUsamloG6rEowYecPGMCTbUeGfdmh\n\tSvYbtF05nITrDMqkW93SefPLYSNl3IXRCjw4xx2Z+yA8xZBjAAycAcMMVIKzO8VaLjINlp8pcIj\n\tgEv6KUD5np6D+w/FzsjoO6GHr/maJW2WAWnLq6iQQpw==","X-Gm-Gg":"ASbGncvKsFVw45py1HV96sk/mG/kW2MmVi44UA1zJKUc0HN39pE5JijNEDgFkdkWdqQ\n\tmAmzgidsy4RfVqiTdRlcv5S1hmBMT5XZ0eBc3M6Ah3wwiD7197eo7dmyw0gTqwrNhoMgd4Ysu3f\n\t1wmFeDrvtSkdGS5ty9cGkOKa6UiCRd7CyWMFFTgqBsll7LT1pBa+lcy7ihan6JMcP+SNkKLQoV+\n\twgjKR7N0sNT4Yo2w3SN+H1flMfDugU/sT7rHY4=","X-Google-Smtp-Source":"AGHT+IFgOxFugLQAp5MJLDz6fhjD+eneY7yeHr100bnT34+CbxXtBUx7ZbVoxwbZi4y1aGBdqaBY/9TA0NGZswIdIXM=","X-Received":"by 2002:a05:6102:6043:b0:521:f0ee:242d with SMTP id\n\tada2fe7eead31-521f0ee2ac1mr720035137.7.1756192492543; Tue, 26 Aug 2025\n\t00:14:52 -0700 (PDT)","MIME-Version":"1.0","References":"<20250822123709.16966-1-david.plowman@raspberrypi.com>\n\t<20250822123709.16966-7-david.plowman@raspberrypi.com>","In-Reply-To":"<20250822123709.16966-7-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 26 Aug 2025 08:14:17 +0100","X-Gm-Features":"Ac12FXxSFVVpqQ2q4pZOFY1dEWGs4U-EDphS4aKQA1nR8Fy__E-A6hkznATcZXc","Message-ID":"","Subject":"Re: [PATCH 6/6] ipa: rpi: sdn: Remove legacy denoise warning","To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]