[{"id":35541,"web_url":"https://patchwork.libcamera.org/comment/35541/","msgid":"<85plcobx3a.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-08-21T13:52:57","subject":"Re: [PATCH 2/5] libcamera: software_isp: Pass correct y-coordinate\n\tto stats","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Maciej,\n\nMilan Zamazal writes:\n\n> The window set by SwStatsCpu::setWindow is relative to the processed\n> image area. But debayering passes the processed line y-coordinate to\n> the stats relative to the whole image area. This can result in\n> gathering stats from a wrong image area or in not gathering stats at\n> all.\n>\n> Let's pass the correct y-coordinate to the stats processing methods.\n>\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=280\n> Co-developed-by: Maciej S. Szmigiero \n\nFeel free to attach your Signed-off-by here to get this line replaced by\nit.\n\n> Signed-off-by: Milan Zamazal \n> ---\n> src/libcamera/software_isp/debayer_cpu.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\n> index bcc847ae6..185edd814 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.cpp\n> +++ b/src/libcamera/software_isp/debayer_cpu.cpp\n> @@ -648,7 +648,7 @@ void DebayerCpu::memcpyNextLine(const uint8_t *linePointers[])\n> \n> void DebayerCpu::process2(const uint8_t *src, uint8_t *dst)\n> {\n> -\tunsigned int yEnd = window_.y + window_.height;\n> +\tunsigned int yEnd = window_.height;\n> \t/* Holds [0] previous- [1] current- [2] next-line */\n> \tconst uint8_t *linePointers[3];\n> \n> @@ -664,12 +664,12 @@ void DebayerCpu::process2(const uint8_t *src, uint8_t *dst)\n> \t\tlinePointers[1] = src + inputConfig_.stride;\n> \t\tlinePointers[2] = src;\n> \t\t/* Last 2 lines also need special handling */\n> -\t\tyEnd -= 2;\n> +\t\tyEnd = (yEnd > 2 ? yEnd - 2 : 0);\n> \t}\n> \n> \tsetupInputMemcpy(linePointers);\n> \n> -\tfor (unsigned int y = window_.y; y < yEnd; y += 2) {\n> +\tfor (unsigned int y = 0; y < yEnd; y += 2) {\n> \t\tshiftLinePointers(linePointers, src);\n> \t\tmemcpyNextLine(linePointers);\n> \t\tstats_->processLine0(y, linePointers);\n> @@ -703,7 +703,7 @@ void DebayerCpu::process2(const uint8_t *src, uint8_t *dst)\n> \n> void DebayerCpu::process4(const uint8_t *src, uint8_t *dst)\n> {\n> -\tconst unsigned int yEnd = window_.y + window_.height;\n> +\tconst unsigned int yEnd = window_.height;\n> \t/*\n> \t * This holds pointers to [0] 2-lines-up [1] 1-line-up [2] current-line\n> \t * [3] 1-line-down [4] 2-lines-down.\n> @@ -721,7 +721,7 @@ void DebayerCpu::process4(const uint8_t *src, uint8_t *dst)\n> \n> \tsetupInputMemcpy(linePointers);\n> \n> -\tfor (unsigned int y = window_.y; y < yEnd; y += 4) {\n> +\tfor (unsigned int y = 0; y < yEnd; y += 4) {\n> \t\tshiftLinePointers(linePointers, src);\n> \t\tmemcpyNextLine(linePointers);\n> \t\tstats_->processLine0(y, linePointers);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F4DABD87C\n\tfor ;\n\tThu, 21 Aug 2025 13:53:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9B70692E1;\n\tThu, 21 Aug 2025 15:53:06 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5054A69257\n\tfor ;\n\tThu, 21 Aug 2025 15:53:05 +0200 (CEST)","from mail-qt1-f198.google.com (mail-qt1-f198.google.com\n\t[209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-614-nSmK1ic8MFamiVBfUUrMQg-1; Thu, 21 Aug 2025 09:53:02 -0400","by mail-qt1-f198.google.com with SMTP id\n\td75a77b69052e-4b0fa8190d4so54415951cf.0\n\tfor ;\n\tThu, 21 Aug 2025 06:53:02 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\td75a77b69052e-4b12509cdcdsm94789071cf.27.2025.08.21.06.52.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 21 Aug 2025 06:53:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"hVUVoKgC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1755784384;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=uiyjvMKajjrT4AwRaEnm8/uSfhBBs1A2cyJDviRsdq0=;\n\tb=hVUVoKgCA4G1XvVrLpbwNOpEvzt1QeKCzsEhp3aD2V80Yn+ZTzRDW1I1n/SknluDey6LIm\n\tAU+DUCjUj+7+CTD+udYbnU5JvOQQi9UZQyj2FqpQsxp77ae42qdoVA7CZQHHqBUfjgBnGy\n\tf8J3LUZVLQy976pPRXzqQlWYQzAuy3U=","X-MC-Unique":"nSmK1ic8MFamiVBfUUrMQg-1","X-Mimecast-MFC-AGG-ID":"nSmK1ic8MFamiVBfUUrMQg_1755784382","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755784382; x=1756389182;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=uiyjvMKajjrT4AwRaEnm8/uSfhBBs1A2cyJDviRsdq0=;\n\tb=WRtkijX/RK25Op7uyMkkFWTIIja5jnt5X4h9kgPsdrRRwKSB5ZJPaA6nN6p6fkUhZy\n\t9FqhLHu4XY6mCa3h0as9vwh1lRHby87d4vE2kYjwG+9mXztILEQoHENWF3WWV/ma2QNv\n\tUrwXmzMdNRoqnL28ledHQk8iQPRsRTs93C8Rr1CcGdr0dU8dEmzLmEjV8bOiogQLyU2q\n\tvJM/56u77N6u5h0Ly0uwNCYFzXue+Pyw29NRt0QRrsXuUPgL12ifD/5YbBWhhbY/nSah\n\tLawnvcSpcBFFF5XOU9qZm/X+BhdR47PLWdSh36M1NeJhTB/bSjZ6FDrZBtsbe4L6JSBA\n\tNK8g==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCUv8mEll+bf/J6FLNA4jcobEWwUWv0pzePF17TRjPj+YkYQKMNBPtMlNAOMD2OWNhZwdGa/q6vNB01kFkKGkyc=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yw3e9kqaTGBeapeGxJ6DWMGV40o67/MOyuwBizVdgtIHQfEbTp2\n\t9+dzhxn9S9uOkhP2Xz+WPp0gmJfLaXZQCsQueeX7EY2D8bStGROcoSxdq7Thi4s/YRSgjNvJHk7\n\t0P9zGMmgySTVKo/KgX/TTo3XYKlb8uNZh/QgHh9T+qoL0Lb6TbD0LQuNN93aQgjZzO/cd7xdxn5\n\tSSdvPTyWw+ZAMMmWYrptJ0DW7MxvYZsqfPORjuk4P65SYDVpDa/O6EAlh7b6c=","X-Gm-Gg":"ASbGncuGFBd8mKyWyiL3StboRwFH76br6D6w75rEAGfj+sFSXkokDUVDCzxaeBgnsSE\n\t7TchaTweQ4A26QqcT6/lpxLT83VhdVzAspzaUg2GaYjrDBX9KBQwcVyPfZNSYdYDROmbCEJf/h4\n\tZWPjyZkG8HTbP/myDr2B4Jegpet5iBhRPwkGZHi2Dmgshw0/tdsB9YhXNo7R92cRZrLm5kufTi7\n\tNqoPTdDJF+p5uBC1VpnExzv7svoE/kNTlrGuk+ogOK9Eo5IVsj/x4ovR6bEkLcm3TMClkk/xOWS\n\tG47LHk9/+JtU5doi1o0xW0nvon0QxHHGO0rGyZo2ec5av3zu+KgNxn5yJmDKM6LWo63SwJz8L5U\n\tk2y+/sweDU+w3eR52","X-Received":["by 2002:a05:622a:352:b0:4af:68f3:4a17 with SMTP id\n\td75a77b69052e-4b29ff90070mr25445291cf.14.1755784381647; \n\tThu, 21 Aug 2025 06:53:01 -0700 (PDT)","by 2002:a05:622a:352:b0:4af:68f3:4a17 with SMTP id\n\td75a77b69052e-4b29ff90070mr25444661cf.14.1755784380784; \n\tThu, 21 Aug 2025 06:53:00 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGn+TfzfFJIyeFCjgFL1ELaJLr8p3/hL/zuicK/p9qUeNMm4oDakJckddcGtTJqqwDjakmj4Q==","From":"Milan Zamazal ","To":"mail@maciej.szmigiero.name","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/5] libcamera: software_isp: Pass correct y-coordinate\n\tto stats","In-Reply-To":"<20250821134141.83236-3-mzamazal@redhat.com> (Milan Zamazal's\n\tmessage of \"Thu, 21 Aug 2025 15:41:38 +0200\")","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<20250821134141.83236-3-mzamazal@redhat.com>","Date":"Thu, 21 Aug 2025 15:52:57 +0200","Message-ID":"<85plcobx3a.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"cCld7Eq6bPnoZTysZy54gh_JH1zpJbLOrGOw9eToblA_1755784382","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35542,"web_url":"https://patchwork.libcamera.org/comment/35542/","msgid":"","date":"2025-08-21T21:34:49","subject":"Re: [PATCH 2/5] libcamera: software_isp: Pass correct y-coordinate\n\tto stats","submitter":{"id":237,"url":"https://patchwork.libcamera.org/api/people/237/","name":"Maciej S. Szmigiero","email":"mail@maciej.szmigiero.name"},"content":"Hi Milan,\n\nOn 21.08.2025 15:52, Milan Zamazal wrote:\n> Hi Maciej,\n> \n> Milan Zamazal writes:\n> \n>> The window set by SwStatsCpu::setWindow is relative to the processed\n>> image area. But debayering passes the processed line y-coordinate to\n>> the stats relative to the whole image area. This can result in\n>> gathering stats from a wrong image area or in not gathering stats at\n>> all.\n>>\n>> Let's pass the correct y-coordinate to the stats processing methods.\n>>\n>> Bug: https://bugs.libcamera.org/show_bug.cgi?id=280\n>> Co-developed-by: Maciej S. Szmigiero \n\nThanks for including this patch in your series.\n \n> Feel free to attach your Signed-off-by here to get this line replaced by\n> it.\n> \n>> Signed-off-by: Milan Zamazal \n\nSure, here's my SoB tag:\nSigned-off-by: Maciej S. Szmigiero \n\nThanks,\nMaciej","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E501ABEFBE\n\tfor ;\n\tThu, 21 Aug 2025 21:34:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B4D1692E0;\n\tThu, 21 Aug 2025 23:34:57 +0200 (CEST)","from vps-ovh.mhejs.net (vps-ovh.mhejs.net [145.239.82.108])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C6B069257\n\tfor ;\n\tThu, 21 Aug 2025 23:34:55 +0200 (CEST)","from MUA\n\tby vps-ovh.mhejs.net with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256\n\t(Exim 4.98.2) (envelope-from )\n\tid 1upCvu-00000001a1g-15yc; Thu, 21 Aug 2025 23:34:54 +0200"],"Message-ID":"","Date":"Thu, 21 Aug 2025 23:34:49 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/5] libcamera: software_isp: Pass correct y-coordinate\n\tto stats","To":"Milan Zamazal ","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<20250821134141.83236-3-mzamazal@redhat.com>\n\t<85plcobx3a.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Language":"en-US, pl-PL","From":"\"Maciej S. Szmigiero\" ","Autocrypt":"addr=mail@maciej.szmigiero.name; keydata=\n\txsFNBFpGusUBEADXUMM2t7y9sHhI79+2QUnDdpauIBjZDukPZArwD+sDlx5P+jxaZ13XjUQc\n\t6oJdk+jpvKiyzlbKqlDtw/Y2Ob24tg1g/zvkHn8AVUwX+ZWWewSZ0vcwp7u/LvA+w2nJbIL1\n\tN0/QUUdmxfkWTHhNqgkNX5hEmYqhwUPozFR0zblfD/6+XFR7VM9yT0fZPLqYLNOmGfqAXlxY\n\tm8nWmi+lxkd/PYqQQwOq6GQwxjRFEvSc09m/YPYo9hxh7a6s8hAP88YOf2PD8oBB1r5E7KGb\n\tFv10Qss4CU/3zaiyRTExWwOJnTQdzSbtnM3S8/ZO/sL0FY/b4VLtlZzERAraxHdnPn8GgxYk\n\toPtAqoyf52RkCabL9dsXPWYQjkwG8WEUPScHDy8Uoo6imQujshG23A99iPuXcWc/5ld9mIo/\n\tEe7kN50MOXwS4vCJSv0cMkVhh77CmGUv5++E/rPcbXPLTPeRVy6SHgdDhIj7elmx2Lgo0cyh\n\tuyxyBKSuzPvb61nh5EKAGL7kPqflNw7LJkInzHqKHDNu57rVuCHEx4yxcKNB4pdE2SgyPxs9\n\t9W7Cz0q2Hd7Yu8GOXvMfQfrBiEV4q4PzidUtV6sLqVq0RMK7LEi0RiZpthwxz0IUFwRw2KS/\n\t9Kgs9LmOXYimodrV0pMxpVqcyTepmDSoWzyXNP2NL1+GuQtaTQARAQABzTBNYWNpZWogUy4g\n\tU3ptaWdpZXJvIDxtYWlsQG1hY2llai5zem1pZ2llcm8ubmFtZT7CwZQEEwEIAD4CGwMFCwkI\n\tBwIGFQoJCAsCBBYCAwECHgECF4AWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxhgUJD0w7\n\twQAKCRCEf143kM4JdwHlD/9Ef793d6Q3WkcapGZLg1hrUg+S3d1brtJSKP6B8Ny0tt/6kjc2\n\tM8q4v0pY6rA/tksIbBw6ZVZNCoce0w3/sy358jcDldh/eYotwUCHQzXl2IZwRT2SbmEoJn9J\n\tnAOnjMCpMFRyBC1yiWzOR3XonLFNB+kWfTK3fwzKWCmpcUkI5ANrmNiDFPcsn+TzfeMV/CzT\n\tFMsqVmr+TCWl29QB3U0eFZP8Y01UiowugS0jW/B/zWYbWo2FvoOqGLRUWgQ20NBXHlV5m0qa\n\twI2Isrbos1kXSl2TDovT0Ppt+66RhV36SGA2qzLs0B9LO7/xqF4/xwmudkpabOoH5g3T20aH\n\txlB0WuTJ7FyxZGnO6NL9QTxx3t86FfkKVfTksKP0FRKujsOxGQ1JpqdazyO6k7yMFfcnxwAb\n\tMyLU6ZepXf/6LvcFFe0oXC+ZNqj7kT6+hoTkZJcxynlcxSRzRSpnS41MRHJbyQM7kjpuVdyQ\n\tBWPdBnW0bYamlsW00w5XaR+fvNr4fV0vcqB991lxD4ayBbYPz11tnjlOwqnawH1ctCy5rdBY\n\teTC6olpkmyUhrrIpTgEuxNU4GvnBK9oEEtNPC/x58AOxQuf1FhqbHYjz8D2Pyhso8TwS7NTa\n\tZ8b8o0vfsuqd3GPJKMiEhLEgu/io2KtLG10ynfh0vDBDQ7bwKoVlqC3It87AzQRaRrwiAQwA\n\txnVmJqeP9VUTISps+WbyYFYlMFfIurl7tzK74bc67KUBp+PHuDP9p4ZcJUGC3UZJP85/GlUV\n\tdE1NairYWEJQUB7bpogTuzMI825QXIB9z842HwWfP2RW5eDtJMeujzJeFaUpmeTG9snzaYxY\n\tN3r0TDKj5dZwSIThIMQpsmhH2zylkT0jH7kBPxb8IkCQ1c6wgKITwoHFjTIO0B75U7bBNSDp\n\tXUaUDvd6T3xd1Fz57ujAvKHrZfWtaNSGwLmUYQAcFvrKDGPB5Z3ggkiTtkmW3OCQbnIxGJJw\n\t/+HefYhB5/kCcpKUQ2RYcYgCZ0/WcES1xU5dnNe4i0a5gsOFSOYCpNCfTHttVxKxZZTQ/rxj\n\tXwTuToXmTI4Nehn96t25DHZ0t9L9UEJ0yxH2y8Av4rtf75K2yAXFZa8dHnQgCkyjA/gs0ujG\n\twD+Gs7dYQxP4i+rLhwBWD3mawJxLxY0vGwkG7k7npqanlsWlATHpOdqBMUiAR22hs02FikAo\n\tiXNgWTy7ABEBAAHCwXwEGAEIACYCGwwWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxrgUJ\n\tD0w6ggAKCRCEf143kM4Jd55ED/9M47pnUYDVoaa1Xu4dVHw2h0XhBS/svPqb80YtjcBVgRp0\n\tPxLkI6afwteLsjpDgr4QbjoF868ctjqs6p/M7+VkFJNSa4hPmCayU310zEawO4EYm+jPRUIJ\n\ti87pEmygoN4ZnXvOYA9lkkbbaJkYB+8rDFSYeeSjuez0qmISbzkRVBwhGXQG5s5Oyij2eJ7f\n\tOvtjExsYkLP3NqmsODWj9aXqWGYsHPa7NpcLvHtkhtc5+SjRRLzh/NWJUtgFkqNPfhGMNwE8\n\tIsgCYA1B0Wam1zwvVgn6yRcwaCycr/SxHZAR4zZQNGyV1CA+Ph3cMiL8s49RluhiAiDqbJDx\n\tvoSNR7+hz6CXrAuFnUljMMWiSSeWDF+qSKVmUJIFHWW4s9RQofkF8/Bd6BZxIWQYxMKZm4S7\n\tdKo+5COEVOhSyYthhxNMCWDxLDuPoiGUbWBu/+8dXBusBV5fgcZ2SeQYnIvBzMj8NJ2vDU2D\n\tm/ajx6lQA/hW0zLYAew2v6WnHFnOXUlI3hv9LusUtj3XtLV2mf1FHvfYlrlI9WQsLiOE5nFN\n\tIsqJLm0TmM0i8WDnWovQHM8D0IzI/eUc4Ktbp0fVwWThP1ehdPEUKGCZflck5gvuU8yqE55r\n\tVrUwC3ocRUs4wXdUGZp67sExrfnb8QC2iXhYb+TpB8g7otkqYjL/nL8cQ8hdmg==","In-Reply-To":"<85plcobx3a.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]