[{"id":35485,"web_url":"https://patchwork.libcamera.org/comment/35485/","msgid":"<175552882761.2641331.11749588631317961450@ping.linuxembedded.co.uk>","date":"2025-08-18T14:53:47","subject":"Re: [PATCH 2/2] meson: Use dependency('dl')","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-08-18 15:45:31)\n> Support for locating libdl through dependency('dl') was broken before\n> meson v0.62.0. Now that we require a newer version, drop the hack and\n> use the dependency() function.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/meson.build | 8 +-------\n> 1 file changed, 1 insertion(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index de1eb99b28fd..b3ca27f217da 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -76,13 +76,7 @@ subdir('proxy')\n> subdir('sensor')\n> subdir('software_isp')\n> \n> -null_dep = dependency('', required : false)\n> -\n> -# TODO: Use dependency('dl') when updating to meson 0.62.0 or newer.\n\nLooks like a good time ;-)\n\nReviewed-by: Kieran Bingham \n\n> -libdl = null_dep\n> -if not cc.has_function('dlopen')\n> - libdl = cc.find_library('dl')\n> -endif\n> +libdl = dependency('dl')\n> libudev = dependency('libudev', required : get_option('udev'))\n> libyaml = dependency('yaml-0.1', default_options : [\n> 'default_library=static',\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C32DEBDCC1\n\tfor ;\n\tMon, 18 Aug 2025 14:53:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 815956925F;\n\tMon, 18 Aug 2025 16:53:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CA7C69259\n\tfor ;\n\tMon, 18 Aug 2025 16:53:51 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B74C511EB;\n\tMon, 18 Aug 2025 16:52:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sitajeiQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755528773;\n\tbh=nOccQ5rOG6MtiJqQ2rmVhoa6fYbZCFUOaI6rJ4AxQDQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=sitajeiQGOhJS3L9L3G2NE+7hhRhuoaWHLsVauKmGuUyaufkn95UR5nEdmMWOKf0q\n\tkUmkTww1oMxW2z1nBYeetgYRYFjElFQUu6vuqBQtqJnJf7eCUJMifUZ+AoOwUlrtRu\n\tDgcbiQIIb7ky59UjkaOGIjycXoXgEfo0LpVJPc3g=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250818144531.6406-2-laurent.pinchart@ideasonboard.com>","References":"<20250818144531.6406-1-laurent.pinchart@ideasonboard.com>\n\t<20250818144531.6406-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 2/2] meson: Use dependency('dl')","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 18 Aug 2025 15:53:47 +0100","Message-ID":"<175552882761.2641331.11749588631317961450@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35487,"web_url":"https://patchwork.libcamera.org/comment/35487/","msgid":"<84fe0623-0633-4b43-960f-bcd8ce858f1b@ideasonboard.com>","date":"2025-08-18T15:00:52","subject":"Re: [PATCH 2/2] meson: Use dependency('dl')","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 08. 18. 16:45 keltezéssel, Laurent Pinchart írta:\n> Support for locating libdl through dependency('dl') was broken before\n> meson v0.62.0. Now that we require a newer version, drop the hack and\n> use the dependency() function.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/meson.build | 8 +-------\n> 1 file changed, 1 insertion(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index de1eb99b28fd..b3ca27f217da 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -76,13 +76,7 @@ subdir('proxy')\n> subdir('sensor')\n> subdir('software_isp')\n> \n> -null_dep = dependency('', required : false)\n> -\n> -# TODO: Use dependency('dl') when updating to meson 0.62.0 or newer.\n> -libdl = null_dep\n> -if not cc.has_function('dlopen')\n> - libdl = cc.find_library('dl')\n> -endif\n> +libdl = dependency('dl')\n> libudev = dependency('libudev', required : get_option('udev'))\n> libyaml = dependency('yaml-0.1', default_options : [\n> 'default_library=static',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49B82BEFBE\n\tfor ;\n\tMon, 18 Aug 2025 15:00:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C456A69259;\n\tMon, 18 Aug 2025 17:00:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D69B769257\n\tfor ;\n\tMon, 18 Aug 2025 17:00:54 +0200 (CEST)","from [192.168.33.19] (185.221.141.188.nat.pool.zt.hu\n\t[185.221.141.188])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B37E11EB;\n\tMon, 18 Aug 2025 16:59:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YxuegVxP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755529197;\n\tbh=WarJOHDTw8oB/VFbYpJPUtEr13eqSir79kOSjZwl/So=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=YxuegVxPROw6+yamnmZOcWPQEVixKlH2WBfqzFvzl9a8baXFxIKn9KC4l3nL+U/ud\n\tkeRyCcwPEpXWRZmJGdKXIKn25bK14g2nXywGv+w88ozVrsXcaSWQeh3Fh4TgOIMbUe\n\tIcS6ii9NPMfpx5OYDLsPEPuHh18WQNu1ajtuDGZo=","Message-ID":"<84fe0623-0633-4b43-960f-bcd8ce858f1b@ideasonboard.com>","Date":"Mon, 18 Aug 2025 17:00:52 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/2] meson: Use dependency('dl')","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250818144531.6406-1-laurent.pinchart@ideasonboard.com>\n\t<20250818144531.6406-2-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250818144531.6406-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]