[{"id":35450,"web_url":"https://patchwork.libcamera.org/comment/35450/","msgid":"<175526865936.1721288.12135417258846256656@ping.linuxembedded.co.uk>","date":"2025-08-15T14:37:39","subject":"Re: [RFC PATCH v1] apps: cam: Do not overwrite name when adding\n\tcamera model","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-08-15 15:25:22)\n> If `addModel` is true, then the previously set `name` will be overwritten.\n> This does not seem to be the intended behaviour, so fix it by using `+=`.\n> \n> Before:\n> \n> Available cameras:\n> 1: 'imx219' (/base/soc@0/bus@30800000/i2c@30a30000/camera@10)\n> \n> After:\n> \n> Available cameras:\n> 1: External camera 'imx219' (/base/soc@0/bus@30800000/i2c@30a30000/camera@10)\n> \n\nThank you - it's always so much more helpful when the effects are\nclearly documented like that!\n\n\nReviewed-by: Kieran Bingham \n\n> Fixes: aab49f903e858a (\"cam: Do not assume Location is available\")\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/apps/cam/main.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/apps/cam/main.cpp b/src/apps/cam/main.cpp\n> index cbc85b59f..ad6bde68a 100644\n> --- a/src/apps/cam/main.cpp\n> +++ b/src/apps/cam/main.cpp\n> @@ -322,7 +322,7 @@ std::string CamApp::cameraName(const Camera *camera)\n> */\n> const auto &model = props.get(properties::Model);\n> if (model)\n> - name = \"'\" + *model + \"' \";\n> + name += \"'\" + *model + \"' \";\n> }\n> \n> name += \"(\" + camera->id() + \")\";\n> -- \n> 2.50.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4EA6EBDCC1\n\tfor ;\n\tFri, 15 Aug 2025 14:37:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C6BE69259;\n\tFri, 15 Aug 2025 16:37:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C60161443\n\tfor ;\n\tFri, 15 Aug 2025 16:37:42 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 163A856D;\n\tFri, 15 Aug 2025 16:36:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LZmiyI44\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755268607;\n\tbh=7k0WdfJN7v3pqJcgC7prYVnDLvdpqYvO7++0JO3Rm74=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=LZmiyI44n+NsrfXp2QAYfmI+zBIGN1Eab2tuVyuaewDX0zlxNgmiTKjN/idIFK+Rb\n\t8C4V4VQ1VJIK2tRE10JWNgdkRbsoCOFebUE3cyNqsygO1SabTVzp3A+PzUQSXY3srX\n\tXwhuw/e5Itqm8EKwXj6gLf4JiFkI35gh3PWCPynY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250815142522.2237088-1-barnabas.pocze@ideasonboard.com>","References":"<20250815142522.2237088-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v1] apps: cam: Do not overwrite name when adding\n\tcamera model","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 15 Aug 2025 15:37:39 +0100","Message-ID":"<175526865936.1721288.12135417258846256656@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35496,"web_url":"https://patchwork.libcamera.org/comment/35496/","msgid":"<20250819024842.GK5862@pendragon.ideasonboard.com>","date":"2025-08-19T02:48:42","subject":"Re: [RFC PATCH v1] apps: cam: Do not overwrite name when adding\n\tcamera model","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Fri, Aug 15, 2025 at 04:25:22PM +0200, Barnabás Pőcze wrote:\n> If `addModel` is true, then the previously set `name` will be overwritten.\n> This does not seem to be the intended behaviour, so fix it by using `+=`.\n> \n> Before:\n> \n> Available cameras:\n> 1: 'imx219' (/base/soc@0/bus@30800000/i2c@30a30000/camera@10)\n> \n> After:\n> \n> Available cameras:\n> 1: External camera 'imx219' (/base/soc@0/bus@30800000/i2c@30a30000/camera@10)\n> \n> Fixes: aab49f903e858a (\"cam: Do not assume Location is available\")\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/apps/cam/main.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/apps/cam/main.cpp b/src/apps/cam/main.cpp\n> index cbc85b59f..ad6bde68a 100644\n> --- a/src/apps/cam/main.cpp\n> +++ b/src/apps/cam/main.cpp\n> @@ -322,7 +322,7 @@ std::string CamApp::cameraName(const Camera *camera)\n> \t\t */\n> \t\tconst auto &model = props.get(properties::Model);\n> \t\tif (model)\n> -\t\t\tname = \"'\" + *model + \"' \";\n> +\t\t\tname += \"'\" + *model + \"' \";\n> \t}\n> \n> \tname += \"(\" + camera->id() + \")\";","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85486BDCC1\n\tfor ;\n\tTue, 19 Aug 2025 02:49:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 547ED69266;\n\tTue, 19 Aug 2025 04:49:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47499613C5\n\tfor ;\n\tTue, 19 Aug 2025 04:49:05 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 69E70107;\n\tTue, 19 Aug 2025 04:48:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Unc0Dg36\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755571687;\n\tbh=HVok4kw/lphECbz/tvFLjnjBYUd1uNdvD5xL3IblHPY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Unc0Dg368kp5IpVMurye4taqxdu9MfJ/qW5DRMsOIp1dJFYvWGhB2g2x7A534xRuK\n\tqDS67UtdTKg+NLqk34kZvyi/pMTQ1zgtVRHr99rPtfUDkra9tUmYysccDUzCBptYIv\n\tDMCYCIcOLRvLZpUJEt/nZHA4i8CXWQX/GEpaMXww=","Date":"Tue, 19 Aug 2025 05:48:42 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1] apps: cam: Do not overwrite name when adding\n\tcamera model","Message-ID":"<20250819024842.GK5862@pendragon.ideasonboard.com>","References":"<20250815142522.2237088-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250815142522.2237088-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]