{"id":24140,"url":"https://patchwork.libcamera.org/api/patches/24140/?format=json","web_url":"https://patchwork.libcamera.org/patch/24140/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250815123138.2213654-2-barnabas.pocze@ideasonboard.com>","date":"2025-08-15T12:31:37","name":"[RFC,v2,2/3] utils: codegen: ipc: Default special member ops","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"f93d0089b7f4f420a65e4f6941d24bc4749315f5","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24140/mbox/","series":[{"id":5384,"url":"https://patchwork.libcamera.org/api/series/5384/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5384","date":"2025-08-15T12:31:36","name":"[RFC,v2,1/3] utils: codegen: ipc: Put default values in declaration","version":2,"mbox":"https://patchwork.libcamera.org/series/5384/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24140/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24140/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25EEBBDCC1\n\tfor ;\n\tFri, 15 Aug 2025 12:31:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 255DF69259;\n\tFri, 15 Aug 2025 14:31:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1048F6924E\n\tfor ;\n\tFri, 15 Aug 2025 14:31:43 +0200 (CEST)","from pb-laptop.local (185.221.141.188.nat.pool.zt.hu\n\t[185.221.141.188])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C6FB63B;\n\tFri, 15 Aug 2025 14:30:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QsalsLYz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755261048;\n\tbh=184HUgCoMcq401l6660AonJKHgbcZ6p+pB4xZviEhgA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=QsalsLYzBmGF5leE7bjRd1wiZiyyVtNMHs5UQh5TP1KnaqsnTWGfMRH5RAXBXbJWc\n\tyKvnS7CrfeuwTrd5rA66GUpz2jr/eZbGualjhPK4sU0IBoP70kFGYUxVVI8VDU/e+1\n\tJbbenweIKz9J9/IfYCRWjFdBDi4OrGojsNVZs13c=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org,\n\tPaul Elder ,\n\tLaurent Pinchart ","Subject":"[RFC PATCH v2 2/3] utils: codegen: ipc: Default special member ops","Date":"Fri, 15 Aug 2025 14:31:37 +0200","Message-ID":"<20250815123138.2213654-2-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20250815123138.2213654-1-barnabas.pocze@ideasonboard.com>","References":"<20250815123138.2213654-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Default the copy/move constructor/assignment operators so that\nthey are available if possible. This can allow more efficient\npassing and construction of these objects.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Paul Elder \n---\nchanges in v2: none\n---\n .../libcamera_templates/definition_functions.tmpl | 6 ++++++\n 1 file changed, 6 insertions(+)\n\n--\n2.50.1","diff":"diff --git a/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl b/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\nindex 16d11c309..3a57a3c2c 100644\n--- a/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n+++ b/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n@@ -39,6 +39,12 @@ public:\n {%- endfor %}\n \t{\n \t}\n+\n+\t{{struct.mojom_name}}(const {{struct.mojom_name}} &) = default;\n+\t{{struct.mojom_name}} &operator=(const {{struct.mojom_name}} &) = default;\n+\t{{struct.mojom_name}}({{struct.mojom_name}} &&) = default;\n+\t{{struct.mojom_name}} &operator=({{struct.mojom_name}} &&) = default;\n+\t~{{struct.mojom_name}}() = default;\n #endif\n\n {% for field in struct.fields %}\n","prefixes":["RFC","v2","2/3"]}