[{"id":35449,"web_url":"https://patchwork.libcamera.org/comment/35449/","msgid":"<20250815143404.GD8360@pendragon.ideasonboard.com>","date":"2025-08-15T14:34:04","subject":"Re: [RFC PATCH v2 1/3] utils: codegen: ipc: Put default values in\n\tdeclaration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Aug 15, 2025 at 02:31:36PM +0200, Barnabás Pőcze wrote:\n> Instead of generating a constructor to initialize each member\n> to its default value, simply specify the default values in\n> the declaration of the member.\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> changes in v2: none\n> ---\n> .../libcamera_templates/definition_functions.tmpl | 12 ++----------\n> 1 file changed, 2 insertions(+), 10 deletions(-)\n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl b/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n> index 8b8509f3d..16d11c309 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n> @@ -26,13 +26,7 @@ struct {{struct.mojom_name}}\n> {\n> public:\n> #ifndef __DOXYGEN__\n> -\t{{struct.mojom_name}}() {%- if struct|has_default_fields %}\n> -\t\t:{% endif %}\n> -{%- for field in struct.fields|with_default_values -%}\n> -{{\" \" if loop.first}}{{field.mojom_name}}({{field|default_value}}){{\", \" if not loop.last}}\n> -{%- endfor %}\n> -\t{\n> -\t}\n> +\t{{struct.mojom_name}}() = default;\n> \n> \t{{struct.mojom_name}}(\n> {%- for field in struct.fields -%}\n> @@ -48,9 +42,7 @@ public:\n> #endif\n> \n> {% for field in struct.fields %}\n> -\t{{field|name}} {{field.mojom_name}};\n> +\t{{field|name}} {{field.mojom_name}}{% if field|default_value %}{ {{field|default_value}} }{% endif %};\n> {%- endfor %}\n> };\n> {%- endmacro -%}\n> -\n> -","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 594C1BEFBE\n\tfor ;\n\tFri, 15 Aug 2025 14:34:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10AA26924E;\n\tFri, 15 Aug 2025 16:34:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2904D61443\n\tfor ;\n\tFri, 15 Aug 2025 16:34:25 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id C53F556D;\n\tFri, 15 Aug 2025 16:33:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SOu2xzS7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755268410;\n\tbh=3h4pyssUVt0HQcuXwYIqXTms/05D1I96HpPJiVxyFrQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SOu2xzS7i9+tNXrl4JvElGnCMBpaBgGjY5NkidAmktiVRGb5R+HDQ3qTGHC9LD/PH\n\tjpxJxF0xpc6FfwEA/vWkuO94Gye8ed6nkNiZSxpjo3UNe6y63eTuXByQHRt9Qfb9rf\n\twD7/gb1KxvcCXWW14TDf5lKdu0+jm+1qfmtp+dK0=","Date":"Fri, 15 Aug 2025 17:34:04 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tPaul Elder ","Subject":"Re: [RFC PATCH v2 1/3] utils: codegen: ipc: Put default values in\n\tdeclaration","Message-ID":"<20250815143404.GD8360@pendragon.ideasonboard.com>","References":"<20250815123138.2213654-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250815123138.2213654-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]