{"id":24139,"url":"https://patchwork.libcamera.org/api/patches/24139/?format=json","web_url":"https://patchwork.libcamera.org/patch/24139/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250815123138.2213654-1-barnabas.pocze@ideasonboard.com>","date":"2025-08-15T12:31:36","name":"[RFC,v2,1/3] utils: codegen: ipc: Put default values in declaration","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5cc7d8fd074e3f7978ebc24d862f05a9d8d480ac","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24139/mbox/","series":[{"id":5384,"url":"https://patchwork.libcamera.org/api/series/5384/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5384","date":"2025-08-15T12:31:36","name":"[RFC,v2,1/3] utils: codegen: ipc: Put default values in declaration","version":2,"mbox":"https://patchwork.libcamera.org/series/5384/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24139/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24139/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6DC6BDCC1\n\tfor ;\n\tFri, 15 Aug 2025 12:31:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D688A6925D;\n\tFri, 15 Aug 2025 14:31:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C030561443\n\tfor ;\n\tFri, 15 Aug 2025 14:31:42 +0200 (CEST)","from pb-laptop.local (185.221.141.188.nat.pool.zt.hu\n\t[185.221.141.188])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD34D56D;\n\tFri, 15 Aug 2025 14:30:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Re9KQEn4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755261047;\n\tbh=WNkUQ+Q5XAw9ynxLKWUi3+LZdMgea8NIBuB6pCh5mBQ=;\n\th=From:To:Subject:Date:From;\n\tb=Re9KQEn4rAw9a7T5TK+0FSG2Il05bMv6AxS4G9mU5Knbf9jZkoFbf/FzkhK6ckute\n\tfOJBgFxlLMMbFMjftQ4cl2P/Oe82t1vnHleMmbcOBjwTRHWUi0caM4nWI5dxDKNbsA\n\trT58Xa0m1JJWVWuhZSSbxAS2TjUqWSzOUT9P/wgs=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org,\n\tPaul Elder ,\n\tLaurent Pinchart ","Subject":"[RFC PATCH v2 1/3] utils: codegen: ipc: Put default values in\n\tdeclaration","Date":"Fri, 15 Aug 2025 14:31:36 +0200","Message-ID":"<20250815123138.2213654-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of generating a constructor to initialize each member\nto its default value, simply specify the default values in\nthe declaration of the member.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Paul Elder \n---\nchanges in v2: none\n---\n .../libcamera_templates/definition_functions.tmpl | 12 ++----------\n 1 file changed, 2 insertions(+), 10 deletions(-)\n\n--\n2.50.1","diff":"diff --git a/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl b/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\nindex 8b8509f3d..16d11c309 100644\n--- a/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n+++ b/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n@@ -26,13 +26,7 @@ struct {{struct.mojom_name}}\n {\n public:\n #ifndef __DOXYGEN__\n-\t{{struct.mojom_name}}() {%- if struct|has_default_fields %}\n-\t\t:{% endif %}\n-{%- for field in struct.fields|with_default_values -%}\n-{{\" \" if loop.first}}{{field.mojom_name}}({{field|default_value}}){{\", \" if not loop.last}}\n-{%- endfor %}\n-\t{\n-\t}\n+\t{{struct.mojom_name}}() = default;\n\n \t{{struct.mojom_name}}(\n {%- for field in struct.fields -%}\n@@ -48,9 +42,7 @@ public:\n #endif\n\n {% for field in struct.fields %}\n-\t{{field|name}} {{field.mojom_name}};\n+\t{{field|name}} {{field.mojom_name}}{% if field|default_value %}{ {{field|default_value}} }{% endif %};\n {%- endfor %}\n };\n {%- endmacro -%}\n-\n-\n","prefixes":["RFC","v2","1/3"]}