[{"id":35443,"web_url":"https://patchwork.libcamera.org/comment/35443/","msgid":"<1570e97c-4303-4457-bd3c-a114398777ae@ideasonboard.com>","date":"2025-08-15T11:54:19","subject":"Re: [PATCH v2 7/8] apps: cam: drm: Drop unneeded local variable","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 08. 15. 13:33 keltezéssel, Laurent Pinchart írta:\n> The planes variable in the Device::createFrameBuffer() function is a\n> reference to buffer.planes() that is only used as a range initializer in\n> a range-based for loop. Use buffer.planes() directly and drop the\n> variable.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/apps/cam/drm.cpp | 4 +---\n> 1 file changed, 1 insertion(+), 3 deletions(-)\n> \n> diff --git a/src/apps/cam/drm.cpp b/src/apps/cam/drm.cpp\n> index f4b47097649a..8e2dfd9a64e4 100644\n> --- a/src/apps/cam/drm.cpp\n> +++ b/src/apps/cam/drm.cpp\n> @@ -659,10 +659,8 @@ std::unique_ptr Device::createFrameBuffer(\n> \tuint32_t offsets[4] = {};\n> \tint ret;\n> \n> -\tconst std::vector &planes = buffer.planes();\n> -\n> \tunsigned int i = 0;\n> -\tfor (const libcamera::FrameBuffer::Plane &plane : planes) {\n> +\tfor (const libcamera::FrameBuffer::Plane &plane : buffer.planes()) {\n> \t\tint fd = plane.fd.get();\n> \t\tuint32_t handle;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 768D1BDCC1\n\tfor ;\n\tFri, 15 Aug 2025 11:54:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3884169257;\n\tFri, 15 Aug 2025 13:54:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C82C961443\n\tfor ;\n\tFri, 15 Aug 2025 13:54:22 +0200 (CEST)","from [192.168.33.21] (185.221.141.188.nat.pool.zt.hu\n\t[185.221.141.188])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5393605;\n\tFri, 15 Aug 2025 13:53:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NbCLO9Dq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755258808;\n\tbh=7O1IsBoSeCiq5UJIREfZgfsF1jbA1AMQOhisp0dXoJE=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=NbCLO9DqScVt/bVfd6jmwIAL4HahzdnxFeo5JXRm4rgN2tGWgJdYKm9kat9kSkSeX\n\trV8jNlpfDbAeUfSffMr5KEbANTnWEsfurARil0tCn6XVVgwq1vQK2KlKwq0rdj/oG/\n\tQFAJp1j5u71xhJWg5I8d8lTrm6Dqf4xPMjzgGY68=","Message-ID":"<1570e97c-4303-4457-bd3c-a114398777ae@ideasonboard.com>","Date":"Fri, 15 Aug 2025 13:54:19 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 7/8] apps: cam: drm: Drop unneeded local variable","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Daniel_R=C3=A1kos?= ","References":"<20250815113400.20623-1-laurent.pinchart@ideasonboard.com>\n\t<20250815113400.20623-8-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250815113400.20623-8-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35521,"web_url":"https://patchwork.libcamera.org/comment/35521/","msgid":"","date":"2025-08-19T15:32:27","subject":"Re: [PATCH v2 7/8] apps: cam: drm: Drop unneeded local variable","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Fri, Aug 15, 2025 at 02:33:59PM +0300, Laurent Pinchart wrote:\n> The planes variable in the Device::createFrameBuffer() function is a\n> reference to buffer.planes() that is only used as a range initializer in\n> a range-based for loop. Use buffer.planes() directly and drop the\n> variable.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/apps/cam/drm.cpp | 4 +---\n> 1 file changed, 1 insertion(+), 3 deletions(-)\n>\n> diff --git a/src/apps/cam/drm.cpp b/src/apps/cam/drm.cpp\n> index f4b47097649a..8e2dfd9a64e4 100644\n> --- a/src/apps/cam/drm.cpp\n> +++ b/src/apps/cam/drm.cpp\n> @@ -659,10 +659,8 @@ std::unique_ptr Device::createFrameBuffer(\n> \tuint32_t offsets[4] = {};\n> \tint ret;\n>\n> -\tconst std::vector &planes = buffer.planes();\n> -\n> \tunsigned int i = 0;\n> -\tfor (const libcamera::FrameBuffer::Plane &plane : planes) {\n> +\tfor (const libcamera::FrameBuffer::Plane &plane : buffer.planes()) {\n> \t\tint fd = plane.fd.get();\n> \t\tuint32_t handle;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18252BEFBE\n\tfor ;\n\tTue, 19 Aug 2025 15:32:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81B91692E5;\n\tTue, 19 Aug 2025 17:32:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD07F692DC\n\tfor ;\n\tTue, 19 Aug 2025 17:32:32 +0200 (CEST)","from ideasonboard.com (mob-5-90-52-92.net.vodafone.it [5.90.52.92])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4AE371F0E;\n\tTue, 19 Aug 2025 17:31:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"f7wtIbaG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755617494;\n\tbh=nGh9jnkPCmVs3R5N8SQTm6EyAOh+uIZEoyiv7qbdj4o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=f7wtIbaG3Ms9kYqNBgOGRgFj1LWARIjyLwzv7s7mNDR28MHffdpSGl2/POx8fSknC\n\tIJ6tSznyN1XOu/vel6fB6qAAeG7w53Mm3Q145WZNmpbL0bYBeCPiY4Aq1vKZG8nBdA\n\t3MhZnDJmuYnokO0UdjrrxE5m5pgo9bNyldP/vorM=","Date":"Tue, 19 Aug 2025 17:32:27 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Daniel =?utf-8?b?UsOha29z?=\n\t","Subject":"Re: [PATCH v2 7/8] apps: cam: drm: Drop unneeded local variable","Message-ID":"","References":"<20250815113400.20623-1-laurent.pinchart@ideasonboard.com>\n\t<20250815113400.20623-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250815113400.20623-8-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]