{"id":24137,"url":"https://patchwork.libcamera.org/api/patches/24137/?format=json","web_url":"https://patchwork.libcamera.org/patch/24137/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250815113400.20623-8-laurent.pinchart@ideasonboard.com>","date":"2025-08-15T11:33:59","name":"[v2,7/8] apps: cam: drm: Drop unneeded local variable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4080bb6624f78a1ead3bbebc7433dc67df290bfe","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24137/mbox/","series":[{"id":5383,"url":"https://patchwork.libcamera.org/api/series/5383/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5383","date":"2025-08-15T11:33:52","name":"libcamera: Use span in FrameBuffer & assorted cleanups","version":2,"mbox":"https://patchwork.libcamera.org/series/5383/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24137/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24137/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AA05BEFBE\n\tfor ;\n\tFri, 15 Aug 2025 11:34:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A04FE69251;\n\tFri, 15 Aug 2025 13:34:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9230061443\n\tfor ;\n\tFri, 15 Aug 2025 13:34:31 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8728E6A8;\n\tFri, 15 Aug 2025 13:33:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GSePDtPM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755257616;\n\tbh=y38SG3xNuZuULB3Zxaqk+jL2f/qgvZPgeeC1na8h2yc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GSePDtPMoLW5x1uTl9WKnPCRZ9fQG8F0LAf9LitKtQkj7BE6u1vwwI8QVla45K0QH\n\tcD6AN22hgD3L6Jxt/deayzqOTVtDDvFm1Ek+jMiw0GEWrky/MbT+aHx2M57wtnm0gP\n\tdIJ3yCVXHBHSm3gOD/KTNK6047s/hspO8+nTCuKU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Daniel_R=C3=A1kos?= ","Subject":"[PATCH v2 7/8] apps: cam: drm: Drop unneeded local variable","Date":"Fri, 15 Aug 2025 14:33:59 +0300","Message-ID":"<20250815113400.20623-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.49.1","In-Reply-To":"<20250815113400.20623-1-laurent.pinchart@ideasonboard.com>","References":"<20250815113400.20623-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The planes variable in the Device::createFrameBuffer() function is a\nreference to buffer.planes() that is only used as a range initializer in\na range-based for loop. Use buffer.planes() directly and drop the\nvariable.\n\nSigned-off-by: Laurent Pinchart \n---\n src/apps/cam/drm.cpp | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/src/apps/cam/drm.cpp b/src/apps/cam/drm.cpp\nindex f4b47097649a..8e2dfd9a64e4 100644\n--- a/src/apps/cam/drm.cpp\n+++ b/src/apps/cam/drm.cpp\n@@ -659,10 +659,8 @@ std::unique_ptr Device::createFrameBuffer(\n \tuint32_t offsets[4] = {};\n \tint ret;\n \n-\tconst std::vector &planes = buffer.planes();\n-\n \tunsigned int i = 0;\n-\tfor (const libcamera::FrameBuffer::Plane &plane : planes) {\n+\tfor (const libcamera::FrameBuffer::Plane &plane : buffer.planes()) {\n \t\tint fd = plane.fd.get();\n \t\tuint32_t handle;\n \n","prefixes":["v2","7/8"]}