[{"id":35447,"web_url":"https://patchwork.libcamera.org/comment/35447/","msgid":"<8ba914ba-e897-4908-891e-5a838d0bfc14@ideasonboard.com>","date":"2025-08-15T12:16:49","subject":"Re: [PATCH v2 2/8] pipeline: ipu3: Drop unneeded forward\n\tdeclarations","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 08. 15. 13:33 keltezéssel, Laurent Pinchart írta:\n> Multiple classes are forward-declared in frames.h, without being used in\n> that header file. Drop the unneeded forward declarations.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/pipeline/ipu3/frames.h | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h\n> index 1cabd0e64d6e..36a23b9b198e 100644\n> --- a/src/libcamera/pipeline/ipu3/frames.h\n> +++ b/src/libcamera/pipeline/ipu3/frames.h\n> @@ -19,11 +19,7 @@\n> namespace libcamera {\n> \n> class FrameBuffer;\n> -class IPAProxy;\n> -class PipelineHandler;\n> class Request;\n> -class V4L2VideoDevice;\n> -struct IPABuffer;\n> \n> class IPU3Frames\n> {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA410BDCC1\n\tfor ;\n\tFri, 15 Aug 2025 12:16:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9861069257;\n\tFri, 15 Aug 2025 14:16:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD4ED61443\n\tfor ;\n\tFri, 15 Aug 2025 14:16:55 +0200 (CEST)","from [192.168.33.21] (185.221.141.188.nat.pool.zt.hu\n\t[185.221.141.188])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7664456D;\n\tFri, 15 Aug 2025 14:16:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EM5SikDc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755260161;\n\tbh=Ty0z/GpGWgcKrUIRdBTeMMUfx+aYJM5z6kYQh2IDWWo=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=EM5SikDcvDrrfE47l0hDY6T2r2qXg0FTgvV5ojN+h8S29dhRMhY3t0c4ZIK8evQLz\n\tlLToLi/MA8ZfcGXWDKMvRCiIZlJXzXBtKPJFW7H1X9VVWpYcvvtsOZUC38CbhT0SiI\n\t0aYMLJkIpsMv/UE3bfgDmwYWg+hHlhvDSNbl/css=","Message-ID":"<8ba914ba-e897-4908-891e-5a838d0bfc14@ideasonboard.com>","Date":"Fri, 15 Aug 2025 14:16:49 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 2/8] pipeline: ipu3: Drop unneeded forward\n\tdeclarations","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Daniel_R=C3=A1kos?= ","References":"<20250815113400.20623-1-laurent.pinchart@ideasonboard.com>\n\t<20250815113400.20623-3-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250815113400.20623-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35517,"web_url":"https://patchwork.libcamera.org/comment/35517/","msgid":"","date":"2025-08-19T15:20:42","subject":"Re: [PATCH v2 2/8] pipeline: ipu3: Drop unneeded forward\n\tdeclarations","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Fri, Aug 15, 2025 at 02:33:54PM +0300, Laurent Pinchart wrote:\n> Multiple classes are forward-declared in frames.h, without being used in\n> that header file. Drop the unneeded forward declarations.\n>\n> Signed-off-by: Laurent Pinchart \n\nIndeed\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/ipu3/frames.h | 4 ----\n> 1 file changed, 4 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h\n> index 1cabd0e64d6e..36a23b9b198e 100644\n> --- a/src/libcamera/pipeline/ipu3/frames.h\n> +++ b/src/libcamera/pipeline/ipu3/frames.h\n> @@ -19,11 +19,7 @@\n> namespace libcamera {\n>\n> class FrameBuffer;\n> -class IPAProxy;\n> -class PipelineHandler;\n> class Request;\n> -class V4L2VideoDevice;\n> -struct IPABuffer;\n>\n> class IPU3Frames\n> {\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FC61BEFBE\n\tfor ;\n\tTue, 19 Aug 2025 15:20:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 337C4692DC;\n\tTue, 19 Aug 2025 17:20:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BF12692CE\n\tfor ;\n\tTue, 19 Aug 2025 17:20:46 +0200 (CEST)","from ideasonboard.com (mob-5-90-52-92.net.vodafone.it [5.90.52.92])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44DBE1F0E;\n\tTue, 19 Aug 2025 17:19:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GC5FD7va\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755616788;\n\tbh=6Q3hlVFuw43uX5gYxW12xN6IL+IgXy3p3A2wqd8qX8o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GC5FD7vaeA+5BVS4Yyw55qqZufVgQunJA264p4A3YlXUojy265QDc5q2A6Gci3KVG\n\toEv/YqQMuZjKjmON1yA7YVEwDW3oc7dPBUJzMthewfU/w5IR7+7aEkhYnACf453Glg\n\tz8VuCPX/Q5XIhm/u7JziZp4whP48okIQYQMXowyM=","Date":"Tue, 19 Aug 2025 17:20:42 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Daniel =?utf-8?b?UsOha29z?=\n\t","Subject":"Re: [PATCH v2 2/8] pipeline: ipu3: Drop unneeded forward\n\tdeclarations","Message-ID":"","References":"<20250815113400.20623-1-laurent.pinchart@ideasonboard.com>\n\t<20250815113400.20623-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250815113400.20623-3-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]