{"id":24116,"url":"https://patchwork.libcamera.org/api/patches/24116/?format=json","web_url":"https://patchwork.libcamera.org/patch/24116/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250815102945.1602071-7-stefan.klug@ideasonboard.com>","date":"2025-08-15T10:29:26","name":"[v3,06/19] libipa: exposure_mode_helper: Remove unnecessary clamp calls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"36d9730852d9bb7af5ca36f4b2205dc00f2d3d2c","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24116/mbox/","series":[{"id":5382,"url":"https://patchwork.libcamera.org/api/series/5382/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5382","date":"2025-08-15T10:29:20","name":"Implement WDR algorithm","version":3,"mbox":"https://patchwork.libcamera.org/series/5382/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24116/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24116/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13DDBBDCC1\n\tfor ;\n\tFri, 15 Aug 2025 10:30:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C495569257;\n\tFri, 15 Aug 2025 12:30:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E722F6924E\n\tfor ;\n\tFri, 15 Aug 2025 12:30:10 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:83d1:ae5d:93a6:6837])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 1022019E5; \n\tFri, 15 Aug 2025 12:29:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vwwaCM2t\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755253756;\n\tbh=06I94kmfCwnIILz27wGUXDwEbIyIKSTAJqUP3stFNMs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vwwaCM2tvDEATOUJADWu5rHUnJkJ1YDXYtsAKL4zBxRX1Q0J/MovQYDxYGaHW0zTu\n\t5Q7H5NPYegLXCCk5IK3gmnsFvJ4jEpaGRRQZ4rLZaCfpwpVPfx5pA/PG+UGE+UMbEt\n\tUwZRaHWry92SJn6ir5NYqGOxp9VK1y1loD+INvhI=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tIsaac Scott ,\n\tDaniel Scally ","Subject":"[PATCH v3 06/19] libipa: exposure_mode_helper: Remove unnecessary\n\tclamp calls","Date":"Fri, 15 Aug 2025 12:29:26 +0200","Message-ID":"<20250815102945.1602071-7-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250815102945.1602071-1-stefan.klug@ideasonboard.com>","References":"<20250815102945.1602071-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Except for the first iteration of the loop and in the case of an empty\ngains_ vector, the values were run through clamp two times which is\nunnecessary. Remove that by clamping the initial value.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Isaac Scott \nReviewed-by: Daniel Scally \n\n---\n\nChanges in v3:\n- Collected tags\n---\n src/ipa/libipa/exposure_mode_helper.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp\nindex cd81503e07d6..21efc4356afa 100644\n--- a/src/ipa/libipa/exposure_mode_helper.cpp\n+++ b/src/ipa/libipa/exposure_mode_helper.cpp\n@@ -197,8 +197,8 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \t\treturn { minExposureTime_, minGain_, exposure / (minExposureTime_ * minGain_) };\n \n \tutils::Duration exposureTime;\n-\tdouble stageGain = 1.0;\n-\tdouble lastStageGain = 1.0;\n+\tdouble stageGain = clampGain(1.0);\n+\tdouble lastStageGain = stageGain;\n \tdouble gain;\n \n \tfor (unsigned int stage = 0; stage < gains_.size(); stage++) {\n@@ -215,7 +215,7 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \n \t\t/* Clamp the gain to lastStageGain and regulate exposureTime. */\n \t\tif (stageExposureTime * lastStageGain >= exposure) {\n-\t\t\texposureTime = clampExposureTime(exposure / clampGain(lastStageGain));\n+\t\t\texposureTime = clampExposureTime(exposure / lastStageGain);\n \t\t\tgain = clampGain(exposure / exposureTime);\n \n \t\t\treturn { exposureTime, gain, exposure / (exposureTime * gain) };\n@@ -223,7 +223,7 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \n \t\t/* Clamp the exposureTime to stageExposureTime and regulate gain. */\n \t\tif (stageExposureTime * stageGain >= exposure) {\n-\t\t\texposureTime = clampExposureTime(stageExposureTime);\n+\t\t\texposureTime = stageExposureTime;\n \t\t\tgain = clampGain(exposure / exposureTime);\n \n \t\t\treturn { exposureTime, gain, exposure / (exposureTime * gain) };\n@@ -239,7 +239,7 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \t * stages to use then the default stageGain of 1.0 is used so that\n \t * exposure time is maxed before gain is touched at all.\n \t */\n-\texposureTime = clampExposureTime(exposure / clampGain(stageGain));\n+\texposureTime = clampExposureTime(exposure / stageGain);\n \tgain = clampGain(exposure / exposureTime);\n \n \treturn { exposureTime, gain, exposure / (exposureTime * gain) };\n","prefixes":["v3","06/19"]}