{"id":24113,"url":"https://patchwork.libcamera.org/api/patches/24113/?format=json","web_url":"https://patchwork.libcamera.org/patch/24113/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250815102945.1602071-4-stefan.klug@ideasonboard.com>","date":"2025-08-15T10:29:23","name":"[v3,03/19] libipa: camera_sensor_helper: Add quantizeGain() function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"dc0c316d2c8fda477b2de45628057c9fcbc4c774","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24113/mbox/","series":[{"id":5382,"url":"https://patchwork.libcamera.org/api/series/5382/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5382","date":"2025-08-15T10:29:20","name":"Implement WDR algorithm","version":3,"mbox":"https://patchwork.libcamera.org/series/5382/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24113/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24113/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA989C3295\n\tfor ;\n\tFri, 15 Aug 2025 10:30:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52B0F6925B;\n\tFri, 15 Aug 2025 12:30:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59D1C6925F\n\tfor ;\n\tFri, 15 Aug 2025 12:30:01 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:83d1:ae5d:93a6:6837])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7302E6A8;\n\tFri, 15 Aug 2025 12:29:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mb7a5oX5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755253746;\n\tbh=mWtUqJOJC7TVcOpemCa1QvnrB5NPTO8ItDL14bBuGig=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mb7a5oX5uGOqV6RT1wKVq7ZRuQh7ixWqIfWL6kKQqYBrgPjvt7qVFr378gkItb/11\n\tNhfiZBsvrjGf0DqjN8tKzcFKreNbyDks9Csw8KniUhSUlvx3l3eiHq+Rsoz22YTsFO\n\tchMCAg0P+67fBybYfDL5pJel994WxtczwgDEaJGU=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tIsaac Scott ,\n\tDaniel Scally ","Subject":"[PATCH v3 03/19] libipa: camera_sensor_helper: Add quantizeGain()\n\tfunction","Date":"Fri, 15 Aug 2025 12:29:23 +0200","Message-ID":"<20250815102945.1602071-4-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250815102945.1602071-1-stefan.klug@ideasonboard.com>","References":"<20250815102945.1602071-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a small utility function that calculates the quantized gain that\ngets applied by a sensor when the gain code is set to gainCode(gain).\nThis is needed by algorithms to calculate a digital correction gain that\ngets applied to mitigate the error introduce by quantization.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Isaac Scott \nReviewed-by: Daniel Scally \n\n---\n\nChanges in v3:\n- Remove virtual from quantizeGain()\n- Improved documentation\n- Collected tags\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 23 +++++++++++++++++++++++\n src/ipa/libipa/camera_sensor_helper.h | 1 +\n 2 files changed, 24 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex dcd69d9f2bbb..a490161faf4c 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -131,6 +131,29 @@ double CameraSensorHelper::gain(uint32_t gainCode) const\n \t}\n }\n \n+/**\n+ * \\brief Quantize the given gain value\n+ * \\param[in] _gain The real gain\n+ * \\param[out] quantizationGain The gain that is lost due to quantization\n+ *\n+ * This function returns the actual gain that is applied when the sensors gain\n+ * is set to gainCode(gain).\n+ *\n+ * It shall be guaranteed that gainCode(gain) == gainCode(quantizeGain(gain)).\n+ *\n+ * If \\a quantizationGain is provided it is filled with the gain that must be\n+ * applied to correct the losses due to quantization.\n+ *\n+ * \\return The quantized real gain\n+ */\n+double CameraSensorHelper::quantizeGain(double _gain, double *quantizationGain) const\n+{\n+\tdouble g = gain(gainCode(_gain));\n+\tif (quantizationGain)\n+\t\t*quantizationGain = _gain / g;\n+\treturn g;\n+}\n+\n /**\n * \\struct CameraSensorHelper::AnalogueGainLinear\n * \\brief Analogue gain constants for the linear gain model\ndiff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\nindex a9300a64f1e7..bd3d0beec77f 100644\n--- a/src/ipa/libipa/camera_sensor_helper.h\n+++ b/src/ipa/libipa/camera_sensor_helper.h\n@@ -29,6 +29,7 @@ public:\n \tstd::optional blackLevel() const { return blackLevel_; }\n \tvirtual uint32_t gainCode(double gain) const;\n \tvirtual double gain(uint32_t gainCode) const;\n+\tdouble quantizeGain(double gain, double *quantizationGain) const;\n \n protected:\n \tstruct AnalogueGainLinear {\n","prefixes":["v3","03/19"]}