[{"id":35711,"web_url":"https://patchwork.libcamera.org/comment/35711/","msgid":"<175706898312.1787083.6887388602918939206@neptunite.rasen.tech>","date":"2025-09-05T10:43:03","subject":"Re: [PATCH v3 02/19] tuning: rksip1: Add a static Compress entry","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-08-15 19:29:22)\n> Add a static Compress entry that gets added by default.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Isaac Scott \n> Reviewed-by: Daniel Scally \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v3:\n> - Collected tags\n> ---\n> utils/tuning/rkisp1.py | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index 207b717a029c..179d920c05df 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -27,6 +27,7 @@ awb = AWBRkISP1(debug=[lt.Debug.Plot])\n> blc = StaticModule('BlackLevelCorrection')\n> ccm = CCMRkISP1(debug=[lt.Debug.Plot])\n> color_processing = StaticModule('ColorProcessing')\n> +compress = StaticModule('Compress')\n> filter = StaticModule('Filter')\n> gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2})\n> lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> @@ -49,13 +50,14 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> lux = LuxRkISP1(debug=[lt.Debug.Plot])\n> \n> tuner = lt.Tuner('RkISP1')\n> -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])\n> +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress])\n> tuner.set_input_parser(YamlParser())\n> tuner.set_output_formatter(YamlOutput())\n> \n> # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.\n> +# Compress is parameterized by others, so add it at the end.\n> tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,\n> - filter, gamma_out, lsc])\n> + filter, gamma_out, lsc, compress])\n> \n> if __name__ == '__main__':\n> sys.exit(tuner.run(sys.argv))\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03D8DC328C\n\tfor ;\n\tFri, 5 Sep 2025 10:43:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87C0869361;\n\tFri, 5 Sep 2025 12:43:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32F116935E\n\tfor ;\n\tFri, 5 Sep 2025 12:43:09 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:dbfb:387c:7405:52bc])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 38CA41129; \n\tFri, 5 Sep 2025 12:41:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mRRHuJVN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757068919;\n\tbh=vI48Ecgk94q3io4d+7H+gYeEx1RoA+eyJ5pnQgT2iP0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mRRHuJVNekJVQVdGWRRb7P4TCw88fqhHDO3Rf/fk6dVl/cs/QA0EvBDmHk7nT85df\n\tdAjxGS7hQVbg/zVbjc1QBZO1/8u4lx0uS2c9uWdVpG7d4GsG6Jimu17zn3BgavklQ3\n\txCOFLGnOKaNEECcArIO9UYcMpS5CiJUMsFDomDuU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250815102945.1602071-3-stefan.klug@ideasonboard.com>","References":"<20250815102945.1602071-1-stefan.klug@ideasonboard.com>\n\t<20250815102945.1602071-3-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v3 02/19] tuning: rksip1: Add a static Compress entry","From":"Paul Elder ","Cc":"Stefan Klug ,\n\tIsaac Scott ,\n\tDaniel Scally ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 05 Sep 2025 19:43:03 +0900","Message-ID":"<175706898312.1787083.6887388602918939206@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]