{"id":24105,"url":"https://patchwork.libcamera.org/api/patches/24105/?format=json","web_url":"https://patchwork.libcamera.org/patch/24105/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250814151420.2119927-1-barnabas.pocze@ideasonboard.com>","date":"2025-08-14T15:14:20","name":"[v1] apps: common: options: Avoid copying in range based for loop","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b7b682b221d05c8a01a129d9727f5249c7abc234","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24105/mbox/","series":[{"id":5377,"url":"https://patchwork.libcamera.org/api/series/5377/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5377","date":"2025-08-14T15:14:20","name":"[v1] apps: common: options: Avoid copying in range based for loop","version":1,"mbox":"https://patchwork.libcamera.org/series/5377/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24105/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24105/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AAC7BEFBE\n\tfor ;\n\tThu, 14 Aug 2025 15:14:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59A7169247;\n\tThu, 14 Aug 2025 17:14:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 558E861444\n\tfor ;\n\tThu, 14 Aug 2025 17:14:24 +0200 (CEST)","from pb-laptop.local (185.221.141.188.nat.pool.zt.hu\n\t[185.221.141.188])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3CCC6DF\n\tfor ;\n\tThu, 14 Aug 2025 17:13:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MFJGeLEw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755184410;\n\tbh=TRNkzEc8aaRhVs1loGsMIVZXgXUJucrVC2vi9qurPnE=;\n\th=From:To:Subject:Date:From;\n\tb=MFJGeLEwjFw4qgcHvTc3Vn4jnfdlx0EnDSJXO4hNx603twKNELS8OERIcye5os8Hh\n\tIb+N54fG2eQn0y3FlaovBwqisvzPI3C2S6StKv1CUhrKZovhMXjrRJkhqBWeKPFfGh\n\tmG9CM+psUQx/034vNor10jkN/NJReEZk+6bfzcn0=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] apps: common: options: Avoid copying in range based for\n\tloop","Date":"Thu, 14 Aug 2025 17:14:20 +0200","Message-ID":"<20250814151420.2119927-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The copy can trigger `-Wrange-loop-construct`, so use a reference\nto avoid the warning.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/common/options.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/apps/common/options.cpp b/src/apps/common/options.cpp\nindex cae193cc4..b4ea1afe2 100644\n--- a/src/apps/common/options.cpp\n+++ b/src/apps/common/options.cpp\n@@ -887,7 +887,7 @@ OptionsParser::Options OptionsParser::parse(int argc, char **argv)\n \n \tshortOptions[ids++] = ':';\n \n-\tfor (const auto [opt, option] : optionsMap_) {\n+\tfor (const auto &[opt, option] : optionsMap_) {\n \t\tif (option->hasShortOption()) {\n \t\t\tshortOptions[ids++] = opt;\n \t\t\tif (option->argument != ArgumentNone)\n","prefixes":["v1"]}