[{"id":35390,"web_url":"https://patchwork.libcamera.org/comment/35390/","msgid":"<175510658138.1721288.7315212640284674658@ping.linuxembedded.co.uk>","date":"2025-08-13T17:36:21","subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2025-08-13 18:02:40)\n> The statistics in software ISP is computed basically over the whole\n> image area, although only on part of the pixels. It is not necessary to\n> cover the whole image area, it's sufficient to compute the statistics\n> let's say over the central area of 2/3 of the image width and height,\n> which should be both sufficient and faster. The speedup is not that\n> important with the CPU implementation but it may save CPU work\n> more noticeably with GPU debayering implementation.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/software_isp/debayer_cpu.cpp | 9 +++++++--\n> src/libcamera/software_isp/debayer_egl.cpp | 7 +++++--\n> 2 files changed, 12 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\n> index e56492848..a7d6e4fd8 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.cpp\n> +++ b/src/libcamera/software_isp/debayer_cpu.cpp\n> @@ -526,8 +526,13 @@ int DebayerCpu::configure(const StreamConfiguration &inputCfg,\n> window_.width = outputCfg.size.width;\n> window_.height = outputCfg.size.height;\n> \n> - /* Don't pass x,y since process() already adjusts src before passing it */\n> - stats_->setWindow(Rectangle(window_.size()));\n> + /*\n> + * Don't pass x,y from window_ since process() already adjusts for it.\n> + * But crop the window to 2/3 of its width and height for speedup.\n> + * The speedup is more important with GPU than with CPU ISP; we want the\n> + * same implementation on both.\n> + */\n> + stats_->setWindow((window_.size() * 2 / 3).centeredTo(window_.center()));\n> \n> /* pad with patternSize.Width on both left and right side */\n> lineBufferPadding_ = inputConfig_.patternSize.width * inputConfig_.bpp / 8;\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 9ec966608..057ad1c38 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -393,8 +393,11 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> window_.width = outputCfg.size.width;\n> window_.height = outputCfg.size.height;\n> \n> - /* Don't pass x,y since process() already adjusts src before passing it */\n> - stats_->setWindow(Rectangle(window_.size()));\n> + /*\n> + * Don't pass x,y from window_ since process() already adjusts for it.\n> + * But crop the window to 2/3 of its width and height for speedup.\n> + */\n> + stats_->setWindow((window_.size() * 2 / 3).centeredTo(window_.center()));\n> \n> LOG(Debayer, Debug) << \"Input width \" << inputCfg.size.width << \" height \" << inputCfg.size.height;\n> LOG(Debayer, Debug) << \"Output width \" << outputCfg.size.width << \" height \" << outputCfg.size.height;\n> -- \n> 2.50.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5FABBEFBE\n\tfor ;\n\tWed, 13 Aug 2025 17:36:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 63F8369251;\n\tWed, 13 Aug 2025 19:36:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC1AE6922C\n\tfor ;\n\tWed, 13 Aug 2025 19:36:24 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D2A443DC;\n\tWed, 13 Aug 2025 19:35:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CVwXPqGt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755106530;\n\tbh=gBKOmfs+CkEOMlrE8uI5UQOGRITYhgwf4Vzim+Li2wc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=CVwXPqGtUMPBiW9XWEitInSgnDCIMUW4KgMJaEtM50u5a6RUY0YoQ4NMc8bvu2Sz0\n\tTo8MWoiZVEENxKDF7jAoT9osa72sKObcmXMAqVASFYLwVh0hlAkZZjleLL6K4duyJt\n\t4rzBsZ+RaFGhiqWCncjxrB1YdNJlKVdVcqODIyrA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250813170240.50173-2-mzamazal@redhat.com>","References":"<20250813170240.50173-1-mzamazal@redhat.com>\n\t<20250813170240.50173-2-mzamazal@redhat.com>","Subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","From":"Kieran Bingham ","Cc":"Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= , Laurent Pinchart\n\t","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Wed, 13 Aug 2025 18:36:21 +0100","Message-ID":"<175510658138.1721288.7315212640284674658@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35402,"web_url":"https://patchwork.libcamera.org/comment/35402/","msgid":"<175516704065.1721288.14615391055831778603@ping.linuxembedded.co.uk>","date":"2025-08-14T10:24:00","subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hans, Bryan,\n\nQuoting Kieran Bingham (2025-08-13 18:36:21)\n> Quoting Milan Zamazal (2025-08-13 18:02:40)\n> > The statistics in software ISP is computed basically over the whole\n> > image area, although only on part of the pixels. It is not necessary to\n> > cover the whole image area, it's sufficient to compute the statistics\n> > let's say over the central area of 2/3 of the image width and height,\n> > which should be both sufficient and faster. The speedup is not that\n> > important with the CPU implementation but it may save CPU work\n> > more noticeably with GPU debayering implementation.\n> > \n> > Signed-off-by: Milan Zamazal \n> \n\nCould you test/review this please?\n\nIf everyone's happy in softisp I can merge this.\n\n-\nKieran\n\n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/libcamera/software_isp/debayer_cpu.cpp | 9 +++++++--\n> > src/libcamera/software_isp/debayer_egl.cpp | 7 +++++--\n> > 2 files changed, 12 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\n> > index e56492848..a7d6e4fd8 100644\n> > --- a/src/libcamera/software_isp/debayer_cpu.cpp\n> > +++ b/src/libcamera/software_isp/debayer_cpu.cpp\n> > @@ -526,8 +526,13 @@ int DebayerCpu::configure(const StreamConfiguration &inputCfg,\n> > window_.width = outputCfg.size.width;\n> > window_.height = outputCfg.size.height;\n> > \n> > - /* Don't pass x,y since process() already adjusts src before passing it */\n> > - stats_->setWindow(Rectangle(window_.size()));\n> > + /*\n> > + * Don't pass x,y from window_ since process() already adjusts for it.\n> > + * But crop the window to 2/3 of its width and height for speedup.\n> > + * The speedup is more important with GPU than with CPU ISP; we want the\n> > + * same implementation on both.\n> > + */\n> > + stats_->setWindow((window_.size() * 2 / 3).centeredTo(window_.center()));\n> > \n> > /* pad with patternSize.Width on both left and right side */\n> > lineBufferPadding_ = inputConfig_.patternSize.width * inputConfig_.bpp / 8;\n> > diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> > index 9ec966608..057ad1c38 100644\n> > --- a/src/libcamera/software_isp/debayer_egl.cpp\n> > +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> > @@ -393,8 +393,11 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> > window_.width = outputCfg.size.width;\n> > window_.height = outputCfg.size.height;\n> > \n> > - /* Don't pass x,y since process() already adjusts src before passing it */\n> > - stats_->setWindow(Rectangle(window_.size()));\n> > + /*\n> > + * Don't pass x,y from window_ since process() already adjusts for it.\n> > + * But crop the window to 2/3 of its width and height for speedup.\n> > + */\n> > + stats_->setWindow((window_.size() * 2 / 3).centeredTo(window_.center()));\n> > \n> > LOG(Debayer, Debug) << \"Input width \" << inputCfg.size.width << \" height \" << inputCfg.size.height;\n> > LOG(Debayer, Debug) << \"Output width \" << outputCfg.size.width << \" height \" << outputCfg.size.height;\n> > -- \n> > 2.50.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E148BDCC1\n\tfor ;\n\tThu, 14 Aug 2025 10:24:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AE2D69254;\n\tThu, 14 Aug 2025 12:24:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 168A261444\n\tfor ;\n\tThu, 14 Aug 2025 12:24:03 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D11627E6;\n\tThu, 14 Aug 2025 12:23:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fPPwQcM/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755166988;\n\tbh=t6PzrSEyY0Az9/mvvIgdNv7eA8/XGO/GTs6YyVtQZT0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fPPwQcM/djnAN+ALoM3JzsWPpapOrMRWLFgswx/obwCLgzLjjhxmrEBxRDw/f9WpC\n\tgzUFCjW2hPCw5ruHTNlSwSIjzW85eTIyjI+8Cbm4r7UzWSXpQCUjIbHN+ij3dgLxEh\n\tjesJn1mPo3mBz+dZpT2t1VDTOF/T1K/kPWKXnC7s=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<175510658138.1721288.7315212640284674658@ping.linuxembedded.co.uk>","References":"<20250813170240.50173-1-mzamazal@redhat.com>\n\t<20250813170240.50173-2-mzamazal@redhat.com>\n\t<175510658138.1721288.7315212640284674658@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","From":"Kieran Bingham ","Cc":"Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= , Laurent Pinchart\n\t","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org,\n\tHans de Goede ,\n\t\"Bryan O'Donoghue\" , ","Date":"Thu, 14 Aug 2025 11:24:00 +0100","Message-ID":"<175516704065.1721288.14615391055831778603@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35403,"web_url":"https://patchwork.libcamera.org/comment/35403/","msgid":"","date":"2025-08-14T11:12:24","subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 14/08/2025 11:24, Kieran Bingham wrote:\n> Hans, Bryan,\n> \n> Quoting Kieran Bingham (2025-08-13 18:36:21)\n>> Quoting Milan Zamazal (2025-08-13 18:02:40)\n>>> The statistics in software ISP is computed basically over the whole\n>>> image area, although only on part of the pixels. It is not necessary to\n>>> cover the whole image area, it's sufficient to compute the statistics\n>>> let's say over the central area of 2/3 of the image width and height,\n>>> which should be both sufficient and faster. The speedup is not that\n>>> important with the CPU implementation but it may save CPU work\n>>> more noticeably with GPU debayering implementation.\n>>>\n>>> Signed-off-by: Milan Zamazal \n>>\n> \n> Could you test/review this please?\n> \n> If everyone's happy in softisp I can merge this.\nYou'll have to cut out the egl part as its not upstream yet but, \napplying to the GPUISP branch it seems to work well.\n\nCPU fps is about the same, gpu FPS hits line rate and keep in mind this \nis on a debug build too.\n\nAlso seems to improve the flickering bug I've been seeing because the \narea of interest is the center of the image instead of the edges.\n\nBefore:\nhttps://drive.google.com/file/d/19JGJSCjTI-lcu_zcs1qmu7K5Y9aktEoG/view?usp=drive_link\n\nAfter:\nhttps://drive.google.com/file/d/1A_niOE6cKC97N3IkvH8iw4JB9qyjGj5l/view?usp=sharing\n\nReviewed-by: Bryan O'Donoghue \nTested-by: Bryan O'Donoghue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 446BFBEFBE\n\tfor ;\n\tThu, 14 Aug 2025 11:12:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37AC369254;\n\tThu, 14 Aug 2025 13:12:28 +0200 (CEST)","from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F15E061444\n\tfor ;\n\tThu, 14 Aug 2025 13:12:26 +0200 (CEST)","by mail-wr1-x432.google.com with SMTP id\n\tffacd0b85a97d-3b9e415a68eso412441f8f.2\n\tfor ;\n\tThu, 14 Aug 2025 04:12:26 -0700 (PDT)","from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3b79c48105csm50828694f8f.64.2025.08.14.04.12.25\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 14 Aug 2025 04:12:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"muIAcTFo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755169946; x=1755774746;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=DtjeIq7r7cCST//BgVQCOtQQDFBy8d+avrVDoKcULck=;\n\tb=muIAcTFojzXdAkBX1FZ+Hne/S//lvH6EG0AiFBFzCgeadU4o9bJ7NXkZ064bK9M758\n\to8120jTn3k6g71zP3knmAPBc3V//jonocVc/S4sq9dN9yjR12Vj8HikOyETjnA9VUtMJ\n\tvx9axrFE/9rgCo+MeAqkXM6I+9fh0qB156UI+C+RsKOAefROI0PymXBqrHBCqAnhCiSs\n\t0Dvh12fKaqc1Ow09O1AHZjXFouxOSjm6cBsB4pkY9I5c24RlrzKfdUmHMlg0Yv3Uff5u\n\t0s5naW2s7ZnA3h/MCQTLnNI0FNJWBslBlDbfs+Gj7Au27H/kKcEYS8NpSLuvb6ZTv+nX\n\t3gjg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755169946; x=1755774746;\n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=DtjeIq7r7cCST//BgVQCOtQQDFBy8d+avrVDoKcULck=;\n\tb=So9OHoOq1/But7pSAChRCsGuoedJgB9pGKyVwWSaGEfqf30RihD6lpBoPAdOJUKVf5\n\tIc4hGRZDGqwjg4TbQFDfYsJWoTa8PTwoOi+nW1VIni3fu5mF+cbcpF3mC+bL4jTQ7qyW\n\toLmj1t+5iVerApIlTudWf2NH8vRmE9L8LjAO+pcz3JoQyalv90X15LrP6c0Hx2am2pyg\n\tRsvsG5IaAemtc+BS/PdXeAqdpD2MFepv8xE/Lj1rhnhq5iVAIkWTrLD5SmUDjJY8Mh8a\n\tJh+IYdKpK1DZ68xpmGk513JWgE7QK8Su63JGWc9N0Zme0rIN3Uy2ecuoeiKBU0qw3+ap\n\tKz6w==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVvZjvTZjX03Ar8WUv05nYip11ANVTNNGcmOMBLh9PRiZfX8mEbJLEWEiVB74ow/CGOtU5rL70fsDt9BZdLeeY=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YxwcDst013zB6iNM5U3qxsENxZ4hxMM4TuUOwdjAFtg7pofbirV\n\tRB03Q7K4qiDGeaeW/6a0HRLequ9yBWuiFq4uAUGek8CD20wJ6W6P1YzOqua326dfX3M=","X-Gm-Gg":"ASbGncvGwjWtVHENyB+vKuuL4o7ncEU7yBtIf1i48k0QrTRpPJdk/7lpN9/5j1zKTlt\n\tRE/g0rIJQOTpgEkYMpOYJ+2L5lolvXDCz7quHBufMSAUzuBLiTd6UXajJPDRphgXRFGAT6XURbL\n\tRoeqJFPEZZd8CH5ynGo6TJ4fn5xqBWBSCaITbXQDO8URJGooEtj7UrdcyNFVLinROrIvChk2XYE\n\tjnvWK4JLcf4ABHz2VqVAqLP4idPtlVmx34hFE3+tVq98H7yHqg1gP8dZ97lxF6s+A981nr+sP3H\n\teEQ1OPeaudKsusHIr17+WwY4K/2ueucDthScxsKKKrVDjvc9dk3JaGwOebwQ857ju1hM5jCevJE\n\t0uGxiXqHBcutt5GOCTpUw/qfvC8E1Q77qn1twtCk+gUGjKzJ2GZIpmg4NEKyyrYQ/EoqX/tsiKQ\n\t==","X-Google-Smtp-Source":"AGHT+IHHsDq+utoTAyIHQKAmMA32dWfxApoOsuJN4/G9WxEq0UrbG88/IwJgosE5dRBjYEmgVTH3OQ==","X-Received":"by 2002:a05:6000:220f:b0:3a6:d92d:9f7c with SMTP id\n\tffacd0b85a97d-3b9e4158b68mr2591977f8f.9.1755169946209; \n\tThu, 14 Aug 2025 04:12:26 -0700 (PDT)","Message-ID":"","Date":"Thu, 14 Aug 2025 12:12:24 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","To":"Kieran Bingham ,\n\tMilan Zamazal ,\n\tlibcamera-devel@lists.libcamera.org, \n\tHans de Goede ,\n\tBryan O'Donoghue ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","References":"<20250813170240.50173-1-mzamazal@redhat.com>\n\t<20250813170240.50173-2-mzamazal@redhat.com>\n\t<175510658138.1721288.7315212640284674658@ping.linuxembedded.co.uk>\n\t\n\t<175516704065.1721288.14615391055831778603@ping.linuxembedded.co.uk>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<175516704065.1721288.14615391055831778603@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35404,"web_url":"https://patchwork.libcamera.org/comment/35404/","msgid":"","date":"2025-08-14T11:16:21","subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 14/08/2025 12:12, Bryan O'Donoghue wrote:\n> On 14/08/2025 11:24, Kieran Bingham wrote:\n>> Hans, Bryan,\n>>\n>> Quoting Kieran Bingham (2025-08-13 18:36:21)\n>>> Quoting Milan Zamazal (2025-08-13 18:02:40)\n>>>> The statistics in software ISP is computed basically over the whole\n>>>> image area, although only on part of the pixels.  It is not \n>>>> necessary to\n>>>> cover the whole image area, it's sufficient to compute the statistics\n>>>> let's say over the central area of 2/3 of the image width and height,\n>>>> which should be both sufficient and faster.  The speedup is not that\n>>>> important with the CPU implementation but it may save CPU work\n>>>> more noticeably with GPU debayering implementation.\n>>>>\n>>>> Signed-off-by: Milan Zamazal \n>>>\n>>\n>> Could you test/review this please?\n>>\n>> If everyone's happy in softisp I can merge this.\n> You'll have to cut out the egl part as its not upstream yet but, \n> applying to the GPUISP branch it seems to work well.\n> \n> CPU fps is about the same, gpu FPS hits line rate and keep in mind this \n> is on a debug build too.\n> \n> Also seems to improve the flickering bug I've been seeing because the \n> area of interest is the center of the image instead of the edges.\n> \n> Before:\n> https://drive.google.com/file/d/19JGJSCjTI-lcu_zcs1qmu7K5Y9aktEoG/view? \n> usp=drive_link\n> \n> After:\n> https://drive.google.com/file/d/1A_niOE6cKC97N3IkvH8iw4JB9qyjGj5l/view? \n> usp=sharing\n> \n> Reviewed-by: Bryan O'Donoghue \n> Tested-by: Bryan O'Donoghue \n\nhttps://gitlab.freedesktop.org/camera/libcamera-softisp/-/tree/origin-master+whole-frame-swtats-v2-gpuisp-v1n?ref_type=heads\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F320EBEFBE\n\tfor ;\n\tThu, 14 Aug 2025 11:16:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18A2F69247;\n\tThu, 14 Aug 2025 13:16:25 +0200 (CEST)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A8B3D61444\n\tfor ;\n\tThu, 14 Aug 2025 13:16:23 +0200 (CEST)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-45a1b00797dso5442475e9.0\n\tfor ;\n\tThu, 14 Aug 2025 04:16:23 -0700 (PDT)","from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45a1c74876csm17468335e9.14.2025.08.14.04.16.22\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 14 Aug 2025 04:16:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"xFQKjEAy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755170183; x=1755774983;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=YDntdKRpaZJO+/Wvp9Dre2uY1o3ajUazXpuJJ9yGbek=;\n\tb=xFQKjEAyorL/52RolKicWW/A0+BTo6F3+K0+XCCJp+Vh0cyw9/lEAda5F52flJK2yw\n\taLb4PcRftxh8Y5GYDwTYs9nFMdZtqGguVRGtWNo74eSVh+CCi0VLuMhhT7nZYo1Ot4yo\n\t0/EvuQMOMBTNwJAWDynXo+4DIJUs+lcJFNF0qlhGwBv3K9lEu2FVUIJtKTEPC/FmjSaM\n\tCVbEHbK1kYwOgolnREr16o/pHsnA5iOkMfBzzvlBYheh5+BPRN3eWMuRwIRRDAmIGJNL\n\tqBU1R0/hvnzXWRRRTLT7jWq1izZd5wpSWdO5zcU91JJBRZVfBrLZX4JJAT/LTqciHnAn\n\tP2XQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755170183; x=1755774983;\n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=YDntdKRpaZJO+/Wvp9Dre2uY1o3ajUazXpuJJ9yGbek=;\n\tb=XNf8GBDvs960EzhbU4eng4FuQPf4I6aNio3IeGRmiWQv7QCwvEsULOm4rAY2GT/bSF\n\thRyWJNG+/fDZq+oZzkiN0LnS8EZKWFWcMkT+8zewoCY6VU2mj0rx+xSlHe5qyJrYozf3\n\t27Mku7Mb3bn1pIIR6UNDtx1pOUDlEEJIW7C+P0zIDQNrXgTZEnVG3bcXpNkzc1ZT8IBc\n\tAh5G+NCDeRYuipc0BJOg88rctlUCYTSr7pKo7nXZkzVADxME0nLsuZipqpEA0XxipS14\n\tmADXWTBK1SSnYKCH6EjpMWHRZjopX73VKGalVhysR+QjJmPOlzX5V14TP27XcaYA9HZE\n\txy5A==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCUdRhhBKMkV2es2+IHln+mPE4c6SSuDvdh7ACujuGVoOsBKmnynNQkwMW9s5RTjUZyIXyBM5sZDylum3cMYZXc=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwOJiqAEc4H0SU0B9lNEjkLXQteteSumWaPD/3oUfrjB58k6o+D\n\t2JVM3//D/pk6qkOpDhfWG4F2NI0xne0cgJd3+/5n8g5eIrM2Fvx+kiSYhLFSXP+B3Go=","X-Gm-Gg":"ASbGncvBmzffsUQXWFg4frX/G5uD/knOvk9h9UokOkjd3BLSWWlLdwz6B3FrQD5Jlgy\n\toXmVuC2Fgy1n7ppHDerv+BsI6xuPzrPkfdZZ4S3eb7hS9ADmLlrz3vx7FRnrBTwPr1EZhHzbj6k\n\tRI3A95XSfGGtF/YuVZbH5TJ7oiaRD5/8O3KJh/7uZwdy4iCKPkhJZCN6aGs1XjxJmKzoETaUhXI\n\t/IlCAPKn/SfGLkYx6eWKdDjPqvcAqb9lb8CCBItSPARPPbWdL+j/hMEq896Ga7ki9ZZRDlgD7sk\n\t6XEFmgT8aeB+YDmCppLrXkFtG++zc4eQBvkZR2OrV+oQfBLb3KZTE+j5lxFIvnIjzuKNROwrmj7\n\tBJRjrMrvKP2NLKMrMbcmnnEXczlKIR0hY5apjQZtmMiSk7rMWsfG67ZVSk3AarLA=","X-Google-Smtp-Source":"AGHT+IEbtAT7g82/lHbfGn2ZEXraMD355nlnJnx3km7yyxE9MlLTALSzgq5ao2dd6LYrv5vfg+flhg==","X-Received":"by 2002:a05:600c:458a:b0:459:d3ce:2cbd with SMTP id\n\t5b1f17b1804b1-45a1b61bdcamr22514715e9.13.1755170182989; \n\tThu, 14 Aug 2025 04:16:22 -0700 (PDT)","Message-ID":"","Date":"Thu, 14 Aug 2025 12:16:21 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","To":"Kieran Bingham ,\n\tMilan Zamazal ,\n\tlibcamera-devel@lists.libcamera.org, Hans de Goede ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","References":"<20250813170240.50173-1-mzamazal@redhat.com>\n\t<20250813170240.50173-2-mzamazal@redhat.com>\n\t<175510658138.1721288.7315212640284674658@ping.linuxembedded.co.uk>\n\t\n\t<175516704065.1721288.14615391055831778603@ping.linuxembedded.co.uk>\n\t","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35475,"web_url":"https://patchwork.libcamera.org/comment/35475/","msgid":"<175551667949.560048.16259302966988023857@ping.linuxembedded.co.uk>","date":"2025-08-18T11:31:19","subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bryan O'Donoghue (2025-08-14 12:16:21)\n> On 14/08/2025 12:12, Bryan O'Donoghue wrote:\n> > On 14/08/2025 11:24, Kieran Bingham wrote:\n> >> Hans, Bryan,\n> >>\n> >> Quoting Kieran Bingham (2025-08-13 18:36:21)\n> >>> Quoting Milan Zamazal (2025-08-13 18:02:40)\n> >>>> The statistics in software ISP is computed basically over the whole\n> >>>> image area, although only on part of the pixels.  It is not \n> >>>> necessary to\n> >>>> cover the whole image area, it's sufficient to compute the statistics\n> >>>> let's say over the central area of 2/3 of the image width and height,\n> >>>> which should be both sufficient and faster.  The speedup is not that\n> >>>> important with the CPU implementation but it may save CPU work\n> >>>> more noticeably with GPU debayering implementation.\n> >>>>\n> >>>> Signed-off-by: Milan Zamazal \n> >>>\n> >>\n> >> Could you test/review this please?\n> >>\n> >> If everyone's happy in softisp I can merge this.\n> > You'll have to cut out the egl part as its not upstream yet but, \n> > applying to the GPUISP branch it seems to work well.\n\nAha of course.\n\nMilan, do you want this patch merged with just the CPU part ?\n\n--\nKieran\n\n> > \n> > CPU fps is about the same, gpu FPS hits line rate and keep in mind this \n> > is on a debug build too.\n> > \n> > Also seems to improve the flickering bug I've been seeing because the \n> > area of interest is the center of the image instead of the edges.\n> > \n> > Before:\n> > https://drive.google.com/file/d/19JGJSCjTI-lcu_zcs1qmu7K5Y9aktEoG/view? \n> > usp=drive_link\n> > \n> > After:\n> > https://drive.google.com/file/d/1A_niOE6cKC97N3IkvH8iw4JB9qyjGj5l/view? \n> > usp=sharing\n> > \n> > Reviewed-by: Bryan O'Donoghue \n> > Tested-by: Bryan O'Donoghue \n> \n> https://gitlab.freedesktop.org/camera/libcamera-softisp/-/tree/origin-master+whole-frame-swtats-v2-gpuisp-v1n?ref_type=heads\n> \n> ---\n> bod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 166A1BEFBE\n\tfor ;\n\tMon, 18 Aug 2025 11:31:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0044769261;\n\tMon, 18 Aug 2025 13:31:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FEF969257\n\tfor ;\n\tMon, 18 Aug 2025 13:31:22 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F264A17D1;\n\tMon, 18 Aug 2025 13:30:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PLFf7QnI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755516625;\n\tbh=QhY0k8epG+a9SWVsabF8RlZudvsITNdwQQqRXviSSOE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=PLFf7QnIBcEcaUqdF/m7mD4YawQpR3UUfqLlJge9R80bJcPFNApQ7yGMv357VGIaC\n\tTfB8y74XQi9G3mAEFkGHWARKyUjKEwzoPh6JnKXXFtK3gNFzMJPq+dXckzezNz5OL/\n\tvP630PsGLI4xzedxkbP0MtAlnRXOefKLZSW/6AK4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250813170240.50173-1-mzamazal@redhat.com>\n\t<20250813170240.50173-2-mzamazal@redhat.com>\n\t<175510658138.1721288.7315212640284674658@ping.linuxembedded.co.uk>\n\t\n\t<175516704065.1721288.14615391055831778603@ping.linuxembedded.co.uk>\n\t\n\t","Subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","From":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","To":"Bryan O'Donoghue ,\n\tHans de Goede ,\n\tMilan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Mon, 18 Aug 2025 12:31:19 +0100","Message-ID":"<175551667949.560048.16259302966988023857@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35476,"web_url":"https://patchwork.libcamera.org/comment/35476/","msgid":"<175551672761.560048.12145300054102393852@ping.linuxembedded.co.uk>","date":"2025-08-18T11:32:07","subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2025-08-18 12:31:19)\n> Quoting Bryan O'Donoghue (2025-08-14 12:16:21)\n> > On 14/08/2025 12:12, Bryan O'Donoghue wrote:\n> > > On 14/08/2025 11:24, Kieran Bingham wrote:\n> > >> Hans, Bryan,\n> > >>\n> > >> Quoting Kieran Bingham (2025-08-13 18:36:21)\n> > >>> Quoting Milan Zamazal (2025-08-13 18:02:40)\n> > >>>> The statistics in software ISP is computed basically over the whole\n> > >>>> image area, although only on part of the pixels.  It is not \n> > >>>> necessary to\n> > >>>> cover the whole image area, it's sufficient to compute the statistics\n> > >>>> let's say over the central area of 2/3 of the image width and height,\n> > >>>> which should be both sufficient and faster.  The speedup is not that\n> > >>>> important with the CPU implementation but it may save CPU work\n> > >>>> more noticeably with GPU debayering implementation.\n> > >>>>\n> > >>>> Signed-off-by: Milan Zamazal \n> > >>>\n> > >>\n> > >> Could you test/review this please?\n> > >>\n> > >> If everyone's happy in softisp I can merge this.\n> > > You'll have to cut out the egl part as its not upstream yet but, \n> > > applying to the GPUISP branch it seems to work well.\n> \n> Aha of course.\n> \n> Milan, do you want this patch merged with just the CPU part ?\n>\n\nWhich given the commit title - almost sounds a bit redundant ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A289BEFBE\n\tfor ;\n\tMon, 18 Aug 2025 11:32:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 262C269261;\n\tMon, 18 Aug 2025 13:32:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17BE169257\n\tfor ;\n\tMon, 18 Aug 2025 13:32:10 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0586017D1;\n\tMon, 18 Aug 2025 13:31:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tn7DYHMC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755516673;\n\tbh=XFnaIfc4GlxC0h+OSu2i9VmKFv7gnBZ+XXmYTzncmqI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tn7DYHMCqIPcym94q76z8X+LEId7xk1pcQN6jc5jN9en9JOqqdmXb46u/uLbtgIzu\n\t/N4jYWqVEfR5qJfZ3/Lhum/ldq3GdqrsUF4wC46PXkd2hUS/5+xgVP/KzHk4z0a0E8\n\t7BI3sXJDFXXLqeni8jMineNSNY73J13ASVnWvnz8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<175551667949.560048.16259302966988023857@ping.linuxembedded.co.uk>","References":"<20250813170240.50173-1-mzamazal@redhat.com>\n\t<20250813170240.50173-2-mzamazal@redhat.com>\n\t<175510658138.1721288.7315212640284674658@ping.linuxembedded.co.uk>\n\t\n\t<175516704065.1721288.14615391055831778603@ping.linuxembedded.co.uk>\n\t\n\t\n\t<175551667949.560048.16259302966988023857@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","From":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","To":"Bryan O'Donoghue ,\n\tHans de Goede ,\n\tMilan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Mon, 18 Aug 2025 12:32:07 +0100","Message-ID":"<175551672761.560048.12145300054102393852@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35478,"web_url":"https://patchwork.libcamera.org/comment/35478/","msgid":"<85o6schndc.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-08-18T11:37:19","subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Kieran Bingham writes:\n\n> Quoting Bryan O'Donoghue (2025-08-14 12:16:21)\n>> On 14/08/2025 12:12, Bryan O'Donoghue wrote:\n>> > On 14/08/2025 11:24, Kieran Bingham wrote:\n>\n>> >> Hans, Bryan,\n>> >>\n>> >> Quoting Kieran Bingham (2025-08-13 18:36:21)\n>> >>> Quoting Milan Zamazal (2025-08-13 18:02:40)\n>> >>>> The statistics in software ISP is computed basically over the whole\n>> >>>> image area, although only on part of the pixels.  It is not \n>> >>>> necessary to\n>> >>>> cover the whole image area, it's sufficient to compute the statistics\n>> >>>> let's say over the central area of 2/3 of the image width and height,\n>> >>>> which should be both sufficient and faster.  The speedup is not that\n>> >>>> important with the CPU implementation but it may save CPU work\n>> >>>> more noticeably with GPU debayering implementation.\n>> >>>>\n>> >>>> Signed-off-by: Milan Zamazal \n>> >>>\n>> >>\n>> >> Could you test/review this please?\n>> >>\n>> >> If everyone's happy in softisp I can merge this.\n>> > You'll have to cut out the egl part as its not upstream yet but, \n>> > applying to the GPUISP branch it seems to work well.\n>\n> Aha of course.\n>\n> Milan, do you want this patch merged with just the CPU part ?\n\nI don't think so, best if Bryan would make it a part of his his v2.\n\n> --\n> Kieran\n>\n>> > \n>> > CPU fps is about the same, gpu FPS hits line rate and keep in mind this \n>> > is on a debug build too.\n>> > \n>> > Also seems to improve the flickering bug I've been seeing because the \n>> > area of interest is the center of the image instead of the edges.\n>> > \n>> > Before:\n>> > https://drive.google.com/file/d/19JGJSCjTI-lcu_zcs1qmu7K5Y9aktEoG/view? \n>> > usp=drive_link\n>> > \n>> > After:\n>> > https://drive.google.com/file/d/1A_niOE6cKC97N3IkvH8iw4JB9qyjGj5l/view? \n>> > usp=sharing\n>> > \n>> > Reviewed-by: Bryan O'Donoghue \n>> > Tested-by: Bryan O'Donoghue \n>> \n>> https://gitlab.freedesktop.org/camera/libcamera-softisp/-/tree/origin-master+whole-frame-swtats-v2-gpuisp-v1n?ref_type=heads\n>> \n>> ---\n>> bod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 815EEBDCC1\n\tfor ;\n\tMon, 18 Aug 2025 11:37:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37C5C69257;\n\tMon, 18 Aug 2025 13:37:28 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5C2069257\n\tfor ;\n\tMon, 18 Aug 2025 13:37:25 +0200 (CEST)","from mail-qt1-f200.google.com (mail-qt1-f200.google.com\n\t[209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-292-3edKSG2JNka4i-g7uOhpnA-1; Mon, 18 Aug 2025 07:37:23 -0400","by mail-qt1-f200.google.com with SMTP id\n\td75a77b69052e-4b109ab1e1dso211581801cf.1\n\tfor ;\n\tMon, 18 Aug 2025 04:37:23 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb ([85.93.96.130])\n\tby smtp.gmail.com with ESMTPSA id\n\taf79cd13be357-7e87e195e49sm581573085a.43.2025.08.18.04.37.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Aug 2025 04:37:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"RM5qBhyJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1755517044;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=e8dPQm/N1Xj5+DomDVc2/jjeX2ZEq99mtI0YYYnuCWI=;\n\tb=RM5qBhyJBb0ZFwOCB2kplY6+AljabtV8bclfJaIzk7IMxk3G/NcmywMv0jE2jc7xGw9np+\n\tAJkS8TEJeTA2zQa31/3FTgNiNBgNKlzDTdpJaWpxZr9MVObBbNNuaMkwl9RK5JQfQdymbM\n\tbNm66f/njESZzEmcXsjgvx3LGp4cCs0=","X-MC-Unique":"3edKSG2JNka4i-g7uOhpnA-1","X-Mimecast-MFC-AGG-ID":"3edKSG2JNka4i-g7uOhpnA_1755517043","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755517042; x=1756121842;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=e8dPQm/N1Xj5+DomDVc2/jjeX2ZEq99mtI0YYYnuCWI=;\n\tb=Hu3cMpf/o6GNl0SsSzJAMg16aa/SwXwX/SpZstgjzxisKq70USo5vMmWpqVIGaNWyA\n\tXSTGrfp1yGaECpfyFT53pT/MmzGiljewbjbP0jaFZpMCzm9M0wjXOelyNm0bCBL4NJWp\n\tPQ4KgIWry2IIi/6FcV1Aa43m1oiagM8auRchvTctdimOKaMM/YI+l7XKRymrfb+cmA7r\n\tPif//7Yiju0qDW02ymuEI68tuy2JdJ0lIpeOgpJoosD+daTvdga0ymtiLY4gD56hHYi6\n\tn5sFMAoj0+LBB7aG0OioK3Wn31YijY266gNag8doW1RLAZy0XfhTUo/rgPbdaQxFiOSU\n\tfG9w==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXL+NHjNCvLYpsiK5bIT487G/ozSaFfdM1nUymApRQibZjDQg2kxRM08+w4ucMCsTogQnfsEFk6LNtV1N9xRik=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YxBu0mhyFO8RAGoHXQ3lSQp1WiVfVCqotgCzGcgaMNhKojPpYSk\n\tWgxaSEaKVFx03ufvQDj0xKJMV/6GU2K+I/xwTDWchaSs2jmMmP5huETSnhKdZ+4FmFigsKUK0VD\n\tZf1K6LDRhCxXF4GZ1nUu7/x4/69Svpny28NGbtcOjz264VvUpDj7IgZ5ag0XNwo4YujCncoGwEC\n\t5viPdnGdI=","X-Gm-Gg":"ASbGncucLLiGw6ZrzpSnJZORZVjUVHBhH+7qpR4PuvlUGbxUerP2aYlIW1/VFfbq0JJ\n\tjd2U2vZthbdbW/5neGR9Johqy4Fyx+6nImXjspJfXIggsPTwu6STyHeUtJ4cJZCtIKI/z9rTUUt\n\tto4HfG3VxFPynWqfqaUN8BHPKKowe5GY9drzGU+UswoeG2h0fZ0aCPlKr+gBcIBtsYSRjPQh5od\n\tveAI3Ksn9fTIGtB/Z+HBXGZLFulAygsLzZwy8ZHbaBkkXcURRDIzVh0fJPTlzHiU7rvp408Q31p\n\tYhBn2w11FFe3XXx4Cu9BaoPoXtYujhi+6GRYGf7uNZwkikZ7MpBwG/QxEl0AHHTt","X-Received":["by 2002:a05:622a:118e:b0:4b0:cb0f:343e with SMTP id\n\td75a77b69052e-4b133637e86mr64157281cf.3.1755517042322; \n\tMon, 18 Aug 2025 04:37:22 -0700 (PDT)","by 2002:a05:622a:118e:b0:4b0:cb0f:343e with SMTP id\n\td75a77b69052e-4b133637e86mr64156881cf.3.1755517041793; \n\tMon, 18 Aug 2025 04:37:21 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IG6ARmJ086hb9+kk2KZ3jWxtAPtfiSEPmkTQQbTxMokKF4AYf/yw0zhnp9UZriHqCQrP4J3WQ==","From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"Bryan O'Donoghue ,\n\tHans de Goede ,\n\tlibcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= , Laurent Pinchart\n\t","Subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","In-Reply-To":"<175551667949.560048.16259302966988023857@ping.linuxembedded.co.uk>\n\t(Kieran Bingham's message of \"Mon, 18 Aug 2025 12:31:19 +0100\")","References":"<20250813170240.50173-1-mzamazal@redhat.com>\n\t<20250813170240.50173-2-mzamazal@redhat.com>\n\t<175510658138.1721288.7315212640284674658@ping.linuxembedded.co.uk>\n\t\n\t<175516704065.1721288.14615391055831778603@ping.linuxembedded.co.uk>\n\t\n\t\n\t<175551667949.560048.16259302966988023857@ping.linuxembedded.co.uk>","Date":"Mon, 18 Aug 2025 13:37:19 +0200","Message-ID":"<85o6schndc.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"eFjNokX99XpF5_tUZBtM_Hzyd2LYKovhU72VyxNSrsw_1755517043","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35480,"web_url":"https://patchwork.libcamera.org/comment/35480/","msgid":"<5f5dbd6d-ddb5-453a-960f-8c3fde59f742@nxsw.ie>","date":"2025-08-18T11:41:12","subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 18/08/2025 12:37, Milan Zamazal wrote:\n>> Milan, do you want this patch merged with just the CPU part ?\n> I don't think so, best if Bryan would make it a part of his his v2.\n\nok\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD266BEFBE\n\tfor ;\n\tMon, 18 Aug 2025 11:41:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DA3669265;\n\tMon, 18 Aug 2025 13:41:19 +0200 (CEST)","from tor.source.kernel.org (tor.source.kernel.org\n\t[IPv6:2600:3c04:e001:324:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2DD769257\n\tfor ;\n\tMon, 18 Aug 2025 13:41:17 +0200 (CEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 5ED17601EC;\n\tMon, 18 Aug 2025 11:41:16 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 4CCA0C4CEED;\n\tMon, 18 Aug 2025 11:41:14 +0000 (UTC)"],"Message-ID":"<5f5dbd6d-ddb5-453a-960f-8c3fde59f742@nxsw.ie>","Date":"Mon, 18 Aug 2025 12:41:12 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 1/1] libcamera: software_isp: Reduce statistics image\n\tarea","To":"Milan Zamazal ,\n\tKieran Bingham ","Cc":"Bryan O'Donoghue , Hans de Goede\n\t, libcamera-devel@lists.libcamera.org, \n\t=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","References":"<20250813170240.50173-1-mzamazal@redhat.com>\n\t<20250813170240.50173-2-mzamazal@redhat.com>\n\t<175510658138.1721288.7315212640284674658@ping.linuxembedded.co.uk>\n\t\n\t<175516704065.1721288.14615391055831778603@ping.linuxembedded.co.uk>\n\t\n\t\n\t<175551667949.560048.16259302966988023857@ping.linuxembedded.co.uk>\n\t\n\t<85o6schndc.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<85o6schndc.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]