[{"id":35322,"web_url":"https://patchwork.libcamera.org/comment/35322/","msgid":"<175476097434.2727593.1729107633847898624@ping.linuxembedded.co.uk>","date":"2025-08-09T17:36:14","subject":"Re: [PATCH v2 16/16] tuning: rksip1: Add a static WideDynamicRange\n\tentry","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-08-08 15:12:54)\n> Add a static WideDynamicRange entry that gets added by default.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Paul Elder \n\nReviewed-by: Kieran Bingham \n\n> \n> ---\n> \n> Changes in v3:\n> - Collected tag\n> ---\n> utils/tuning/rkisp1.py | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index 179d920c05df..2e6f70401fc4 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -48,16 +48,19 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> # values. This can also be a custom function.\n> smoothing_function=lt.smoothing.MedianBlur(3),)\n> lux = LuxRkISP1(debug=[lt.Debug.Plot])\n> +wdr = StaticModule('WideDynamicRange',\n> + {'ExposureConstraint': {'MaxBrightPixels': 0.02, 'yTarget': 0.95},\n> + 'MinExposureValue': -4.0})\n> \n> tuner = lt.Tuner('RkISP1')\n> -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress])\n> +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, wdr, compress])\n> tuner.set_input_parser(YamlParser())\n> tuner.set_output_formatter(YamlOutput())\n> \n> # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.\n> # Compress is parameterized by others, so add it at the end.\n> tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,\n> - filter, gamma_out, lsc, compress])\n> + filter, gamma_out, lsc, wdr, compress])\n> \n> if __name__ == '__main__':\n> sys.exit(tuner.run(sys.argv))\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE93DBEFBE\n\tfor ;\n\tSat, 9 Aug 2025 17:36:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 910FC6921F;\n\tSat, 9 Aug 2025 19:36:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1C0169154\n\tfor ;\n\tSat, 9 Aug 2025 19:36:16 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DC7FC6E;\n\tSat, 9 Aug 2025 19:35:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mBrDs79J\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1754760926;\n\tbh=y3gUuZJ4SS5lC/qDsi/EBqU2Jgv4VA5cAbBuYiL5ICQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mBrDs79JqBBapIvqeA8iKotOKqTv14DLQ7T4hcJwNZ+2PRh2Hv1U83LFPmzp8JRfm\n\tTi+kKK8/UTx94ee3CCATzRIi8QtC9dMDtUBPdmEQf0yPbNQCutd+vbR5LTtE85cwe8\n\tYEhb8cGHsJ8185HNO3EjYltZVAy/9m+k2ky4ENvE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250808141315.413839-17-stefan.klug@ideasonboard.com>","References":"<20250808141315.413839-1-stefan.klug@ideasonboard.com>\n\t<20250808141315.413839-17-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 16/16] tuning: rksip1: Add a static WideDynamicRange\n\tentry","From":"Kieran Bingham ","Cc":"Stefan Klug ,\n\tPaul Elder ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 09 Aug 2025 18:36:14 +0100","Message-ID":"<175476097434.2727593.1729107633847898624@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]