[{"id":35315,"web_url":"https://patchwork.libcamera.org/comment/35315/","msgid":"<175466950930.560048.11393048227179149713@ping.linuxembedded.co.uk>","date":"2025-08-08T16:11:49","subject":"Re: [PATCH v2 02/16] tuning: rksip1: Add a static Compress entry","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"in $SUBJECT: s/rksip1/rkisp1/\n\nQuoting Stefan Klug (2025-08-08 15:12:40)\n> Add a static Compress entry that gets added by default.\n> \n\nCan you state here that it uses the existing Compress module?\nI assume it's already existing - I don't know where from though - or has\nit not been used at all yet?\n\n> Signed-off-by: Stefan Klug \n> ---\n> utils/tuning/rkisp1.py | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index 207b717a029c..179d920c05df 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -27,6 +27,7 @@ awb = AWBRkISP1(debug=[lt.Debug.Plot])\n> blc = StaticModule('BlackLevelCorrection')\n> ccm = CCMRkISP1(debug=[lt.Debug.Plot])\n> color_processing = StaticModule('ColorProcessing')\n> +compress = StaticModule('Compress')\n> filter = StaticModule('Filter')\n> gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2})\n> lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> @@ -49,13 +50,14 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> lux = LuxRkISP1(debug=[lt.Debug.Plot])\n> \n> tuner = lt.Tuner('RkISP1')\n> -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])\n> +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress])\n> tuner.set_input_parser(YamlParser())\n> tuner.set_output_formatter(YamlOutput())\n> \n> # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.\n> +# Compress is parameterized by others, so add it at the end.\n> tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,\n> - filter, gamma_out, lsc])\n> + filter, gamma_out, lsc, compress])\n> \n> if __name__ == '__main__':\n> sys.exit(tuner.run(sys.argv))\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94C09BDCC1\n\tfor ;\n\tFri, 8 Aug 2025 16:11:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 406586921E;\n\tFri, 8 Aug 2025 18:11:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DB426084D\n\tfor ;\n\tFri, 8 Aug 2025 18:11:52 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1A58208E;\n\tFri, 8 Aug 2025 18:11:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hZ26fFdh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1754669462;\n\tbh=9tYiNiU42e6ypFah/Wgz0NwVcN4b2sSVR3yuUqKJpqs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=hZ26fFdh26Web4SvvcccHk3HgJM1GMzsr5W/l08wHpjwEwtZiDciEBt/z6m0jYUoG\n\tiZoSQZRTnTYYrubCnE9HJfogVzr2uEd/fuc4rSu1bDyXZOrTdRwnzDu6+h9/ylgzeU\n\tagfhyqMud4g1vDqPSOdIASJ8gP+EUnmo7e9xHpdc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250808141315.413839-3-stefan.klug@ideasonboard.com>","References":"<20250808141315.413839-1-stefan.klug@ideasonboard.com>\n\t<20250808141315.413839-3-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 02/16] tuning: rksip1: Add a static Compress entry","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 08 Aug 2025 17:11:49 +0100","Message-ID":"<175466950930.560048.11393048227179149713@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35316,"web_url":"https://patchwork.libcamera.org/comment/35316/","msgid":"<175466955100.560048.9644527932975548106@ping.linuxembedded.co.uk>","date":"2025-08-08T16:12:31","subject":"Re: [PATCH v2 02/16] tuning: rksip1: Add a static Compress entry","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2025-08-08 17:11:49)\n> in $SUBJECT: s/rksip1/rkisp1/\n> \n> Quoting Stefan Klug (2025-08-08 15:12:40)\n> > Add a static Compress entry that gets added by default.\n> > \n> \n> Can you state here that it uses the existing Compress module?\n> I assume it's already existing - I don't know where from though - or has\n> it not been used at all yet?\n\nNever mind - I assume StaticModule('Compress') is all it takes to add a\nbasic entry to the tuning file to enable the component.\n\n> \n> > Signed-off-by: Stefan Klug \n> > ---\n> > utils/tuning/rkisp1.py | 6 ++++--\n> > 1 file changed, 4 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> > index 207b717a029c..179d920c05df 100755\n> > --- a/utils/tuning/rkisp1.py\n> > +++ b/utils/tuning/rkisp1.py\n> > @@ -27,6 +27,7 @@ awb = AWBRkISP1(debug=[lt.Debug.Plot])\n> > blc = StaticModule('BlackLevelCorrection')\n> > ccm = CCMRkISP1(debug=[lt.Debug.Plot])\n> > color_processing = StaticModule('ColorProcessing')\n> > +compress = StaticModule('Compress')\n> > filter = StaticModule('Filter')\n> > gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2})\n> > lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> > @@ -49,13 +50,14 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> > lux = LuxRkISP1(debug=[lt.Debug.Plot])\n> > \n> > tuner = lt.Tuner('RkISP1')\n> > -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])\n> > +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress])\n> > tuner.set_input_parser(YamlParser())\n> > tuner.set_output_formatter(YamlOutput())\n> > \n> > # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.\n> > +# Compress is parameterized by others, so add it at the end.\n> > tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,\n> > - filter, gamma_out, lsc])\n> > + filter, gamma_out, lsc, compress])\n> > \n> > if __name__ == '__main__':\n> > sys.exit(tuner.run(sys.argv))\n> > -- \n> > 2.48.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FE92BDCC1\n\tfor ;\n\tFri, 8 Aug 2025 16:12:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3ECC6921A;\n\tFri, 8 Aug 2025 18:12:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C39416921A\n\tfor ;\n\tFri, 8 Aug 2025 18:12:33 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0FD4185B;\n\tFri, 8 Aug 2025 18:11:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NggKMwwy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1754669503;\n\tbh=Sz2hjvxyFEJ1fJVi1JeYIXG1NDOyPN4Zg70wnc+oLd4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=NggKMwwyY7fwgbYteB0Jlqv8Fjqa59Xgbtd9nVOnbyGasr8oheJesUTkPGIJA4BVh\n\tbL2HgNwAwKxUnNY7M89OSY7zun75dbYFga2MJYAeUb7hjZCbgQg+/AWBEcGDa50MhB\n\tJsBgMvT/Gark6hTlFJkH+b+6yhYILB5b/LSgjM+I=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<175466950930.560048.11393048227179149713@ping.linuxembedded.co.uk>","References":"<20250808141315.413839-1-stefan.klug@ideasonboard.com>\n\t<20250808141315.413839-3-stefan.klug@ideasonboard.com>\n\t<175466950930.560048.11393048227179149713@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v2 02/16] tuning: rksip1: Add a static Compress entry","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 08 Aug 2025 17:12:31 +0100","Message-ID":"<175466955100.560048.9644527932975548106@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35356,"web_url":"https://patchwork.libcamera.org/comment/35356/","msgid":"<3b878669-1359-41e5-82da-4eee37c717a2@ideasonboard.com>","date":"2025-08-12T11:56:48","subject":"Re: [PATCH v2 02/16] tuning: rksip1: Add a static Compress entry","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"On 08/08/2025 15:12, Stefan Klug wrote:\n> Add a static Compress entry that gets added by default.\n> \n> Signed-off-by: Stefan Klug \n> ---\n\nReviewed-by: Daniel Scally \n\n> utils/tuning/rkisp1.py | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index 207b717a029c..179d920c05df 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -27,6 +27,7 @@ awb = AWBRkISP1(debug=[lt.Debug.Plot])\n> blc = StaticModule('BlackLevelCorrection')\n> ccm = CCMRkISP1(debug=[lt.Debug.Plot])\n> color_processing = StaticModule('ColorProcessing')\n> +compress = StaticModule('Compress')\n> filter = StaticModule('Filter')\n> gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2})\n> lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> @@ -49,13 +50,14 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> lux = LuxRkISP1(debug=[lt.Debug.Plot])\n> \n> tuner = lt.Tuner('RkISP1')\n> -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])\n> +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress])\n> tuner.set_input_parser(YamlParser())\n> tuner.set_output_formatter(YamlOutput())\n> \n> # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.\n> +# Compress is parameterized by others, so add it at the end.\n> tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,\n> - filter, gamma_out, lsc])\n> + filter, gamma_out, lsc, compress])\n> \n> if __name__ == '__main__':\n> sys.exit(tuner.run(sys.argv))","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5C52BDCC1\n\tfor ;\n\tTue, 12 Aug 2025 11:56:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CB0169245;\n\tTue, 12 Aug 2025 13:56:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66FC761444\n\tfor ;\n\tTue, 12 Aug 2025 13:56:51 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 820FF3DC\n\tfor ;\n\tTue, 12 Aug 2025 13:55:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oGC42mWe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1754999758;\n\tbh=YpFeqauwOChOSO25saCmXbKS3/n65Lvyg+2aGd3RH70=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=oGC42mWeK3gwMpMocU/MecnqfArsvZCodnnTF5kCP4Vup5gyHvC3lD9s876SieJWJ\n\tt9xPk6IYtFRkk4POcK09mSq0zWcXlZOjyfcx0lWQWXz5IUjFvV/1UtPOHaM26BxgAP\n\tMO02Cw9jmEE71jkt4mQba4YHku+Q7k3cUzhgdWF4=","Message-ID":"<3b878669-1359-41e5-82da-4eee37c717a2@ideasonboard.com>","Date":"Tue, 12 Aug 2025 12:56:48 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 02/16] tuning: rksip1: Add a static Compress entry","To":"libcamera-devel@lists.libcamera.org","References":"<20250808141315.413839-1-stefan.klug@ideasonboard.com>\n\t<20250808141315.413839-3-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","In-Reply-To":"<20250808141315.413839-3-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]