{"id":24070,"url":"https://patchwork.libcamera.org/api/patches/24070/?format=json","web_url":"https://patchwork.libcamera.org/patch/24070/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250808040453.9016-1-uajain@igalia.com>","date":"2025-08-08T04:04:53","name":"libcamera: request: Clarify ReuseBuffers flag usage with fences","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bff5350908d92872f31e0bfe3697cab4b2e6feb2","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24070/mbox/","series":[{"id":5363,"url":"https://patchwork.libcamera.org/api/series/5363/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5363","date":"2025-08-08T04:04:53","name":"libcamera: request: Clarify ReuseBuffers flag usage with fences","version":1,"mbox":"https://patchwork.libcamera.org/series/5363/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24070/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24070/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 212BCBDCC1\n\tfor ;\n\tFri, 8 Aug 2025 04:04:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50D2F6921E;\n\tFri, 8 Aug 2025 06:04:48 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0FB361460\n\tfor ;\n\tFri, 8 Aug 2025 06:04:45 +0200 (CEST)","from [49.36.71.143] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1ukELT-00BKsn-FE; Fri, 08 Aug 2025 06:04:44 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"BwwKhxp0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:\n\tCc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=GC9Zpwz4wZffYL7DKvQ9v07PQqtL4KV8/SM1n+XRTyA=;\n\tb=BwwKhxp0ixyBHojCefp4WG8NZH\n\tIPMPn3r2B3jlqH1jSrH1rQN+jLAiIMyYPMLTRyE3ME8e5vX+ss4i9cz0TkJhgJWTYw4PHKd+Xx8rN\n\t0sZD0ml5mMDb+yRmsiOvLRNC/wt1Q7MCyg7ZqO7EV+WSn34VDeTTMnZqma+WuDLecWpROapBsLwbN\n\tRLn5dGe+b6djsLOpM/443+30FqjnSV52VuUMr4NjXlz4e5tF6H+XC/BxUWkqz8WiuYo4BSfBEdqM4\n\tXOZFODBm9CPUinZXO1RGt3b6p4cpRT2NXttOw4GHVs45OCLYgOuZpyyw9DFb8Kq/dgJ2oKlKXgUKm\n\tjvzA3UVw==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH] libcamera: request: Clarify ReuseBuffers flag usage with\n\tfences","Date":"Fri, 8 Aug 2025 09:34:53 +0530","Message-ID":"<20250808040453.9016-1-uajain@igalia.com>","X-Mailer":"git-send-email 2.50.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Explicitly clarify the usage of Request::ReuseBuffers flag in context\nof buffer fences. Fences are user-supplied and are not re-cycled as\npart of Request::reuse(), hence document this behaviour explicitly.\n\nSigned-off-by: Umang Jain \n---\n src/libcamera/request.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 7f1e11e8..86d849ac 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -326,7 +326,8 @@ void Request::Private::timeout()\n * \\var Request::Default\n * Don't reuse buffers\n * \\var Request::ReuseBuffers\n- * Reuse the buffers that were previously added by addBuffer()\n+ * Reuse the buffers that were previously added by addBuffer().\n+ * Buffers meant to be queued with a Fence, should not use this flag.\n */\n \n /**\n","prefixes":[]}