[{"id":35393,"web_url":"https://patchwork.libcamera.org/comment/35393/","msgid":"<175515396127.3701817.6532835745368065138@neptunite.rasen.tech>","date":"2025-08-14T06:46:01","subject":"Re: [RFC PATCH v1 2/3] utils: codegen: ipc: Default special member\n\tops","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-08-07 00:48:41)\n> Default the copy/move constructor/assignment operators so that\n> they are available if possible. This can allow more efficient\n> passing and construction of these objects.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> .../libcamera_templates/definition_functions.tmpl | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl b/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n> index 16d11c309..3a57a3c2c 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n> @@ -39,6 +39,12 @@ public:\n> {%- endfor %}\n> {\n> }\n> +\n> + {{struct.mojom_name}}(const {{struct.mojom_name}} &) = default;\n> + {{struct.mojom_name}} &operator=(const {{struct.mojom_name}} &) = default;\n> + {{struct.mojom_name}}({{struct.mojom_name}} &&) = default;\n> + {{struct.mojom_name}} &operator=({{struct.mojom_name}} &&) = default;\n> + ~{{struct.mojom_name}}() = default;\n> #endif\n> \n> {% for field in struct.fields %}\n> -- \n> 2.50.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43D54BDCC1\n\tfor ;\n\tThu, 14 Aug 2025 06:46:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B2A569253;\n\tThu, 14 Aug 2025 08:46:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 290346923C\n\tfor ;\n\tThu, 14 Aug 2025 08:46:07 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:d967:c4f9:b351:2e11])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5B94615B2; \n\tThu, 14 Aug 2025 08:45:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OzK3zrDv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755153912;\n\tbh=fdepLKJSEBeGJm/WTW4MiiwX3QbDk1uGRZb3pYzsbbw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=OzK3zrDvrAw/P3L18DbdFxqJ7iHfbOUK7Xl0NHPCyjB4si2vR6cP3PgMfNyX6vGsH\n\ta7L+CIuS9zdrDLMVJ7PhkNYoP4ATEhnHzRWrPsr1HqSCDdUqJCLxJHI3DDMiQC1GDs\n\tauJDybMEO7jPloiML2rWU+cLaZKBS8oSNi0uwdxE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250806154842.597155-2-barnabas.pocze@ideasonboard.com>","References":"<20250806154842.597155-1-barnabas.pocze@ideasonboard.com>\n\t<20250806154842.597155-2-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v1 2/3] utils: codegen: ipc: Default special member\n\tops","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 14 Aug 2025 15:46:01 +0900","Message-ID":"<175515396127.3701817.6532835745368065138@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]