[{"id":35392,"web_url":"https://patchwork.libcamera.org/comment/35392/","msgid":"<175515329967.3701817.2710381861292599521@neptunite.rasen.tech>","date":"2025-08-14T06:34:59","subject":"Re: [RFC PATCH v1 1/3] utils: codegen: ipc: Put default values in\n\tdeclaration","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-08-07 00:48:40)\n> Instead of generating a constructor to initialize each member\n> to its default value, simply specify the default values in\n> the declaration of the member.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Paul Elder \n\n> ---\n> .../libcamera_templates/definition_functions.tmpl | 12 ++----------\n> 1 file changed, 2 insertions(+), 10 deletions(-)\n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl b/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n> index 8b8509f3d..16d11c309 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/definition_functions.tmpl\n> @@ -26,13 +26,7 @@ struct {{struct.mojom_name}}\n> {\n> public:\n> #ifndef __DOXYGEN__\n> - {{struct.mojom_name}}() {%- if struct|has_default_fields %}\n> - :{% endif %}\n> -{%- for field in struct.fields|with_default_values -%}\n> -{{\" \" if loop.first}}{{field.mojom_name}}({{field|default_value}}){{\", \" if not loop.last}}\n> -{%- endfor %}\n> - {\n> - }\n> + {{struct.mojom_name}}() = default;\n> \n> {{struct.mojom_name}}(\n> {%- for field in struct.fields -%}\n> @@ -48,9 +42,7 @@ public:\n> #endif\n> \n> {% for field in struct.fields %}\n> - {{field|name}} {{field.mojom_name}};\n> + {{field|name}} {{field.mojom_name}}{% if field|default_value %}{ {{field|default_value}} }{% endif %};\n> {%- endfor %}\n> };\n> {%- endmacro -%}\n> -\n> -\n> -- \n> 2.50.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0475BEFBE\n\tfor ;\n\tThu, 14 Aug 2025 06:35:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4CE56923C;\n\tThu, 14 Aug 2025 08:35:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A6C061436\n\tfor ;\n\tThu, 14 Aug 2025 08:35:06 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:d967:c4f9:b351:2e11])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9690615B2; \n\tThu, 14 Aug 2025 08:34:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q2FpVgAG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755153252;\n\tbh=IrPsu35jZMYLZN1hd1gHf/WpEzXL6X42CJrrTSlN+8k=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Q2FpVgAGSXn9db9DNjV2dhw/6QUysFbgE4Zqg9ltwfUsTyI4cC1lMLNFzW5rXnnay\n\t48nyvHEdkvwhVCKkCmvrbkJtPUFjrFMSgl8T8OEvZFeLTJmK/tCWg9kKF3NUkztMeM\n\tQnoMRGy+tNL2RHCLL1D5C5AkPe+1v/1qfgRechQs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250806154842.597155-1-barnabas.pocze@ideasonboard.com>","References":"<20250806154842.597155-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v1 1/3] utils: codegen: ipc: Put default values in\n\tdeclaration","From":"Paul Elder ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 14 Aug 2025 15:34:59 +0900","Message-ID":"<175515329967.3701817.2710381861292599521@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]