[{"id":35288,"web_url":"https://patchwork.libcamera.org/comment/35288/","msgid":"<175449885402.50296.3326395888525365961@ping.linuxembedded.co.uk>","date":"2025-08-06T16:47:34","subject":"Re: [PATCH v2 4/4] libcamera: libipa: Add vd56g3 support for libipa","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Benjamin Mugnier (2025-07-28 10:09:17)\n> Values are sourced initially from the vd56g3 user manual.\n> \n> Signed-off-by: Benjamin Mugnier \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\nMerging these.\n\n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 7c66cd57d6857e43863375d0b32d688fb5a1063c..dcd69d9f2bbb39feabfefe41cee8b45f0f958127 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -745,6 +745,18 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n> \n> +class CameraSensorHelperVd56g3 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperVd56g3()\n> + {\n> + /* From datasheet: 0x40 at 10bits. */\n> + blackLevel_ = 4096;\n> + gain_ = AnalogueGainLinear{ 0, 32, -1, 32 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"vd56g3\", CameraSensorHelperVd56g3)\n> +\n> #endif /* __DOXYGEN__ */\n> \n> } /* namespace ipa */\n> \n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F29F5BE086\n\tfor ;\n\tWed, 6 Aug 2025 16:47:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C13A6921A;\n\tWed, 6 Aug 2025 18:47:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C634F691F5\n\tfor ;\n\tWed, 6 Aug 2025 18:47:36 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA5A9C75;\n\tWed, 6 Aug 2025 18:46:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"apzG5G9N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1754498807;\n\tbh=aDEW1GZ1T4sawyHom2EU2yo4cc3CqfmxU4gTG1OZHCc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=apzG5G9NNBsbHTNc4DOBg+WzpeBgszLqR57H5m3cCXkPa2K6UVjADY90gHw95WzrU\n\tS22anBh3ZNB6AtrDDBMza1ac/NVcz1kc/a1kPCNK75WWoQZlN/CTJRptLYXKjB+r4g\n\tcmzn+6kXl2m1J50mXKo+YcFcxV8WK7+4tXWx3Wcw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250728-vd56g3_support-v2-4-cee5d5feac44@foss.st.com>","References":"<20250728-vd56g3_support-v2-0-cee5d5feac44@foss.st.com>\n\t<20250728-vd56g3_support-v2-4-cee5d5feac44@foss.st.com>","Subject":"Re: [PATCH v2 4/4] libcamera: libipa: Add vd56g3 support for libipa","From":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tSylvain Petinot ,\n\tCyril Liotard , Jean Poire , \n\tBenjamin Mugnier ,\n\tLaurent Pinchart ","To":"Benjamin Mugnier ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 06 Aug 2025 17:47:34 +0100","Message-ID":"<175449885402.50296.3326395888525365961@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]