[{"id":35176,"web_url":"https://patchwork.libcamera.org/comment/35176/","msgid":"","date":"2025-07-28T04:24:39","subject":"Re: [PATCH] libcamera: v4l2_videodevice: Use ScopeExitActions","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"On Sat, Jul 26, 2025 at 02:53:11AM +0300, Laurent Pinchart wrote:\n> The V4L2VideoDevice::queueBuffer() function performs the same cleanup\n> action in many error paths. Use ScopeExitActions to simplify it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/v4l2_videodevice.cpp | 12 ++++--------\n> 1 file changed, 4 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 71cc7e895d8c..5f57e546e80b 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1646,6 +1646,7 @@ int V4L2VideoDevice::releaseBuffers()\n> int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> {\n> \tstruct v4l2_plane v4l2Planes[VIDEO_MAX_PLANES] = {};\n> +\tutils::ScopeExitActions actions;\n> \tstruct v4l2_buffer buf = {};\n> \tint ret;\n> \n> @@ -1668,6 +1669,8 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> +\tactions += [&]() { cache_->put(buf.index); };\n> +\n> \tbuf.index = ret;\n> \tbuf.type = bufferType_;\n> \tbuf.memory = memoryType_;\n> @@ -1683,15 +1686,11 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \t */\n> \tif (planes.size() < numV4l2Planes) {\n> \t\tLOG(V4L2, Error) << \"Frame buffer has too few planes\";\n> -\t\tcache_->put(buf.index);\n> -\n> \t\treturn -EINVAL;\n> \t}\n> \n> \tif (planes.size() != numV4l2Planes && !buffer->_d()->isContiguous()) {\n> \t\tLOG(V4L2, Error) << \"Device format requires contiguous buffer\";\n> -\t\tcache_->put(buf.index);\n> -\n> \t\treturn -EINVAL;\n> \t}\n> \n> @@ -1734,8 +1733,6 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \t\t\t\tif (i != planes.size() - 1 && bytesused != length) {\n> \t\t\t\t\tLOG(V4L2, Error)\n> \t\t\t\t\t\t<< \"Holes in multi-planar buffer not supported\";\n> -\t\t\t\t\tcache_->put(buf.index);\n> -\n> \t\t\t\t\treturn -EINVAL;\n> \t\t\t\t}\n> \t\t\t}\n> @@ -1785,8 +1782,6 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \t\tLOG(V4L2, Error)\n> \t\t\t<< \"Failed to queue buffer \" << buf.index << \": \"\n> \t\t\t<< strerror(-ret);\n> -\t\tcache_->put(buf.index);\n> -\n> \t\treturn ret;\n> \t}\n> \n> @@ -1798,6 +1793,7 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \n> \tqueuedBuffers_[buf.index] = buffer;\n> \n> +\tactions.release();\n> \treturn 0;\n> }\n> \n> \n> base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59403BDCC1\n\tfor ;\n\tMon, 28 Jul 2025 04:25:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E27F69135;\n\tMon, 28 Jul 2025 06:25:05 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D1256146B\n\tfor ;\n\tMon, 28 Jul 2025 06:24:35 +0200 (CEST)","from [49.36.71.87] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1ugFPc-004kvy-2W; Mon, 28 Jul 2025 06:24:32 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"Mpt/13/Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=yoOfqutgRQOkCfxP9EvvYAixta7i7vw2mpogcJ+ioOk=;\n\tb=Mpt/13/YuCvO/Nol2QoCcTcQN6\n\t6PVQwb/iQwR8yOs7ngjycjsjmnFmwD72FKnCvR7PKuJaMjVhCG+NYCWEkj5g5saqNDV/RDjPGqRly\n\tHcgYLgEaUWIy/5j9PcEQJ4bodAyvEd+Y8bxz7Ayidghp0A2ofHHMNndzWRAPDlP0mMPrqPTBstSQ2\n\t37rgKS7jO2Oe/thV2I8y7dbvdWzETjcSxZ/mRoR+Pa/BoPc0iGKZCroPefkDLb7BhEnxhY/EoqgeE\n\tq8YDF0+zW+3VNW6IfL4INegolMrFnZjEjB3ecL4MZ8FYvelz9y7Sjx9F24eb7QiemMG6UomNBxz9h\n\tZS/AE51g==;","Date":"Mon, 28 Jul 2025 09:54:39 +0530","From":"Umang Jain ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tHan-Lin Chen ,\n\tHarvey Yang ","Subject":"Re: [PATCH] libcamera: v4l2_videodevice: Use ScopeExitActions","Message-ID":"","References":"<20250725235311.7280-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250725235311.7280-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20250510-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35179,"web_url":"https://patchwork.libcamera.org/comment/35179/","msgid":"<2a9d22b7-199a-4e5b-8bbf-331fa1d262b9@protonmail.com>","date":"2025-07-28T07:12:24","subject":"Re: [PATCH] libcamera: v4l2_videodevice: Use ScopeExitActions","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n2025. 07. 26. 1:53 keltezéssel, Laurent Pinchart írta:\n> The V4L2VideoDevice::queueBuffer() function performs the same cleanup\n> action in many error paths. Use ScopeExitActions to simplify it.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/v4l2_videodevice.cpp | 12 ++++--------\n> 1 file changed, 4 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 71cc7e895d8c..5f57e546e80b 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1646,6 +1646,7 @@ int V4L2VideoDevice::releaseBuffers()\n> int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> {\n> \tstruct v4l2_plane v4l2Planes[VIDEO_MAX_PLANES] = {};\n> +\tutils::ScopeExitActions actions;\n> \tstruct v4l2_buffer buf = {};\n> \tint ret;\n> \n> @@ -1668,6 +1669,8 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> +\tactions += [&]() { cache_->put(buf.index); };\n\nI think it can be argued that `V4L2VideoDevice::queueBuffer` should be considered\na \"hot path\" in libcamera. And for that reason I think avoiding the constant memory\nallocations of `utils::ScopeExitActions` would be preferable.\n\nI think adding https://www.en.cppreference.com/w/cpp/experimental/scope_exit.html\nshould be simple to do, and it would address the above.\n\n\nRegards,\nBarnabás Pőcze\n\n\n> +\n> \tbuf.index = ret;\n> \tbuf.type = bufferType_;\n> \tbuf.memory = memoryType_;\n> @@ -1683,15 +1686,11 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \t */\n> \tif (planes.size() < numV4l2Planes) {\n> \t\tLOG(V4L2, Error) << \"Frame buffer has too few planes\";\n> -\t\tcache_->put(buf.index);\n> -\n> \t\treturn -EINVAL;\n> \t}\n> \n> \tif (planes.size() != numV4l2Planes && !buffer->_d()->isContiguous()) {\n> \t\tLOG(V4L2, Error) << \"Device format requires contiguous buffer\";\n> -\t\tcache_->put(buf.index);\n> -\n> \t\treturn -EINVAL;\n> \t}\n> \n> @@ -1734,8 +1733,6 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \t\t\t\tif (i != planes.size() - 1 && bytesused != length) {\n> \t\t\t\t\tLOG(V4L2, Error)\n> \t\t\t\t\t\t<< \"Holes in multi-planar buffer not supported\";\n> -\t\t\t\t\tcache_->put(buf.index);\n> -\n> \t\t\t\t\treturn -EINVAL;\n> \t\t\t\t}\n> \t\t\t}\n> @@ -1785,8 +1782,6 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \t\tLOG(V4L2, Error)\n> \t\t\t<< \"Failed to queue buffer \" << buf.index << \": \"\n> \t\t\t<< strerror(-ret);\n> -\t\tcache_->put(buf.index);\n> -\n> \t\treturn ret;\n> \t}\n> \n> @@ -1798,6 +1793,7 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \n> \tqueuedBuffers_[buf.index] = buffer;\n> \n> +\tactions.release();\n> \treturn 0;\n> }\n> \n> \n> base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EF7AC3237\n\tfor ;\n\tMon, 28 Jul 2025 07:12:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 31E4469142;\n\tMon, 28 Jul 2025 09:12:33 +0200 (CEST)","from mail-10628.protonmail.ch (mail-10628.protonmail.ch\n\t[79.135.106.28])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F5D0614B6\n\tfor ;\n\tMon, 28 Jul 2025 09:12:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"WAKqFF6e\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1753686748; x=1753945948;\n\tbh=k1SvBp+atqqlaR/2wzSR2ukNwYZ7VJCL9616DHWApQY=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=WAKqFF6eEWh/8PMuywlF7AHuAsR5CyT7wVAGWjrFyRNcETmZiWchUEZVfi77n2J4i\n\tdwHZke1uh844uGvOEQ2K3LCUHAlbHY70gyVqN+OgOnGNbRUz1kPzT7AyMrXhTjz9an\n\t9TjIBNhTBhUM3lkJuVzn9pdubrJGI6LTyEYrqhpsbopVKlXbgqlFuYgEbXb3otOFfP\n\tEwGghtiQ4ofdSeE9GNzHnl4F64Fg/fCyoVrftujTta02L9vvs2cDf358DMjTWl7P3E\n\tmebblqX1qv5sRrpNEq0STZq0C+wpDzgRyMXc0D/f7049Kk/7zciXZy7iAXknXZBkV4\n\tiF0fbr4PGo8Tg==","Date":"Mon, 28 Jul 2025 07:12:24 +0000","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","From":"=?utf-8?q?P=C5=91cze_Barnab=C3=A1s?= ","Cc":"Han-Lin Chen ,\n\tHarvey Yang ","Subject":"Re: [PATCH] libcamera: v4l2_videodevice: Use ScopeExitActions","Message-ID":"<2a9d22b7-199a-4e5b-8bbf-331fa1d262b9@protonmail.com>","In-Reply-To":"<20250725235311.7280-1-laurent.pinchart@ideasonboard.com>","References":"<20250725235311.7280-1-laurent.pinchart@ideasonboard.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"8f2b6c0a9a3cd88e07b5306274ac4ac69d05b750","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35190,"web_url":"https://patchwork.libcamera.org/comment/35190/","msgid":"<20250728104756.GE787@pendragon.ideasonboard.com>","date":"2025-07-28T10:47:56","subject":"Re: [PATCH] libcamera: v4l2_videodevice: Use ScopeExitActions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jul 28, 2025 at 07:12:24AM +0000, Barnabás Pőcze wrote:\n> 2025. 07. 26. 1:53 keltezéssel, Laurent Pinchart írta:\n> > The V4L2VideoDevice::queueBuffer() function performs the same cleanup\n> > action in many error paths. Use ScopeExitActions to simplify it.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/v4l2_videodevice.cpp | 12 ++++--------\n> > 1 file changed, 4 insertions(+), 8 deletions(-)\n> > \n> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> > index 71cc7e895d8c..5f57e546e80b 100644\n> > --- a/src/libcamera/v4l2_videodevice.cpp\n> > +++ b/src/libcamera/v4l2_videodevice.cpp\n> > @@ -1646,6 +1646,7 @@ int V4L2VideoDevice::releaseBuffers()\n> > int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> > {\n> > \tstruct v4l2_plane v4l2Planes[VIDEO_MAX_PLANES] = {};\n> > +\tutils::ScopeExitActions actions;\n> > \tstruct v4l2_buffer buf = {};\n> > \tint ret;\n> > \n> > @@ -1668,6 +1669,8 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> > \tif (ret < 0)\n> > \t\treturn ret;\n> > \n> > +\tactions += [&]() { cache_->put(buf.index); };\n> \n> I think it can be argued that `V4L2VideoDevice::queueBuffer` should be considered\n> a \"hot path\" in libcamera. And for that reason I think avoiding the constant memory\n> allocations of `utils::ScopeExitActions` would be preferable.\n\nGood point. I agree with you.\n\n> I think adding https://www.en.cppreference.com/w/cpp/experimental/scope_exit.html\n> should be simple to do, and it would address the above.\n\nI'll give that a try.\n\n> > +\n> > \tbuf.index = ret;\n> > \tbuf.type = bufferType_;\n> > \tbuf.memory = memoryType_;\n> > @@ -1683,15 +1686,11 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> > \t */\n> > \tif (planes.size() < numV4l2Planes) {\n> > \t\tLOG(V4L2, Error) << \"Frame buffer has too few planes\";\n> > -\t\tcache_->put(buf.index);\n> > -\n> > \t\treturn -EINVAL;\n> > \t}\n> > \n> > \tif (planes.size() != numV4l2Planes && !buffer->_d()->isContiguous()) {\n> > \t\tLOG(V4L2, Error) << \"Device format requires contiguous buffer\";\n> > -\t\tcache_->put(buf.index);\n> > -\n> > \t\treturn -EINVAL;\n> > \t}\n> > \n> > @@ -1734,8 +1733,6 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> > \t\t\t\tif (i != planes.size() - 1 && bytesused != length) {\n> > \t\t\t\t\tLOG(V4L2, Error)\n> > \t\t\t\t\t\t<< \"Holes in multi-planar buffer not supported\";\n> > -\t\t\t\t\tcache_->put(buf.index);\n> > -\n> > \t\t\t\t\treturn -EINVAL;\n> > \t\t\t\t}\n> > \t\t\t}\n> > @@ -1785,8 +1782,6 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> > \t\tLOG(V4L2, Error)\n> > \t\t\t<< \"Failed to queue buffer \" << buf.index << \": \"\n> > \t\t\t<< strerror(-ret);\n> > -\t\tcache_->put(buf.index);\n> > -\n> > \t\treturn ret;\n> > \t}\n> > \n> > @@ -1798,6 +1793,7 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> > \n> > \tqueuedBuffers_[buf.index] = buffer;\n> > \n> > +\tactions.release();\n> > \treturn 0;\n> > }\n> > \n> > \n> > base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05BC5C3237\n\tfor ;\n\tMon, 28 Jul 2025 10:48:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BACD669153;\n\tMon, 28 Jul 2025 12:48:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7B3B6904C\n\tfor ;\n\tMon, 28 Jul 2025 12:48:04 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 99935446;\n\tMon, 28 Jul 2025 12:47:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QCZs542J\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753699642;\n\tbh=0sAWhe0aOcxqgWpBo5DR9Yr2wRUGbqCwxl3ugyQIpPo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QCZs542JT9IN++ahDOT7qbpdVhi925zFjCreG2K/bbU8bmlgA1FN82QGl68ulcnTW\n\tEyvIN2WVfVtVAJ2y+tgEzJETxrj3tD53ILINNsX8t0XPxr4pThT+/2Yeok2ZifI4hp\n\tys8HSJr4wAuVOJJ6g52pzIa3dqnG7z2lX/c+Lsag=","Date":"Mon, 28 Jul 2025 13:47:56 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?P=C5=91cze_Barnab=C3=A1s?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tHan-Lin Chen ,\n\tHarvey Yang ","Subject":"Re: [PATCH] libcamera: v4l2_videodevice: Use ScopeExitActions","Message-ID":"<20250728104756.GE787@pendragon.ideasonboard.com>","References":"<20250725235311.7280-1-laurent.pinchart@ideasonboard.com>\n\t<2a9d22b7-199a-4e5b-8bbf-331fa1d262b9@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<2a9d22b7-199a-4e5b-8bbf-331fa1d262b9@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]