[{"id":35113,"web_url":"https://patchwork.libcamera.org/comment/35113/","msgid":"<38f2f9a5-5af4-4ccd-879d-6a885336d878@ideasonboard.com>","date":"2025-07-25T07:18:58","subject":"Re: [PATCH] gstreamer: Make format_map[] const","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 07. 25. 6:16 keltezéssel, Umang Jain írta:\n> format_map[] is the mapping between GstVideoFormat and libcamera's\n> PixelFormat. Make it const as it is not meant to be changed.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Barnabás Pőcze \n\n\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index a548b0c1..66fc8642 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -13,7 +13,7 @@\n> \n> using namespace libcamera;\n> \n> -static struct {\n> +static const struct {\n> \tGstVideoFormat gst_format;\n> \tPixelFormat format;\n> } format_map[] = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD80BC3237\n\tfor ;\n\tFri, 25 Jul 2025 07:19:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B2C469086;\n\tFri, 25 Jul 2025 09:19:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED2EE69080\n\tfor ;\n\tFri, 25 Jul 2025 09:19:01 +0200 (CEST)","from [192.168.33.15] (185.221.140.39.nat.pool.zt.hu\n\t[185.221.140.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6181E9CE;\n\tFri, 25 Jul 2025 09:18:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pwhwJ6zs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753427902;\n\tbh=CYwYHTCMVqo6lZTzZnlGqFU9xra/aSpYeBkLTXd5leY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=pwhwJ6zshly/mQrslxwmh2VYrMQbdCZhMEJtQlxnBgwz23apAd3IQ4uAanOejudBq\n\txoklY2DAT03SrqYeBQMMgDZQXK3SE0OJOcBYTKht7KuDaKlYOwV8QwSw0MihzOH8Jl\n\t0Q6nCerfAILkVY2bE5BLZO9utO+KvgQf/HL4wVWE=","Message-ID":"<38f2f9a5-5af4-4ccd-879d-6a885336d878@ideasonboard.com>","Date":"Fri, 25 Jul 2025 09:18:58 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] gstreamer: Make format_map[] const","To":"Umang Jain , libcamera-devel@lists.libcamera.org","References":"<20250725041617.9715-1-uajain@igalia.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250725041617.9715-1-uajain@igalia.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35130,"web_url":"https://patchwork.libcamera.org/comment/35130/","msgid":"<20250725114754.GF11202@pendragon.ideasonboard.com>","date":"2025-07-25T11:47:54","subject":"Re: [PATCH] gstreamer: Make format_map[] const","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jul 25, 2025 at 09:18:58AM +0200, Barnabás Pőcze wrote:\n> 2025. 07. 25. 6:16 keltezéssel, Umang Jain írta:\n> > format_map[] is the mapping between GstVideoFormat and libcamera's\n> > PixelFormat. Make it const as it is not meant to be changed.\n> > \n> > Signed-off-by: Umang Jain \n> \n> Reviewed-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> > index a548b0c1..66fc8642 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > @@ -13,7 +13,7 @@\n> > \n> > using namespace libcamera;\n> > \n> > -static struct {\n> > +static const struct {\n> > \tGstVideoFormat gst_format;\n> > \tPixelFormat format;\n> > } format_map[] = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB358C3237\n\tfor ;\n\tFri, 25 Jul 2025 11:48:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6EF6690C5;\n\tFri, 25 Jul 2025 13:48:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FD65690A6\n\tfor ;\n\tFri, 25 Jul 2025 13:47:59 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 050BC819;\n\tFri, 25 Jul 2025 13:47:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BzAv8MrN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753444039;\n\tbh=A+q/gY132x3Pz8QmL1gO04WBUpS+KlB7omnhCTZaK7M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BzAv8MrNF0JAPfMsSZzYzUVoEXmmBU9D9sSv7s6XQ44ZJNqlp9PSLzXa0JsnMyine\n\tw0wy5dotc9cJl6OiwPQfxdfsMcq1il403p5Fa5H/ooh6nCVpYeLAmYx6XgyzLss2fy\n\t31442u4xAuBo19fQ4dMDmCREUzrXuGAd34GNkR3I=","Date":"Fri, 25 Jul 2025 14:47:54 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Umang Jain , libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] gstreamer: Make format_map[] const","Message-ID":"<20250725114754.GF11202@pendragon.ideasonboard.com>","References":"<20250725041617.9715-1-uajain@igalia.com>\n\t<38f2f9a5-5af4-4ccd-879d-6a885336d878@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<38f2f9a5-5af4-4ccd-879d-6a885336d878@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]