[{"id":35108,"web_url":"https://patchwork.libcamera.org/comment/35108/","msgid":"","date":"2025-07-24T17:58:17","subject":"Re: [PATCH] apps: lc-compliance: Replace manual include guard with\n\tpragma once","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Laurent\n\nOn 24/07/2025 11:56, Laurent Pinchart wrote:\n> libcamera uses #pragma once for include guards. One manual guard crept\n> in lc-compliance, replace it.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\nReviewed-by: Daniel Scally \n> src/apps/lc-compliance/test_base.h | 6 +-----\n> 1 file changed, 1 insertion(+), 5 deletions(-)\n>\n> diff --git a/src/apps/lc-compliance/test_base.h b/src/apps/lc-compliance/test_base.h\n> index 0f32e3c21d0e..3451ef5f3724 100644\n> --- a/src/apps/lc-compliance/test_base.h\n> +++ b/src/apps/lc-compliance/test_base.h\n> @@ -4,9 +4,7 @@\n> *\n> * Base definitions for tests\n> */\n> -\n> -#ifndef __LC_COMPLIANCE_TEST_BASE_H__\n> -#define __LC_COMPLIANCE_TEST_BASE_H__\n> +#pragma once\n>\n> #include \n>\n> @@ -20,5 +18,3 @@ protected:\n>\n> \tstd::shared_ptr camera_;\n> };\n> -\n> -#endif /* __LC_COMPLIANCE_TEST_BASE_H__ */\n>\n> base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe\n> prerequisite-patch-id: 8fcc899f628816b84d9ac265da673521706f45e2\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CBBF5C3237\n\tfor ;\n\tThu, 24 Jul 2025 17:58:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 871F56903A;\n\tThu, 24 Jul 2025 19:58:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19ADB614D4\n\tfor ;\n\tThu, 24 Jul 2025 19:58:21 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7C9A606\n\tfor ;\n\tThu, 24 Jul 2025 19:57:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"crUPh/bH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753379862;\n\tbh=pQdpPOe0sztSCNF6NKlcqt1MnQamhs0K6Y5aPsB6Wes=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=crUPh/bHz4Nmptb1ObYKhpFqlsbL1d4RsXZLS+l3xu9HWi47voadYj5d4kBCOnm0m\n\tBBIyDLV3/BnFOeee1opPHFPIRyh6LQbpYHCLipZrFy4Y5H4ytIMpibr5w8emzVQR9A\n\tRKyU3mg+rkQJJH2MdH76/DYUamYKdl2XqyCDnQpE=","Message-ID":"","Date":"Thu, 24 Jul 2025 18:58:17 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] apps: lc-compliance: Replace manual include guard with\n\tpragma once","To":"libcamera-devel@lists.libcamera.org","References":"<20250724105626.12718-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20250724105626.12718-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35133,"web_url":"https://patchwork.libcamera.org/comment/35133/","msgid":"","date":"2025-07-25T12:17:35","subject":"Re: [PATCH] apps: lc-compliance: Replace manual include guard with\n\tpragma once","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Thu, Jul 24, 2025 at 01:56:26PM +0300, Laurent Pinchart wrote:\n> libcamera uses #pragma once for include guards. One manual guard crept\n> in lc-compliance, replace it.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/apps/lc-compliance/test_base.h | 6 +-----\n> 1 file changed, 1 insertion(+), 5 deletions(-)\n>\n> diff --git a/src/apps/lc-compliance/test_base.h b/src/apps/lc-compliance/test_base.h\n> index 0f32e3c21d0e..3451ef5f3724 100644\n> --- a/src/apps/lc-compliance/test_base.h\n> +++ b/src/apps/lc-compliance/test_base.h\n> @@ -4,9 +4,7 @@\n> *\n> * Base definitions for tests\n> */\n> -\n> -#ifndef __LC_COMPLIANCE_TEST_BASE_H__\n> -#define __LC_COMPLIANCE_TEST_BASE_H__\n> +#pragma once\n>\n> #include \n>\n> @@ -20,5 +18,3 @@ protected:\n>\n> \tstd::shared_ptr camera_;\n> };\n> -\n> -#endif /* __LC_COMPLIANCE_TEST_BASE_H__ */\n>\n> base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe\n> prerequisite-patch-id: 8fcc899f628816b84d9ac265da673521706f45e2\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FA3EBDCC1\n\tfor ;\n\tFri, 25 Jul 2025 12:17:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04641690CC;\n\tFri, 25 Jul 2025 14:17:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35748690A6\n\tfor ;\n\tFri, 25 Jul 2025 14:17:44 +0200 (CEST)","from ideasonboard.com (mob-5-90-139-29.net.vodafone.it\n\t[5.90.139.29])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB445EFE;\n\tFri, 25 Jul 2025 14:17:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T2NwlvH7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753445824;\n\tbh=/QAGyGbZvoyu08oeBa/qmGFOduSFNMMNbbJi/nQrNdE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=T2NwlvH7xZzvUBSr7RKNZTR1C4Qyheif4rZ8uRmkvSeEc/biWFY7VmHa5zttIPfLt\n\ti0sidnbmGuw82wXSxukZwTeLivaY3qaPcPowAWcObwv/qAXOJLKTjE3NnqbQuiP2+z\n\tpyKmvRVwrxi4oiZbnUcfGck6wX8BpNDb1DH1GPp0=","Date":"Fri, 25 Jul 2025 14:17:35 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] apps: lc-compliance: Replace manual include guard with\n\tpragma once","Message-ID":"","References":"<20250724105626.12718-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250724105626.12718-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]