{"id":23925,"url":"https://patchwork.libcamera.org/api/patches/23925/?format=json","web_url":"https://patchwork.libcamera.org/patch/23925/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250724065256.75175-9-dan.scally@ideasonboard.com>","date":"2025-07-24T06:52:54","name":"[08/10] libcamera: mali-c55: Move entity parameter from constructor to ::init()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d4812aeac408e5592c3e7ae05894071c15557de1","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23925/mbox/","series":[{"id":5319,"url":"https://patchwork.libcamera.org/api/series/5319/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5319","date":"2025-07-24T06:52:46","name":"Support memory input mode in mali-c55","version":1,"mbox":"https://patchwork.libcamera.org/series/5319/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23925/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23925/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9C66C332B\n\tfor ;\n\tThu, 24 Jul 2025 06:53:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4511569097;\n\tThu, 24 Jul 2025 08:53:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 567F16907F\n\tfor ;\n\tThu, 24 Jul 2025 08:53:16 +0200 (CEST)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7882817D1;\n\tThu, 24 Jul 2025 08:52:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"acxyN25+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753339957;\n\tbh=XaSrcH/b1VvHuoduvqs+Vs1M5PeiCb0C1Nftnfe0PQ8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=acxyN25+OmjdQwNmR45RE6uYMBR+pJFbqvOBMY5oYEHfJS1N7AuhAgAsJaZSRrTOP\n\twY3IDNvyXY47P/eZL6ZRc6jRSJSDQiIZeBMDuzb+TsJNymE49JniN6I8yVGtqLCFP9\n\trxRpGgiCbcVlSQQzatt5PcH6zqMVop94jAnGoLjM=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ","Subject":"[PATCH 08/10] libcamera: mali-c55: Move entity parameter from\n\tconstructor to ::init()","Date":"Thu, 24 Jul 2025 07:52:54 +0100","Message-Id":"<20250724065256.75175-9-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20250724065256.75175-1-dan.scally@ideasonboard.com>","References":"<20250724065256.75175-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The MaliC55CameraData class takes a MediaEntity in its constructor.\nWhen we support the memory input mode we won't have that when we\nwant to construct the class, so move the parameter to the init()\nfunction instead.\n\nSigned-off-by: Daniel Scally \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 25540ba1..5944823d 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -92,12 +92,12 @@ struct MaliC55FrameInfo {\n class MaliC55CameraData : public Camera::Private\n {\n public:\n-\tMaliC55CameraData(PipelineHandler *pipe, MediaEntity *entity)\n-\t\t: Camera::Private(pipe), entity_(entity)\n+\tMaliC55CameraData(PipelineHandler *pipe)\n+\t\t: Camera::Private(pipe)\n \t{\n \t}\n \n-\tint init();\n+\tint init(MediaEntity *entity);\n \tint loadIPA();\n \n \t/* Deflect these functionalities to either TPG or CameraSensor. */\n@@ -134,10 +134,12 @@ private:\n \tSize tpgResolution_;\n };\n \n-int MaliC55CameraData::init()\n+int MaliC55CameraData::init(MediaEntity *entity)\n {\n \tint ret;\n \n+\tentity_ = entity;\n+\n \tsd_ = std::make_unique(entity_);\n \tret = sd_->open();\n \tif (ret) {\n@@ -1567,9 +1569,9 @@ bool PipelineHandlerMaliC55::registerTPGCamera(MediaLink *link)\n \t}\n \n \tstd::unique_ptr data =\n-\t\tstd::make_unique(this, link->source()->entity());\n+\t\tstd::make_unique(this);\n \n-\tif (data->init())\n+\tif (data->init(link->source()->entity()))\n \t\treturn false;\n \n \treturn registerMaliCamera(std::move(data), name);\n@@ -1594,8 +1596,8 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n \t\t\tcontinue;\n \n \t\tstd::unique_ptr data =\n-\t\t\tstd::make_unique(this, sensor);\n-\t\tif (data->init())\n+\t\t\tstd::make_unique(this);\n+\t\tif (data->init(sensor))\n \t\t\treturn false;\n \n \t\tdata->properties_ = data->sensor_->properties();\n","prefixes":["08/10"]}