[{"id":35080,"web_url":"https://patchwork.libcamera.org/comment/35080/","msgid":"<175334373050.560048.5140189941945159949@ping.linuxembedded.co.uk>","date":"2025-07-24T07:55:30","subject":"Re: [PATCH 04/10] libcamera: bayer_format: Add CRU packing to\n\tBayerFormat","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2025-07-24 07:52:50)\n> Add an entry to the BayerFormat::Packing enum to denote pixel formats\n> encoding bayer data and packed following the Renesas RZ/G2L CRU style.\n> \n\nCan this squash into 6/10? or is it used in 5/10 ?\n\n\n\n> Signed-off-by: Daniel Scally \n> ---\n> include/libcamera/internal/bayer_format.h | 1 +\n> src/libcamera/bayer_format.cpp | 2 ++\n> 2 files changed, 3 insertions(+)\n> \n> diff --git a/include/libcamera/internal/bayer_format.h b/include/libcamera/internal/bayer_format.h\n> index 9b6b5b58..4606a691 100644\n> --- a/include/libcamera/internal/bayer_format.h\n> +++ b/include/libcamera/internal/bayer_format.h\n> @@ -37,6 +37,7 @@ public:\n> IPU3 = 2,\n> PISP1 = 3,\n> PISP2 = 4,\n> + CRU = 5,\n> };\n> \n> constexpr BayerFormat()\n> diff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\n> index 89fe10ed..686a5c1e 100644\n> --- a/src/libcamera/bayer_format.cpp\n> +++ b/src/libcamera/bayer_format.cpp\n> @@ -68,6 +68,8 @@ namespace libcamera {\n> * \\brief Format uses PISP mode 1 compression\n> * \\var BayerFormat::Packing::PISP2\n> * \\brief Format uses PISP mode 2 compression\n> + * \\var BayerFormat::Packing::CRU\n> + * \\brief Format uses Renesas RZ/G2L CRU style packing\n> */\n> \n> namespace {\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6580C3237\n\tfor ;\n\tThu, 24 Jul 2025 07:55:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC564690B8;\n\tThu, 24 Jul 2025 09:55:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B2706909B\n\tfor ;\n\tThu, 24 Jul 2025 09:55:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C698C79;\n\tThu, 24 Jul 2025 09:54:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cF0JXu+R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753343695;\n\tbh=m8ZVblXnWRaEIjfkD0YjCtebEKmT/E/9c7/EIKdI6Is=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=cF0JXu+ReRrjbixq5K9AkSraPsVgYdYDJ3205ikqRgjmFJY6ysCx1JeuJXh7cPCZv\n\thV9DRp2r+sH9FGm3q194kzV3UyIc2b1OsyN9QE2oDmfOtT80gSCln+Mo1XfCPApKAi\n\tDWRx+5wzvP9ux7FupSpwyUf3833X27FL8HTjOZjk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250724065256.75175-5-dan.scally@ideasonboard.com>","References":"<20250724065256.75175-1-dan.scally@ideasonboard.com>\n\t<20250724065256.75175-5-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH 04/10] libcamera: bayer_format: Add CRU packing to\n\tBayerFormat","From":"Kieran Bingham ","Cc":"Daniel Scally ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 24 Jul 2025 08:55:30 +0100","Message-ID":"<175334373050.560048.5140189941945159949@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36550,"web_url":"https://patchwork.libcamera.org/comment/36550/","msgid":"<3jtupn6aha4fy4kiw7ta4ed2wgtvqm5conbr5x5ld5vyono3eb@7i3hw5vhecce>","date":"2025-10-30T11:32:35","subject":"Re: [PATCH 04/10] libcamera: bayer_format: Add CRU packing to\n\tBayerFormat","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Dan\n\nOn Thu, Jul 24, 2025 at 07:52:50AM +0100, Daniel Scally wrote:\n> Add an entry to the BayerFormat::Packing enum to denote pixel formats\n> encoding bayer data and packed following the Renesas RZ/G2L CRU style.\n\nHere and in the comment below, I would drop the G2L SoC name and refer\nto CRU only\n\n>\n> Signed-off-by: Daniel Scally \n\nWith this\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/internal/bayer_format.h | 1 +\n> src/libcamera/bayer_format.cpp | 2 ++\n> 2 files changed, 3 insertions(+)\n>\n> diff --git a/include/libcamera/internal/bayer_format.h b/include/libcamera/internal/bayer_format.h\n> index 9b6b5b58..4606a691 100644\n> --- a/include/libcamera/internal/bayer_format.h\n> +++ b/include/libcamera/internal/bayer_format.h\n> @@ -37,6 +37,7 @@ public:\n> \t\tIPU3 = 2,\n> \t\tPISP1 = 3,\n> \t\tPISP2 = 4,\n> +\t\tCRU = 5,\n> \t};\n>\n> \tconstexpr BayerFormat()\n> diff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\n> index 89fe10ed..686a5c1e 100644\n> --- a/src/libcamera/bayer_format.cpp\n> +++ b/src/libcamera/bayer_format.cpp\n> @@ -68,6 +68,8 @@ namespace libcamera {\n> * \\brief Format uses PISP mode 1 compression\n> * \\var BayerFormat::Packing::PISP2\n> * \\brief Format uses PISP mode 2 compression\n> + * \\var BayerFormat::Packing::CRU\n> + * \\brief Format uses Renesas RZ/G2L CRU style packing\n> */\n>\n> namespace {\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCBB4BE080\n\tfor ;\n\tThu, 30 Oct 2025 11:32:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60F8F608CD;\n\tThu, 30 Oct 2025 12:32:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17DFF603ED\n\tfor ;\n\tThu, 30 Oct 2025 12:32:39 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 263FD16A8;\n\tThu, 30 Oct 2025 12:30:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KEg572bL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761823849;\n\tbh=pP1muUUnTNtEeG+I5eUWcav8Fd1nFILqR+vOd7lRa80=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KEg572bLa6+1VxNKJUvJuSyOor/N/m8H8XITO1XXwUYECOloJ7/J3VmJlQYlHk/ME\n\tU06gKTOtQUE59SYf6fw31aZarVj8JAK0Le1duOm+NpWD0LZzMljAhIG/CvFr8WwVef\n\t+SBD7aU12nHDb3FB6lfSmdX8lcEVap/XlbxV4b+0=","Date":"Thu, 30 Oct 2025 12:32:35 +0100","From":"Jacopo Mondi ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 04/10] libcamera: bayer_format: Add CRU packing to\n\tBayerFormat","Message-ID":"<3jtupn6aha4fy4kiw7ta4ed2wgtvqm5conbr5x5ld5vyono3eb@7i3hw5vhecce>","References":"<20250724065256.75175-1-dan.scally@ideasonboard.com>\n\t<20250724065256.75175-5-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250724065256.75175-5-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]