[{"id":35076,"web_url":"https://patchwork.libcamera.org/comment/35076/","msgid":"<175334345793.560048.12074653763147652598@ping.linuxembedded.co.uk>","date":"2025-07-24T07:50:57","subject":"Re: [PATCH 01/10] include: linux: Add Renesas RZ/G2L CRU Pixel\n\tFormats","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2025-07-24 07:52:47)\n> Add the RZ/G2L's Pixel Formats, which are not yet upstream, to\n> videodev2.h\n> \n> Signed-off-by: Daniel Scally \n\n\nAcked-by: Kieran Bingham \n\nI wonder if we should keep 'our changes' we make on top of the upstream\nkernel separated in a patch somehow - but we'd have to make something\nthen generate the 'includes folder' from a template and some patches\nwhich just sounds awkward - so I guess we should just keep tracking them\nmanually for now.\n\n\n\n> ---\n> include/linux/videodev2.h | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> index 317d063a..defc80ef 100644\n> --- a/include/linux/videodev2.h\n> +++ b/include/linux/videodev2.h\n> @@ -801,6 +801,12 @@ struct v4l2_pix_format {\n> #define V4L2_PIX_FMT_PISP_COMP2_BGGR v4l2_fourcc('P', 'C', '2', 'B') /* PiSP 8-bit mode 2 compressed BGGR bayer */\n> #define V4L2_PIX_FMT_PISP_COMP2_MONO v4l2_fourcc('P', 'C', '2', 'M') /* PiSP 8-bit mode 2 compressed monochrome */\n> \n> +/* Renesas RZ/V2H CRU packed formats. 64-bit units with contiguous pixels */\n> +#define V4L2_PIX_FMT_RAW_CRU10 v4l2_fourcc('C', 'R', '1', '0')\n> +#define V4L2_PIX_FMT_RAW_CRU12 v4l2_fourcc('C', 'R', '1', '2')\n> +#define V4L2_PIX_FMT_RAW_CRU14 v4l2_fourcc('C', 'R', '1', '4')\n> +#define V4L2_PIX_FMT_RAW_CRU20 v4l2_fourcc('C', 'R', '2', '0')\n> +\n> /* SDR formats - used only for Software Defined Radio devices */\n> #define V4L2_SDR_FMT_CU8 v4l2_fourcc('C', 'U', '0', '8') /* IQ u8 */\n> #define V4L2_SDR_FMT_CU16LE v4l2_fourcc('C', 'U', '1', '6') /* IQ u16le */\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 892BEBDCC1\n\tfor ;\n\tThu, 24 Jul 2025 07:51:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 391576909C;\n\tThu, 24 Jul 2025 09:51:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 877E36908E\n\tfor ;\n\tThu, 24 Jul 2025 09:51:00 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 846B0C79;\n\tThu, 24 Jul 2025 09:50:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GxZ7rJta\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753343421;\n\tbh=U3sEy8ZzOwq31Mwn5NwA4sdAz8bFNWgjcitWeylrfnw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=GxZ7rJta/px5py1WENvU+Ck/xQhQyycIC+SkvXjOt3/s9WefawfUGbE2VB1AsR2gR\n\tKVyM/slOe/JVxrYaj/0dJb230/jkynBVrPiPRMthrUzdnJAFImmTag0W5jbyb+TNNR\n\tSEIgRKj0IJdDtxB5Y60Q3n4iJhQZco3Ou7vL63Uc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250724065256.75175-2-dan.scally@ideasonboard.com>","References":"<20250724065256.75175-1-dan.scally@ideasonboard.com>\n\t<20250724065256.75175-2-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH 01/10] include: linux: Add Renesas RZ/G2L CRU Pixel\n\tFormats","From":"Kieran Bingham ","Cc":"Daniel Scally ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 24 Jul 2025 08:50:57 +0100","Message-ID":"<175334345793.560048.12074653763147652598@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36547,"web_url":"https://patchwork.libcamera.org/comment/36547/","msgid":"","date":"2025-10-30T11:03:40","subject":"Re: [PATCH 01/10] include: linux: Add Renesas RZ/G2L CRU Pixel\n\tFormats","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Dan\n\nOn Thu, Jul 24, 2025 at 07:52:47AM +0100, Daniel Scally wrote:\n> Add the RZ/G2L's Pixel Formats, which are not yet upstream, to\n\nAre the formats specific to RZ/G2L ? Isn't this about just the CRU\nunits (found in other RZ SoCs?)\n\n> videodev2.h\n\nCRU pixel formats have been merged in v6.17 as\n78584431e2ce (\"media: v4l2: Add Renesas Camera Receiver Unit pixel formats\")\n\nSo I guess you can just use utils/update-kernel-headers.sh with\nrecent kernel sources\n\n>\n> Signed-off-by: Daniel Scally \n> ---\n> include/linux/videodev2.h | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> index 317d063a..defc80ef 100644\n> --- a/include/linux/videodev2.h\n> +++ b/include/linux/videodev2.h\n> @@ -801,6 +801,12 @@ struct v4l2_pix_format {\n> #define V4L2_PIX_FMT_PISP_COMP2_BGGR\tv4l2_fourcc('P', 'C', '2', 'B') /* PiSP 8-bit mode 2 compressed BGGR bayer */\n> #define V4L2_PIX_FMT_PISP_COMP2_MONO\tv4l2_fourcc('P', 'C', '2', 'M') /* PiSP 8-bit mode 2 compressed monochrome */\n>\n> +/* Renesas RZ/V2H CRU packed formats. 64-bit units with contiguous pixels */\n> +#define V4L2_PIX_FMT_RAW_CRU10\tv4l2_fourcc('C', 'R', '1', '0')\n> +#define V4L2_PIX_FMT_RAW_CRU12\tv4l2_fourcc('C', 'R', '1', '2')\n> +#define V4L2_PIX_FMT_RAW_CRU14\tv4l2_fourcc('C', 'R', '1', '4')\n> +#define V4L2_PIX_FMT_RAW_CRU20\tv4l2_fourcc('C', 'R', '2', '0')\n> +\n> /* SDR formats - used only for Software Defined Radio devices */\n> #define V4L2_SDR_FMT_CU8 v4l2_fourcc('C', 'U', '0', '8') /* IQ u8 */\n> #define V4L2_SDR_FMT_CU16LE v4l2_fourcc('C', 'U', '1', '6') /* IQ u16le */\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 700E7BE080\n\tfor ;\n\tThu, 30 Oct 2025 11:03:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33C1260891;\n\tThu, 30 Oct 2025 12:03:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19E84603ED\n\tfor ;\n\tThu, 30 Oct 2025 12:03:43 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E8592E1F;\n\tThu, 30 Oct 2025 12:01:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UqychN5k\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761822113;\n\tbh=CgeXZRX6n5znxYog1fv6IYaiSJq2XB7hb6ZRdnrP9Xc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UqychN5kj1agL3Pw61iCpgae6nVgBPZmA1OytxKz36a9+MXbbCYqaJIQPTnIa0M1e\n\tPbc7p/P+bTKLXYRIryL32Uv+7FMzwop1HMG0Jp5YSCcq6J47Rhrb4sGTmY5ZzS7CHP\n\tjvcNlZOgNgyQxinjbszlvXFE4HoYICg/fLFAfcm8=","Date":"Thu, 30 Oct 2025 12:03:40 +0100","From":"Jacopo Mondi ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 01/10] include: linux: Add Renesas RZ/G2L CRU Pixel\n\tFormats","Message-ID":"","References":"<20250724065256.75175-1-dan.scally@ideasonboard.com>\n\t<20250724065256.75175-2-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250724065256.75175-2-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]