[{"id":35065,"web_url":"https://patchwork.libcamera.org/comment/35065/","msgid":"","date":"2025-07-24T03:20:01","subject":"Re: [PATCH] libcamera: v4l2_videodevice: Add color space to format\n\tstring representation","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"On Thu, Jul 24, 2025 at 01:39:07AM +0300, Laurent Pinchart wrote:\n> To debug color issues in a pipeline it is necessary to know the color\n> space used. Therefore add the color space to the string representation\n> of V4L2DeviceFormat that is returned by toString() and operator<<(). The\n> format gets for example printed as\n> \n> [0:05:52.981684000] [230] DEBUG RkISP1 rkisp1_path.cpp:468 Configured main resizer video device with 1920x1080-NV12/sYCC\n> \n> Signed-off-by: Laurent Pinchart \n\nLGTM,\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 76bdad40ca8d..71cc7e895d8c 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -446,7 +446,8 @@ const std::string V4L2DeviceFormat::toString() const\n> */\n> std::ostream &operator<<(std::ostream &out, const V4L2DeviceFormat &f)\n> {\n> -\tout << f.size << \"-\" << f.fourcc;\n> +\tout << f.size << \"-\" << f.fourcc << \"/\"\n> +\t << ColorSpace::toString(f.colorSpace);\n> \treturn out;\n> }\n> \n> \n> base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FCACBDCC1\n\tfor ;\n\tThu, 24 Jul 2025 03:20:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78AFE69078;\n\tThu, 24 Jul 2025 05:19:59 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DBD66903A\n\tfor ;\n\tThu, 24 Jul 2025 05:19:57 +0200 (CEST)","from [49.36.71.87] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uemUt-002x4o-Uj; Thu, 24 Jul 2025 05:19:56 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"ZP9MonI+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=JHwdn2q6fNPvHc5B5lNoAMs29cUW2lySsmTa7p8xCWg=;\n\tb=ZP9MonI+R3/gnAohfUtMXk0bvp\n\tqGy4eL5JhUUdKuuqWZ4UXKvM7WYXWYv5ifyv60lo7okYixubNHfkDmLp7Q/Ul2u5/C38hMXCCCH+I\n\tA/5DGbLEIKGx7dQHF0204MQ4IdodOoyoC7j2p/hHraDLkffWyi4U+orJ3h72XT/r+IpvH9/1h5+Ar\n\tL0UDW5FiLeKwWdpEDC+S2w6LpYmUvgi+UKo9tbeIjOSPtepOoyiUvUsbsSI91B28PqcKiNiz9GHal\n\tMN6qtY1U0EEjGiwVTsJqJy0npETYMNptqk2bXm/nxjivq1twbo348fqxnv11AT7jOyNq1o9oyTPFL\n\tjv+Ci6QQ==;","Date":"Thu, 24 Jul 2025 08:50:01 +0530","From":"Umang Jain ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: v4l2_videodevice: Add color space to format\n\tstring representation","Message-ID":"","References":"<20250723223907.23698-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250723223907.23698-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20250510-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35072,"web_url":"https://patchwork.libcamera.org/comment/35072/","msgid":"<175334068257.774292.17216898223697600402@neptunite.rasen.tech>","date":"2025-07-24T07:04:42","subject":"Re: [PATCH] libcamera: v4l2_videodevice: Add color space to format\n\tstring representation","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-07-24 07:39:07)\n> To debug color issues in a pipeline it is necessary to know the color\n> space used. Therefore add the color space to the string representation\n> of V4L2DeviceFormat that is returned by toString() and operator<<(). The\n> format gets for example printed as\n> \n> [0:05:52.981684000] [230] DEBUG RkISP1 rkisp1_path.cpp:468 Configured main resizer video device with 1920x1080-NV12/sYCC\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 76bdad40ca8d..71cc7e895d8c 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -446,7 +446,8 @@ const std::string V4L2DeviceFormat::toString() const\n> */\n> std::ostream &operator<<(std::ostream &out, const V4L2DeviceFormat &f)\n> {\n> - out << f.size << \"-\" << f.fourcc;\n> + out << f.size << \"-\" << f.fourcc << \"/\"\n> + << ColorSpace::toString(f.colorSpace);\n> return out;\n> }\n> \n> \n> base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E28C6BDCC1\n\tfor ;\n\tThu, 24 Jul 2025 07:04:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 959FB690AD;\n\tThu, 24 Jul 2025 09:04:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E922A690A0\n\tfor ;\n\tThu, 24 Jul 2025 09:04:47 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:be7f:7fca:78b4:1343])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A854CC64;\n\tThu, 24 Jul 2025 09:04:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W8fqEh2i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753340649;\n\tbh=F8FWcoLAnO2H70uleJVyBYlGwlxL8V1ONaaFDIEKIz0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=W8fqEh2iAVQQ7uNoiu+l8QrgwOfDaPczhuMpLb+YaEnPRB6e8uPX92Ai+/2BkkKZo\n\t5IuZZyMXWoKKHcYI27mSMT0DA+jGCGZ+K3YToFuvALXIgio/zkdzdTGSl5kdlB1MSL\n\ts8VkpUJ1o1/aXFeVr06KiD0s92yOjnYpzuOD7h10=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250723223907.23698-1-laurent.pinchart@ideasonboard.com>","References":"<20250723223907.23698-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] libcamera: v4l2_videodevice: Add color space to format\n\tstring representation","From":"Paul Elder ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 24 Jul 2025 16:04:42 +0900","Message-ID":"<175334068257.774292.17216898223697600402@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35075,"web_url":"https://patchwork.libcamera.org/comment/35075/","msgid":"<175334285436.560048.2215901654315439198@ping.linuxembedded.co.uk>","date":"2025-07-24T07:40:54","subject":"Re: [PATCH] libcamera: v4l2_videodevice: Add color space to format\n\tstring representation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-07-23 23:39:07)\n> To debug color issues in a pipeline it is necessary to know the color\n> space used. Therefore add the color space to the string representation\n> of V4L2DeviceFormat that is returned by toString() and operator<<(). The\n> format gets for example printed as\n> \n> [0:05:52.981684000] [230] DEBUG RkISP1 rkisp1_path.cpp:468 Configured main resizer video device with 1920x1080-NV12/sYCC\n\nI was about to say ... but we already did this ... and now I see this is\nthe V4L2Device, and we've only extended the V4L2SubDevice so aligning\nboth with this definitely helps.\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/v4l2_videodevice.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 76bdad40ca8d..71cc7e895d8c 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -446,7 +446,8 @@ const std::string V4L2DeviceFormat::toString() const\n> */\n> std::ostream &operator<<(std::ostream &out, const V4L2DeviceFormat &f)\n> {\n> - out << f.size << \"-\" << f.fourcc;\n> + out << f.size << \"-\" << f.fourcc << \"/\"\n> + << ColorSpace::toString(f.colorSpace);\n> return out;\n> }\n> \n> \n> base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E28BC3237\n\tfor ;\n\tThu, 24 Jul 2025 07:41:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DCAC69098;\n\tThu, 24 Jul 2025 09:40:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98BC66907F\n\tfor ;\n\tThu, 24 Jul 2025 09:40:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AC16C78;\n\tThu, 24 Jul 2025 09:40:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SABRhOD/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753342818;\n\tbh=qof+JYEySz5Ihb+hGNRIEONA+7m0uyhkopwWz4w9+MY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=SABRhOD/lzfyyuFWkDEpqNXBc1WF72tMaC8Dyxp+89F0pH1BAx2x0gVypwxfkUokn\n\tfDO/S/XxB/8wgOwJ5x4sbHlL0u7oEYGAz1u3vIND5fTy5Z8TwEWJcMwdQVrboZGk4v\n\tswXitHeshNM2p8aL8xHm92moAFNq98KaD6XIOvt0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250723223907.23698-1-laurent.pinchart@ideasonboard.com>","References":"<20250723223907.23698-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] libcamera: v4l2_videodevice: Add color space to format\n\tstring representation","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 24 Jul 2025 08:40:54 +0100","Message-ID":"<175334285436.560048.2215901654315439198@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]