{"id":23897,"url":"https://patchwork.libcamera.org/api/patches/23897/?format=json","web_url":"https://patchwork.libcamera.org/patch/23897/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250722105627.11961-2-jaslo@ziska.de>","date":"2025-07-22T10:39:28","name":"[v2,1/3] gstreamer: Fix reconfiguration condition check","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"21ec2f36c66449ee62febe2d0fe94f2ba31dd16e","submitter":{"id":173,"url":"https://patchwork.libcamera.org/api/people/173/?format=json","name":"Jaslo Ziska","email":"jaslo@ziska.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23897/mbox/","series":[{"id":5311,"url":"https://patchwork.libcamera.org/api/series/5311/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5311","date":"2025-07-22T10:39:27","name":"gstreamer: Miscellaneous fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/5311/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23897/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23897/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EBE6BDCC1\n\tfor ;\n\tTue, 22 Jul 2025 10:57:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49D5369030;\n\tTue, 22 Jul 2025 12:57:12 +0200 (CEST)","from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de\n\t[85.215.255.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1A6C69026\n\tfor ;\n\tTue, 22 Jul 2025 12:57:10 +0200 (CEST)","from archlinux.fritz.box by smtp.strato.de (RZmta 52.1.2 AUTH)\n\twith ESMTPSA id z685ee16MAvAHgW\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))\n\t(Client did not present a certificate);\n\tTue, 22 Jul 2025 12:57:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ziska.de header.i=@ziska.de header.b=\"e1Ot8+CO\";\n\tdkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"rDUkujN6\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1753181830; cv=none;\n\td=strato.com; s=strato-dkim-0002;\n\tb=FlwsHxZ/FF7drB4/KprwKqCiWKp5G3FqMdFDRlIN+bpO2cLIy/1+gr5PsxmxRMWBy0\n\tPxss0UHuegZhoXdCoVuyqL4ci+1Hriunt8G6ZPEMq0cxT0fAf9GAJivWfKEZLMbl4bBC\n\tAR3KZn+xGyYU4TAoUNyukKlTdIDD1nv5wy2zwWtGXcZg1UVHKDwOvmx4CrnHkD9G9m2P\n\tiy3rvO00OQYWwt0bOxFS1Hw1IPlvI7hMp8SqBFoTO6xYox0i9bDHUN6jr3h/SQrEDvRA\n\tSmlGqySK+KX/0gTID/2qS6MPF1ZPJ0JHlggItMFHFJ18eIwHvzQ/2xLwCcnphhJVZZfz\n\t/jzA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; t=1753181830;\n\ts=strato-dkim-0002; d=strato.com;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=T/QnA1pSf04NxY4A339dZ0QQFP9oyrj5O75WrrTvLtA=;\n\tb=QIl4uPUJk/u5M7nbuAZk2ZQXeKgHpuy1L3kmLfDF8e9fRMsOlocSa08+p2UtEdHqVZ\n\tZe2ylXp+GnqSlKMfdGwMJCBcDy/+4CKtR6M4URDjb6C+Nnxgp8FYrQDFWmc6oGJx294v\n\tWFHLA59iWMvZ84aht1jDBIClUdx5MRlL2LSH1UlEn26jfxeTZUGXoRBhCUqUk/PpWZvA\n\tzqPBNKiwiOSu6SHRUUjqrottI8smAlHApWAvLRqjNZ2J0V5xXm75akZaX3MjWuZM4F6A\n\tTR/XbcXR84UABAfVD3JWY3hDyblvqhArtBkJrzFInmO7pXWlDHeKmB7bpel+YLQSm/Ua\n\tF0ug==","ARC-Authentication-Results":"i=1; strato.com;\n arc=none;\n dkim=none","X-RZG-CLASS-ID":"mo00","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; t=1753181830;\n\ts=strato-dkim-0002; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=T/QnA1pSf04NxY4A339dZ0QQFP9oyrj5O75WrrTvLtA=;\n\tb=e1Ot8+CObhrSSf+isnfyzGxKKoo6PKVU1fALATGkFRHrudfhZG836tKGyITKVSzU5T\n\tZHZSm7QVcEfBkTdwEUN/k8Y+mq1H9EI6Z5w9xGjSD3CmPM/n0kSSk0gfalqs10+ZrIck\n\tntYS1p01TL7re6CbSy5Tbx2O1GMu10K97yO05NGQl7JAKF703YiSCilxv1A63r3PiggL\n\tmrZnRWjuDFv9y8DD+UPgc+gqaLLCiBGxH4zV9Ut31GEAPM6C2Uq2ckex07JU5D7ffOdV\n\tNvZJmE+R9f9TS0jLLL+g7FlDPuKPYe2kTILPMFdzV9rqePFLIDjosaO682OYljrbkefQ\n\tixCQ==","v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1753181830;\n\ts=strato-dkim-0003; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=T/QnA1pSf04NxY4A339dZ0QQFP9oyrj5O75WrrTvLtA=;\n\tb=rDUkujN6siMkl/R6IhAu4WD/EPyfzMNCc6fZ14RiKp4SGwcX2o66tIYavNKp2oNFH3\n\tSrKe+fZtQO/XnE6s7fCw=="],"X-RZG-AUTH":"\":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cF0Yq5V/JaauwvHLbqWsUkNwDmHGDXQ5TkbZSP\"","From":"Jaslo Ziska ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jaslo Ziska ","Subject":"[PATCH v2 1/3] gstreamer: Fix reconfiguration condition check","Date":"Tue, 22 Jul 2025 12:39:28 +0200","Message-ID":"<20250722105627.11961-2-jaslo@ziska.de>","X-Mailer":"git-send-email 2.50.0","In-Reply-To":"<20250722105627.11961-1-jaslo@ziska.de>","References":"<20250722105627.11961-1-jaslo@ziska.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"us-ascii\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"gst_pad_peer_query_accept_caps() might only check if the caps are\nacceptable with the peer element, but not recursively with all\ndownstream elements. If the reconfigure flag was set because the\npipeline downstream changed, gst_pad_peer_query_accept_caps() might still\nreturn true, even though downstream can't handle the current caps, which\ncauses a not-negotiated error.\n\nThis commit fixes this issue by emitting a query event which\nrecursively checks with all downstream elements. Because at this point\nwe are only interested in whether the current caps are still acceptable,\nuse the currently used caps as a filter and then check if the query\nreturned empty caps.\n\nSigned-off-by: Jaslo Ziska \n---\n src/gstreamer/gstlibcamerasrc.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 3aca4eed..7f4a39ec 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -730,7 +730,8 @@ gst_libcamera_src_task_run(gpointer user_data)\n \t\tif (gst_pad_check_reconfigure(srcpad)) {\n \t\t\t/* Check if the caps even need changing. */\n \t\t\tg_autoptr(GstCaps) caps = gst_pad_get_current_caps(srcpad);\n-\t\t\tif (!gst_pad_peer_query_accept_caps(srcpad, caps)) {\n+\t\t\tg_autoptr(GstCaps) peercaps = gst_pad_peer_query_caps(srcpad, caps);\n+\t\t\tif (gst_caps_is_empty(peercaps)) {\n \t\t\t\treconfigure = true;\n \t\t\t\tbreak;\n \t\t\t}\n","prefixes":["v2","1/3"]}