[{"id":35013,"web_url":"https://patchwork.libcamera.org/comment/35013/","msgid":"<175318049220.50296.5300240525149457630@ping.linuxembedded.co.uk>","date":"2025-07-22T10:34:52","subject":"Re: [PATCH] pipeline: simple: Improve debug log in validate()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2025-07-22 11:25:38)\n> Improve the debug log while adjusting the StreamConfiguration's\n> pixel format. The log should clearly indicate the requested pixel\n> format and the adjusted pixel format.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index efb07051..492da967 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1204,7 +1204,9 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n> \n> PixelFormat pixelFormat = *it;\n> if (cfg.pixelFormat != pixelFormat) {\n> - LOG(SimplePipeline, Debug) << \"Adjusting pixel format\";\n> + LOG(SimplePipeline, Debug)\n> + << \"Adjusting pixel format from \"\n> + << cfg.pixelFormat << \" to \" << pixelFormat;\n> cfg.pixelFormat = pixelFormat;\n> status = Adjusted;\n> }\n> -- \n> 2.50.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C91D0BDCC1\n\tfor ;\n\tTue, 22 Jul 2025 10:34:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A58269026;\n\tTue, 22 Jul 2025 12:34:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8752168F93\n\tfor ;\n\tTue, 22 Jul 2025 12:34:55 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D613379E6;\n\tTue, 22 Jul 2025 12:34:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RGeTaOzV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753180457;\n\tbh=4BWmXKUz1CoKt6ap5pjNbjb6NoSzEXpdwbS9uxu7DAE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=RGeTaOzV4Z7uw7RI8ZI7V7+uMcZOdXFZBf2HXuweDQ4z7bW90wK12vFmJPXU3D3dX\n\tehMgGEO7W84YWTdw11ynS1Q8OjI4gkB/3iUv1mVINQWui5QyrK1epPREXsF2BhUbNv\n\tJ5flu8chPbNgMcPWwhDCAYw5STYlzfikDE2o+jN0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250722102538.52706-1-uajain@igalia.com>","References":"<20250722102538.52706-1-uajain@igalia.com>","Subject":"Re: [PATCH] pipeline: simple: Improve debug log in validate()","From":"Kieran Bingham ","Cc":"Umang Jain ","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Jul 2025 11:34:52 +0100","Message-ID":"<175318049220.50296.5300240525149457630@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35289,"web_url":"https://patchwork.libcamera.org/comment/35289/","msgid":"<175450010998.50296.10144706228490000779@ping.linuxembedded.co.uk>","date":"2025-08-06T17:08:29","subject":"Re: [PATCH] pipeline: simple: Improve debug log in validate()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2025-07-22 11:34:52)\n> Quoting Umang Jain (2025-07-22 11:25:38)\n> > Improve the debug log while adjusting the StreamConfiguration's\n> > pixel format. The log should clearly indicate the requested pixel\n> > format and the adjusted pixel format.\n> > \n> > Signed-off-by: Umang Jain \n> \n> Reviewed-by: Kieran Bingham \n\nAny objections to merging this ?\n\nAny more review tags or does anyone want to specifically test it ?\n\nMilan, I think you're essentially the maintainer/owner of simple.cpp at\nthe moment - are you happy with this ?\n\n--\nKieran\n\n\n> \n> > ---\n> > src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index efb07051..492da967 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -1204,7 +1204,9 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n> > \n> > PixelFormat pixelFormat = *it;\n> > if (cfg.pixelFormat != pixelFormat) {\n> > - LOG(SimplePipeline, Debug) << \"Adjusting pixel format\";\n> > + LOG(SimplePipeline, Debug)\n> > + << \"Adjusting pixel format from \"\n> > + << cfg.pixelFormat << \" to \" << pixelFormat;\n> > cfg.pixelFormat = pixelFormat;\n> > status = Adjusted;\n> > }\n> > -- \n> > 2.50.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA4E7BDCC1\n\tfor ;\n\tWed, 6 Aug 2025 17:08:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1AA756921F;\n\tWed, 6 Aug 2025 19:08:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED7EA691F5\n\tfor ;\n\tWed, 6 Aug 2025 19:08:32 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58A68EBA;\n\tWed, 6 Aug 2025 19:07:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ii65FhEw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1754500064;\n\tbh=BkXgpjL1QhfWDtNEfxMWPLFGN2ZjmrM/He93o09Sk8c=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ii65FhEws+NdUzwNOpWTU9p2hwQLohUGTL8KrjZ3JKnelcahaqfY5SsgobRSFOt6b\n\tuE7lH0BhTPY6AqZKPMvuiMfN0ONEkW3i0noRJ5vFh0EMm0yf7r39wNs/1sAR++ghk1\n\t2s/JNQ3RaDcFcAN9673hA0lgn70p9JZD42eCyhSs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<175318049220.50296.5300240525149457630@ping.linuxembedded.co.uk>","References":"<20250722102538.52706-1-uajain@igalia.com>\n\t<175318049220.50296.5300240525149457630@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH] pipeline: simple: Improve debug log in validate()","From":"Kieran Bingham ","Cc":"Umang Jain ","To":"Umang Jain , libcamera-devel@lists.libcamera.org,\n\tMilan Zamazal , ","Date":"Wed, 06 Aug 2025 18:08:29 +0100","Message-ID":"<175450010998.50296.10144706228490000779@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35330,"web_url":"https://patchwork.libcamera.org/comment/35330/","msgid":"<85frdyjngd.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-08-11T08:02:10","subject":"Re: [PATCH] pipeline: simple: Improve debug log in validate()","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Kieran Bingham writes:\n\n> Quoting Kieran Bingham (2025-07-22 11:34:52)\n>> Quoting Umang Jain (2025-07-22 11:25:38)\n>> > Improve the debug log while adjusting the StreamConfiguration's\n>> > pixel format. The log should clearly indicate the requested pixel\n>> > format and the adjusted pixel format.\n>> > \n>> > Signed-off-by: Umang Jain \n>> \n>> Reviewed-by: Kieran Bingham \n>\n> Any objections to merging this ?\n>\n> Any more review tags or does anyone want to specifically test it ?\n>\n> Milan, I think you're essentially the maintainer/owner of simple.cpp at\n> the moment - are you happy with this ?\n\nYes, it's a useful change, I have had a similar change in my raw stream\nseries.\n\nReviewed-by: Milan Zamazal \n\n> --\n> Kieran\n>\n>\n>> \n>> > ---\n>> > src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n>> > 1 file changed, 3 insertions(+), 1 deletion(-)\n>> > \n>> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>> > index efb07051..492da967 100644\n>> > --- a/src/libcamera/pipeline/simple/simple.cpp\n>> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> > @@ -1204,7 +1204,9 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n>> > \n>> > PixelFormat pixelFormat = *it;\n>> > if (cfg.pixelFormat != pixelFormat) {\n>> > - LOG(SimplePipeline, Debug) << \"Adjusting pixel format\";\n>> > + LOG(SimplePipeline, Debug)\n>> > + << \"Adjusting pixel format from \"\n>> > + << cfg.pixelFormat << \" to \" << pixelFormat;\n>> > cfg.pixelFormat = pixelFormat;\n>> > status = Adjusted;\n>> > }\n>> > -- \n>> > 2.50.0\n>> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95261BDCC1\n\tfor ;\n\tMon, 11 Aug 2025 08:02:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B188361464;\n\tMon, 11 Aug 2025 10:02:22 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E87E6145E\n\tfor ;\n\tMon, 11 Aug 2025 10:02:20 +0200 (CEST)","from mail-qv1-f70.google.com (mail-qv1-f70.google.com\n\t[209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-346-GW3dgWEEMn-TkdYleAyIOQ-1; Mon, 11 Aug 2025 04:02:16 -0400","by mail-qv1-f70.google.com with SMTP id\n\t6a1803df08f44-7074bad0561so121464566d6.1\n\tfor ;\n\tMon, 11 Aug 2025 01:02:13 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb ([85.93.96.130])\n\tby smtp.gmail.com with ESMTPSA id\n\t6a1803df08f44-7077ca12e2fsm151031016d6.22.2025.08.11.01.02.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 11 Aug 2025 01:02:12 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"OdVIl+nA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1754899339;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=QVIlZ8wkCIeBWuP3joCuQEMz839u8uSH147gJ36GXhs=;\n\tb=OdVIl+nAh6p3Fp13CgeKeuhFi6UEx1tTiCUtNG03B5SgRS065XPyxAQIWoxz2ZxcZwyWQB\n\tieEsLYdVRsQM7jznlKc9AeddIF80+myhrF35HLhK0r4lNnmzXGGiHKN0OtNz+MmaNc+T4P\n\tu7mXVm54vYoxZPWTRFcsTd+Lja6KoRw=","X-MC-Unique":"GW3dgWEEMn-TkdYleAyIOQ-1","X-Mimecast-MFC-AGG-ID":"GW3dgWEEMn-TkdYleAyIOQ_1754899333","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1754899333; x=1755504133;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=QVIlZ8wkCIeBWuP3joCuQEMz839u8uSH147gJ36GXhs=;\n\tb=vo+kmRoLy1ugovadchFKghGAYpyzUpF+reKc+kJ9xRyYZxd2WGxUjgE28aQzXTo9QV\n\tdsnhAmFNa0XK6b1auIW3ShvnGfZgGGS70jqAz3PaBTF095Nd50Ziyggv2cytC+KdCYlD\n\t6hvJekpJ11XmYV90PaIdyp5a4scgm/+2m+Px0Jw/SyxoSdnBT0GSFtosujuhWorhLfFy\n\to3VQUwCIvV1ti1c8hsHEvkDFOlDFNLt1UImzx7u9R+4IVFSQwpbwLr0kBC1iciFkwAhX\n\ttQZgXgar6uswiF8+cGFk07rIS07ZqsktPtzrffmjtPca4yyel3jTfjnNVbGYTKjX+294\n\tkMWg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVJGpRnPD+zr2NBDs26LwIyKhZb5nNfrsP87iHqtnIeLzqzKg0ybRCZ93y6s8bAY+gPp0Bqn8ZUttLUXQUw2TY=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YxbMzrqJ3rBRwTV02g0jvjEbejNBYyfgno60zPxvZflKhB8HAD+\n\td5pME4NiGo7xZL/GFME3CHjOSxinUn7o6ITw8WYHFONdIC6kQIi2mGnKHUcMGu0+I/rYU6hwEDw\n\tMkE3a7A0eX708tfHp2pDBA7goPqIKIbFLbN8n7QPiyhz1/f1dguM5kyYXFRoodrdCeXYI10O2/E\n\tIMBvj0mCoJ6SpoyLpmdLg7E73U/qaQi7AEXyjPd8clWdQyLXHtshQoabBGqUY=","X-Gm-Gg":"ASbGncuLx/HamX80kTOxmeQwAw3qRaYdrOK5U6pb9SmAKYemGTMZf7wCFiwdnfF/v+l\n\ti95H2jgxLf2yWfR+3/tfWAYy8Ec8HtP/t2QcYLl/ngR6KYHkJC9rfNamIixF/HvJ+4J5PLVe/NU\n\tgxk4YHG1dgu7LyYwbP/j1vant6RJEgx7EDcJ7LUZqDzyQCDZBVSYwKLYnrxL4Dhom6e5Rp/jFPp\n\tSHswFvJINTBfufAwEUJcLB6PX0T+00bDee2xjJJsxUw37NdQd8XprLGCT7H8V4d8S7e37k5tCKF\n\tU+4vIjh6ELn34UpXZXhz5D1F8KL549l2x2VxJtPIVKV+360DRQ/5lic4/RwroMBf","X-Received":["by 2002:a05:6214:2469:b0:707:48b6:bcd4 with SMTP id\n\t6a1803df08f44-7099a51356fmr161593516d6.48.1754899333330; \n\tMon, 11 Aug 2025 01:02:13 -0700 (PDT)","by 2002:a05:6214:2469:b0:707:48b6:bcd4 with SMTP id\n\t6a1803df08f44-7099a51356fmr161593216d6.48.1754899332903; \n\tMon, 11 Aug 2025 01:02:12 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IFyNkZYj4pnnEyE8tpj+/wTsGhM1v8Xf9kMbQfh7Jjpdo8gaxlnABE/wv469DrqMy36Nnegsg==","From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"Umang Jain , libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] pipeline: simple: Improve debug log in validate()","In-Reply-To":"<175450010998.50296.10144706228490000779@ping.linuxembedded.co.uk>\n\t(Kieran Bingham's message of \"Wed, 06 Aug 2025 18:08:29 +0100\")","References":"<20250722102538.52706-1-uajain@igalia.com>\n\t<175318049220.50296.5300240525149457630@ping.linuxembedded.co.uk>\n\t<175450010998.50296.10144706228490000779@ping.linuxembedded.co.uk>","Date":"Mon, 11 Aug 2025 10:02:10 +0200","Message-ID":"<85frdyjngd.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"B5Sqhq_PGXNeCINd2ZgqbExUqZRmqh9M0rh3eopVWvc_1754899333","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]