[{"id":34974,"web_url":"https://patchwork.libcamera.org/comment/34974/","msgid":"<175311313793.50296.10787457391316510076@ping.linuxembedded.co.uk>","date":"2025-07-21T15:52:17","subject":"Re: [PATCH v2] apps: cam: Print enum string for camera properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2025-07-21 13:48:26)\n> Some camera properties might be set as a enumeration for e.g.\n> properties::Location. Instead of printing the int32_t values\n> for the enumeration, print the enum string as well. This will\n> enhance the readability for the user.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Kieran Bingham \n> Tested-by: Kieran Bingham \n\nRe-tested:\n\nkbingham@Monstersaurus:~/iob/libcamera/libcamera$ ./build/gcc/src/apps/cam/cam -c1 -p\n[175:23:22.197634345] [329642] INFO IPAManager ipa_manager.cpp:137 libcamera is not installed. Adding '/home/kbingham/iob/libcamera/libcamera/build/gcc/src/ipa' to the IPA search path\n[175:23:22.200890094] [329642] INFO Camera camera_manager.cpp:326 libcamera v0.5.1+89-c7c40ed1\n[175:23:22.263920994] [329646] INFO Pipeline pipeline_handler.cpp:646 libcamera is not installed. Loading platform configuration file from '/home/kbingham/iob/libcamera/libcamera/src/libcamera/pipeline/virtual/data/virtual.yaml'\nUsing camera \\_SB_.PCI0.GP13.XHC0.RHUB.PRT3-3.4:1.0-046d:085e as cam0\nProperty: SystemDevices = [ 20736 ]\nProperty: PixelArrayActiveAreas = [ (0, 0)/1920x1080 ]\nProperty: PixelArraySize = 1920x1080\nProperty: Location = 2 (CameraLocationExternal)\nProperty: Model = Logitech BRIO\n\n\nLooks good to me.\n\nMerging.\n\n--\nKieran\n\n\n> Reviewed-by: Barnabás Pőcze \n> ---\n> Changes in v2:\n> - Comestic changes \n> - Use id->enumerators() to detect controlID has enum values\n> ---\n> src/apps/cam/camera_session.cpp | 12 +++++++++++-\n> 1 file changed, 11 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> index f63fcb22..1596a25a 100644\n> --- a/src/apps/cam/camera_session.cpp\n> +++ b/src/apps/cam/camera_session.cpp\n> @@ -236,7 +236,17 @@ void CameraSession::listProperties() const\n> const ControlId *id = properties::properties.at(key);\n> \n> std::cout << \"Property: \" << id->name() << \" = \"\n> - << value.toString() << std::endl;\n> + << value.toString();\n> +\n> + if (!id->enumerators().empty()) {\n> + int32_t val = value.get();\n> + const auto &iter = id->enumerators().find(val);\n> +\n> + if (iter != id->enumerators().end())\n> + std::cout << \" (\" << iter->second << \")\";\n> + }\n> +\n> + std::cout << std::endl;\n> }\n> }\n> \n> -- \n> 2.50.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A91BAC3237\n\tfor ;\n\tMon, 21 Jul 2025 15:52:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE8F868FED;\n\tMon, 21 Jul 2025 17:52:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C82F68FB1\n\tfor ;\n\tMon, 21 Jul 2025 17:52:24 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E808243C;\n\tMon, 21 Jul 2025 17:51:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BCpvRs2/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753113105;\n\tbh=Gg1068lHDArbhxrL9Jbhaf37q89H3wodqN4AJ+h79Cs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=BCpvRs2/E6yW5WV+POsjSuntv8reepT33l2f6+3y/cKDLn3SIRLBPaNKFND8xdBMK\n\t4PDCfUx4DrOVAwaTae+qI8M0tzk1uhjvl/0eNkKmnGDTc8aG6UcqTZYOjwxrom2Hyy\n\t7PF2rhHw6YWCk0Ak7ILmIRFDlNUfnZvwEv4wBV5o=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250721124826.8584-1-uajain@igalia.com>","References":"<20250721124826.8584-1-uajain@igalia.com>","Subject":"Re: [PATCH v2] apps: cam: Print enum string for camera properties","From":"Kieran Bingham ","Cc":"Umang Jain , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Date":"Mon, 21 Jul 2025 16:52:17 +0100","Message-ID":"<175311313793.50296.10787457391316510076@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]