[{"id":3176,"web_url":"https://patchwork.libcamera.org/comment/3176/","msgid":"<20191204155016.GD7811@pendragon.ideasonboard.com>","date":"2019-12-04T15:50:16","subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: v4l2_controls: Store\n\tdefault value","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Dec 04, 2019 at 02:21:01PM +0100, Jacopo Mondi wrote:\n> Store the default value for V4L2 controls as reported by the kernel when\n> creating ControlRange instances using information coming from\n> v4l2_query_ext_ctrl.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/v4l2_controls.cpp | 9 ++++++---\n>  1 file changed, 6 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> index b6547a7c627c..7446c3880330 100644\n> --- a/src/libcamera/v4l2_controls.cpp\n> +++ b/src/libcamera/v4l2_controls.cpp\n> @@ -121,17 +121,20 @@ V4L2ControlRange::V4L2ControlRange(const struct v4l2_query_ext_ctrl &ctrl)\n>  \tswitch (ctrl.type) {\n>  \tcase V4L2_CTRL_TYPE_BOOLEAN:\n>  \t\tControlRange::operator=(ControlRange(static_cast<bool>(ctrl.minimum),\n> -\t\t\t\t\t\t     static_cast<bool>(ctrl.maximum)));\n> +\t\t\t\t\t\t     static_cast<bool>(ctrl.maximum),\n> +\t\t\t\t\t\t     static_cast<bool>(ctrl.default_value)));\n>  \t\tbreak;\n>  \n>  \tcase V4L2_CTRL_TYPE_INTEGER64:\n>  \t\tControlRange::operator=(ControlRange(static_cast<int64_t>(ctrl.minimum),\n> -\t\t\t\t\t\t     static_cast<int64_t>(ctrl.maximum)));\n> +\t\t\t\t\t\t     static_cast<int64_t>(ctrl.maximum),\n> +\t\t\t\t\t\t     static_cast<int64_t>(ctrl.default_value)));\n>  \t\tbreak;\n>  \n>  \tdefault:\n>  \t\tControlRange::operator=(ControlRange(static_cast<int32_t>(ctrl.minimum),\n> -\t\t\t\t\t\t     static_cast<int32_t>(ctrl.maximum)));\n> +\t\t\t\t\t\t     static_cast<int32_t>(ctrl.maximum),\n> +\t\t\t\t\t\t     static_cast<int32_t>(ctrl.default_value)));\n>  \t\tbreak;\n>  \t}\n>  }","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D56B460BFF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  4 Dec 2019 16:50:23 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 59FD32E5;\n\tWed,  4 Dec 2019 16:50:23 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1575474623;\n\tbh=pD1np2/5dYPB8xeAlEytc/gWIWTVSYRp3Fr8iUlcHdI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aCgGLxB/BAkNESPbTzQI7bY9esLGEyVBfQQ2exWUCY48X1jV1OtORGcygjLmmYjVS\n\t5Ys2EWBSgaRoHc7vGdozkYDmLMAZG8sEXZgF4uv00tukkXyY6S46YeWTrpuUUzMshj\n\t8thVx08fcu0rTNdII64LfLeKasOj7N3hLxCpH/sc=","Date":"Wed, 4 Dec 2019 17:50:16 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191204155016.GD7811@pendragon.ideasonboard.com>","References":"<20191204132106.21582-1-jacopo@jmondi.org>\n\t<20191204132106.21582-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191204132106.21582-6-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: v4l2_controls: Store\n\tdefault value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 04 Dec 2019 15:50:24 -0000"}}]