[{"id":34924,"web_url":"https://patchwork.libcamera.org/comment/34924/","msgid":"<175282353413.1641235.17406460872968519400@ping.linuxembedded.co.uk>","date":"2025-07-18T07:25:34","subject":"Re: [PATCH 2/2] libcamera: mali-c55: Correct expected entity\n\tfunction","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2025-07-17 23:05:39)\n> The mali-c55 pipeline handler currently looks for a media entity with\n> the function MEDIA_ENT_F_IO_V4L to recognise a memory input subdevice.\n> This is apparently intended for video device entities, and we should\n> be looking for MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER. Correct the\n> entity function that the pipeline handler looks for.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 17ad2055..25540ba1 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -1709,7 +1709,7 @@ bool PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator)\n> *\n> * MEDIA_ENT_F_CAM_SENSOR - The test pattern generator\n> * MEDIA_ENT_F_VID_IF_BRIDGE - A CSI-2 receiver\n> - * MEDIA_ENT_F_IO_V4L - An input device\n> + * MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER - An input device\n> *\n> * The last one will be unsupported for now. The TPG is relatively easy,\n> * we just register a Camera for it. If we have a CSI-2 receiver we need\n> @@ -1735,7 +1735,7 @@ bool PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator)\n> return registered;\n> \n> break;\n> - case MEDIA_ENT_F_IO_V4L:\n> + case MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER:\n> LOG(MaliC55, Warning) << \"Memory input not yet supported\";\n> break;\n> default:\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE93EBE175\n\tfor ;\n\tFri, 18 Jul 2025 07:25:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 677EF68F98;\n\tFri, 18 Jul 2025 09:25:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1822668F8C\n\tfor ;\n\tFri, 18 Jul 2025 09:25:37 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96CC31FB2;\n\tFri, 18 Jul 2025 09:25:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sC/zybOE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752823502;\n\tbh=v6ePzrNugGEYZkOd9UKIOP5FkzjEy6QdV73HpDbPsIU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=sC/zybOEgPsK+z5UsZoV/6hH6WrlcaTqsICtp2uPBQbHBoyshc5+TqAWRS1q5+VE8\n\tPZXIhm1veualPFd1W+UTxtO6owtbJ1Hiu7BIaeNEAzwAw71mwXb/2KMeS3p+5ZJNIS\n\t8dnRrOjnVVM8/9wcVtWo3kcFjFXkYfvQ9j1su7To=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250717220539.2434556-2-dan.scally@ideasonboard.com>","References":"<20250717220539.2434556-1-dan.scally@ideasonboard.com>\n\t<20250717220539.2434556-2-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH 2/2] libcamera: mali-c55: Correct expected entity\n\tfunction","From":"Kieran Bingham ","Cc":"Daniel Scally ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 18 Jul 2025 08:25:34 +0100","Message-ID":"<175282353413.1641235.17406460872968519400@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34927,"web_url":"https://patchwork.libcamera.org/comment/34927/","msgid":"<421fbb7e99bce72ff0d1caeb21e431c10e9cffa4.camel@ideasonboard.com>","date":"2025-07-18T09:18:12","subject":"Re: [PATCH 2/2] libcamera: mali-c55: Correct expected entity\n\tfunction","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch!\n\nOn Thu, 2025-07-17 at 23:05 +0100, Daniel Scally wrote:\n> The mali-c55 pipeline handler currently looks for a media entity with\n> the function MEDIA_ENT_F_IO_V4L to recognise a memory input\n> subdevice.\n> This is apparently intended for video device entities, and we should\n> be looking for MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER. Correct the\n> entity function that the pipeline handler looks for.\n> \n> Signed-off-by: Daniel Scally \n> ---\n>  src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 17ad2055..25540ba1 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -1709,7 +1709,7 @@ bool\n> PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator)\n>  \t *\n>  \t * MEDIA_ENT_F_CAM_SENSOR - The test pattern generator\n>  \t * MEDIA_ENT_F_VID_IF_BRIDGE - A CSI-2 receiver\n> -\t * MEDIA_ENT_F_IO_V4L - An input device\n> +\t * MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER - An input device\n\nLGTM!\n\nReviewed-by: Isaac Scott \n\n>  \t *\n>  \t * The last one will be unsupported for now. The TPG is\n> relatively easy,\n>  \t * we just register a Camera for it. If we have a CSI-2\n> receiver we need\n> @@ -1735,7 +1735,7 @@ bool\n> PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator)\n>  \t\t\t\treturn registered;\n>  \n>  \t\t\tbreak;\n> -\t\tcase MEDIA_ENT_F_IO_V4L:\n> +\t\tcase MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER:\n>  \t\t\tLOG(MaliC55, Warning) << \"Memory input not\n> yet supported\";\n>  \t\t\tbreak;\n>  \t\tdefault:\nBest wishes,\nIsaac","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A3F4BE175\n\tfor ;\n\tFri, 18 Jul 2025 09:18:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A05768F97;\n\tFri, 18 Jul 2025 11:18:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F07B66150A\n\tfor ;\n\tFri, 18 Jul 2025 11:18:15 +0200 (CEST)","from isaac-ThinkPad-T16-Gen-2.lan\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4170A59E3;\n\tFri, 18 Jul 2025 11:17:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bqTMQktM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752830261;\n\tbh=8SpwT8I7YL0JVoTjAPskxa1ycoR9g+npvrFuAZ5lNy8=;\n\th=Subject:From:To:Date:In-Reply-To:References:From;\n\tb=bqTMQktM7ghAmLOIu6EZ9QqSaCZ9pw8gGYr83gtdumAuKW0SOIsFBO6upN2Bz/Bbr\n\tmLpNPBp/CGxPf/edfMVIi3WBhygjCzpJRu51QqvZDA3wS4ucUZz3YuJKwt4aOlYax1\n\tQMqV4/NpZxnrZ920+jUOUUHYZwwOlg3sWJtS+tLE=","Message-ID":"<421fbb7e99bce72ff0d1caeb21e431c10e9cffa4.camel@ideasonboard.com>","Subject":"Re: [PATCH 2/2] libcamera: mali-c55: Correct expected entity\n\tfunction","From":"Isaac Scott ","To":"Daniel Scally , \n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 18 Jul 2025 10:18:12 +0100","In-Reply-To":"<20250717220539.2434556-2-dan.scally@ideasonboard.com>","References":"<20250717220539.2434556-1-dan.scally@ideasonboard.com>\n\t<20250717220539.2434556-2-dan.scally@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.56.1 (by Flathub.org) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]