[{"id":34932,"web_url":"https://patchwork.libcamera.org/comment/34932/","msgid":"<175284078455.560048.5175035690692547844@ping.linuxembedded.co.uk>","date":"2025-07-18T12:13:04","subject":"Re: [PATCH v4 2/2] utils: update 'version' in package.xml on release","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Christian Rauch (2025-07-16 21:39:23)\n\nI'm sure by now you know we require descriptive commit messages ;-)\n\nHow about:\n\nMaintain the ROS specific package.xml by automatically updating the\nversion string when a release is made.\n\nAnd your Signed off ;-)\n\n--\nKieran\n\n\n> ---\n> utils/release.sh | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/release.sh b/utils/release.sh\n> index 8cc85859b..0356cd7c2 100755\n> --- a/utils/release.sh\n> +++ b/utils/release.sh\n> @@ -38,9 +38,10 @@ echo \" New version is : $new_version\"\n> \n> # Patch in the version to our meson.build\n> sed -i -E \"s/ version : '.*',/ version : '$new_version',/\" meson.build\n> +sed -i -E \"s/.*<\\/version>/$new_version<\\/version>/\" package.xml\n> \n> # Commit the update\n> -git commit meson.build -esm \"libcamera v$new_version\"\n> +git commit meson.build package.xml -esm \"libcamera v$new_version\"\n> \n> # Create a tag from that commit\n> git show -s --format=%B | git tag \"v$new_version\" -s -F -\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5380CC3237\n\tfor ;\n\tFri, 18 Jul 2025 12:13:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08EC468F9D;\n\tFri, 18 Jul 2025 14:13:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF7DA6150F\n\tfor ;\n\tFri, 18 Jul 2025 14:13:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57B70C64;\n\tFri, 18 Jul 2025 14:12:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VUuQ2g2s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752840752;\n\tbh=yUbKRcTZ1KpdR1TZppZhQf5UNgPsJElZVV9Kf16ZuQo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=VUuQ2g2sCOaYrf1/BOFbkcJNZaYyTzUnA7DWl4HRRoUUxk4hNDKY7wy1La/EvTY/u\n\tIPAUEDBiu8DngHSEGsQxFFvMwoZPY+HTWUwTmpuDFISJA9qrunJEHlOIMix+0rnF1P\n\tV0LtamyTt4PmB8qycbImHqI8Toj70639fabZaJo8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250716203923.72677-3-Rauch.Christian@gmx.de>","References":"<20250716203923.72677-1-Rauch.Christian@gmx.de>\n\t<20250716203923.72677-3-Rauch.Christian@gmx.de>","Subject":"Re: [PATCH v4 2/2] utils: update 'version' in package.xml on release","From":"Kieran Bingham ","Cc":"Christian Rauch ","To":"Christian Rauch ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 18 Jul 2025 13:13:04 +0100","Message-ID":"<175284078455.560048.5175035690692547844@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]