{"id":23823,"url":"https://patchwork.libcamera.org/api/patches/23823/?format=json","web_url":"https://patchwork.libcamera.org/patch/23823/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250716142027.236277-3-uajain@igalia.com>","date":"2025-07-16T14:20:22","name":"[RFC,2/6] libcamera: simple: Exclude raw configurations from output conversions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f37398aee4e6389aed0c920d59fa48024c154c1f","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23823/mbox/","series":[{"id":5289,"url":"https://patchwork.libcamera.org/api/series/5289/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5289","date":"2025-07-16T14:20:20","name":"libcamera: simple: Enable Raw capture","version":1,"mbox":"https://patchwork.libcamera.org/series/5289/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23823/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23823/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08941C3237\n\tfor ;\n\tWed, 16 Jul 2025 14:20:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB55768F74;\n\tWed, 16 Jul 2025 16:20:28 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1310B68F61\n\tfor ;\n\tWed, 16 Jul 2025 16:20:25 +0200 (CEST)","from [49.36.69.57] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uc2zg-00HLf5-3b; Wed, 16 Jul 2025 16:20:24 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"UmmJ4yqT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=nDVr/i+s2Bh6DsppBfogTES1E9aj8Nr+6C1Z+bEr8AE=;\n\tb=UmmJ4yqTbjpLZ9qjN/m3WG8YsL\n\tnBu0ulhOuS+DPj1SAj7kVU67YG2Gu80sfrW4DP+fGmonVRfjhNgtJo0218/MkO0qXWqobnFlPEYSk\n\tw6MRB+SWhnBW46Ogt+cxEb84Mu4r61EtbnMfBcQ/u1Gv9Xe+flySWJplZ08940ygbk+wQCQmVRQUg\n\tn/6ylst7YBZDBlsmvnm10oGlJwg0oFWfFkSkF0cM5pazP/v6eA28PbSTfWBJX8+lWGqO9V2xgmGEV\n\tMqSzEKB+zO0dwm5DLGvcmXnCz6/1lCFAw+1hlr5KviuSGx/15IE5Zs7HXhsJNK/3XLbZzqSXentlm\n\tBgznnLiQ==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tRobert Mader , Umang Jain ","Subject":"[RFC PATCH 2/6] libcamera: simple: Exclude raw configurations from\n\toutput conversions","Date":"Wed, 16 Jul 2025 19:50:22 +0530","Message-ID":"<20250716142027.236277-3-uajain@igalia.com>","X-Mailer":"git-send-email 2.50.0","In-Reply-To":"<20250716142027.236277-1-uajain@igalia.com>","References":"<20250716142027.236277-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Milan Zamazal \n\nIn order to support raw streams, we need to add raw formats to software\nISP configurations. In this preparatory patch, the raw formats are\nexcluded from output configurations for conversions.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Umang Jain \n---\n src/libcamera/pipeline/simple/simple.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex de6b29ab..cadc1117 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -26,6 +26,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n \n@@ -259,6 +260,12 @@ static const SimplePipelineInfo supportedDevices[] = {\n \t{ \"sun6i-csi\", {}, false },\n };\n \n+bool isFormatRaw(const libcamera::PixelFormat &pixFmt)\n+{\n+\treturn libcamera::PixelFormatInfo::info(pixFmt).colourEncoding ==\n+\t libcamera::PixelFormatInfo::ColourEncodingRAW;\n+}\n+\n } /* namespace */\n \n class SimpleCameraData : public Camera::Private\n@@ -1388,7 +1395,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \n \t\tcfg.setStream(&data->streams_[i]);\n \n-\t\tif (data->useConversion_)\n+\t\tif (data->useConversion_ && !isFormatRaw(cfg.pixelFormat))\n \t\t\toutputCfgs.push_back(cfg);\n \t}\n \n","prefixes":["RFC","2/6"]}