[{"id":34904,"web_url":"https://patchwork.libcamera.org/comment/34904/","msgid":"<82b2daec-79a1-4a0a-8075-ec9db0622551@ideasonboard.com>","date":"2025-07-15T14:19:45","subject":"Re: [PATCH v1] Documentation: Make `doxygen-internal` depend on\n\tpublic inputs","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Barnabás\n\nOn 15/07/2025 14:44, Barnabás Pőcze wrote:\n> The internal documentation is a superset of the public one, so make the\n> `doxygen-internal` target depend on the public input files. Otherwise\n> the internal documentation is not rebuilt if a \"public\"file changes.\n>\n> Before:\n>\n> $ touch src/libcamera/camera.cpp\n> $ ninja -C build -v\n> # ...\n> [6/116] /usr/bin/doxygen Documentation/Doxyfile-public\n> # ...\n>\n> After:\n>\n> $ touch src/libcamera/camera.cpp\n> $ ninja -C build -v\n> # ...\n> [6/117] /usr/bin/doxygen Documentation/Doxyfile-public\n> # ...\n> [9/117] /usr/bin/doxygen Documentation/Doxyfile-internal\n> # ...\n>\n> Signed-off-by: Barnabás Pőcze \n> ---\n\nWhoops. Good spot:\n\n\nReviewed-by: Daniel Scally \n\n> Documentation/meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> index 0fc5909d0..3afdcc1a8 100644\n> --- a/Documentation/meson.build\n> +++ b/Documentation/meson.build\n> @@ -103,6 +103,7 @@ if doxygen.found() and dot.found()\n> input : [\n> doxyfile,\n> doxyfile_common,\n> + doxygen_public_input,\n> doxygen_internal_input,\n> ],\n> output : 'internal-api-html',\n> --\n> 2.50.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8756BBE175\n\tfor ;\n\tTue, 15 Jul 2025 14:19:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65ADA68F62;\n\tTue, 15 Jul 2025 16:19:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C946F6186B\n\tfor ;\n\tTue, 15 Jul 2025 16:19:48 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D96478E\n\tfor ;\n\tTue, 15 Jul 2025 16:19:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KgJaHBOg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752589156;\n\tbh=fYSvdC49ZwnBCl62XtmrAmuPMnP7a4BhK444y/0rA6o=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=KgJaHBOgyXDqg1/HQTc7i2RrPirv9gLYrMf7JQ6d1sQj/t0QFwiatk7hojYFQnfVU\n\tZejWtlEK6lUwNtfmzwQBvdokufe5AhsSHpo662VLVClbmEfk0XmsUHCr98gTKcHne7\n\tkKMz/ZUgnI609d9HmPY7uKR+EamIhYgX/HXy2Q3M=","Message-ID":"<82b2daec-79a1-4a0a-8075-ec9db0622551@ideasonboard.com>","Date":"Tue, 15 Jul 2025 15:19:45 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] Documentation: Make `doxygen-internal` depend on\n\tpublic inputs","To":"libcamera-devel@lists.libcamera.org","References":"<20250715134407.187697-1-barnabas.pocze@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20250715134407.187697-1-barnabas.pocze@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34906,"web_url":"https://patchwork.libcamera.org/comment/34906/","msgid":"<175259241447.560048.14339001535533648404@ping.linuxembedded.co.uk>","date":"2025-07-15T15:13:34","subject":"Re: [PATCH v1] Documentation: Make `doxygen-internal` depend on\n\tpublic inputs","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Dan Scally (2025-07-15 15:19:45)\n> Hi Barnabás\n> \n> On 15/07/2025 14:44, Barnabás Pőcze wrote:\n> > The internal documentation is a superset of the public one, so make the\n> > `doxygen-internal` target depend on the public input files. Otherwise\n> > the internal documentation is not rebuilt if a \"public\"file changes.\n> >\n> > Before:\n> >\n> > $ touch src/libcamera/camera.cpp\n> > $ ninja -C build -v\n> > # ...\n> > [6/116] /usr/bin/doxygen Documentation/Doxyfile-public\n> > # ...\n> >\n> > After:\n> >\n> > $ touch src/libcamera/camera.cpp\n> > $ ninja -C build -v\n> > # ...\n> > [6/117] /usr/bin/doxygen Documentation/Doxyfile-public\n> > # ...\n> > [9/117] /usr/bin/doxygen Documentation/Doxyfile-internal\n> > # ...\n> >\n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> \n> Whoops. Good spot:\n> \n> \n> Reviewed-by: Daniel Scally \n\nReviewed-by: Kieran Bingham \n\n> \n> > Documentation/meson.build | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/Documentation/meson.build b/Documentation/meson.build\n> > index 0fc5909d0..3afdcc1a8 100644\n> > --- a/Documentation/meson.build\n> > +++ b/Documentation/meson.build\n> > @@ -103,6 +103,7 @@ if doxygen.found() and dot.found()\n> > input : [\n> > doxyfile,\n> > doxyfile_common,\n> > + doxygen_public_input,\n> > doxygen_internal_input,\n> > ],\n> > output : 'internal-api-html',\n> > --\n> > 2.50.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BC95BE175\n\tfor ;\n\tTue, 15 Jul 2025 15:13:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FD3D68F64;\n\tTue, 15 Jul 2025 17:13:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B82AB6186B\n\tfor ;\n\tTue, 15 Jul 2025 17:13:37 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 239627E4;\n\tTue, 15 Jul 2025 17:13:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fvza2a2h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752592385;\n\tbh=1nGka6rrVggM42F3lfQC5dAdBgJdusWEIa+cY35hqo0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=fvza2a2hAiCwJfqoAY4FpnXanU3dCZmhFRUNr4BGkk31Vyjx3MXB+VR4jPByKrQ0g\n\t899mAq3Hq7ayEMPktsE/o2grq3qzeYAuluF+bTBqeHgVnVifCC5P6ttLm9ZbGcq2lz\n\tl7SxGppcYA04jPHBaW1TxLbpb1KBTO8YdiTq0cgY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<82b2daec-79a1-4a0a-8075-ec9db0622551@ideasonboard.com>","References":"<20250715134407.187697-1-barnabas.pocze@ideasonboard.com>\n\t<82b2daec-79a1-4a0a-8075-ec9db0622551@ideasonboard.com>","Subject":"Re: [PATCH v1] Documentation: Make `doxygen-internal` depend on\n\tpublic inputs","From":"Kieran Bingham ","To":"Dan Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 15 Jul 2025 16:13:34 +0100","Message-ID":"<175259241447.560048.14339001535533648404@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]