[{"id":34886,"web_url":"https://patchwork.libcamera.org/comment/34886/","msgid":"<20250714132055.GF8243@pendragon.ideasonboard.com>","date":"2025-07-14T13:20:55","subject":"Re: [PATCH v1] test: libtest: CameraTest: Set env var before\n\tCameraManager","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Mon, Jul 14, 2025 at 03:13:26PM +0200, Barnabás Pőcze wrote:\n> Set the `LIBCAMERA_IPA_FORCE_ISOLATION` environmental variable\n\ns/environmental/environment/\n\n(caring about environmental issues is important, but that's unrelated to\nthis patch :-))\n\n> before constructing the `CameraManager` object. This makes it\n> available during construction (some components might want to\n> query environmental variables at that time).\n\nSame here.\n\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/libtest/camera_test.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/libtest/camera_test.cpp b/test/libtest/camera_test.cpp\n> index fe13d6acf..6fb44989d 100644\n> --- a/test/libtest/camera_test.cpp\n> +++ b/test/libtest/camera_test.cpp\n> @@ -15,11 +15,11 @@ using namespace std;\n> \n> CameraTest::CameraTest(const char *name, bool isolate)\n> {\n> -\tcm_ = new CameraManager();\n> -\n> \tif (isolate)\n> \t\tsetenv(\"LIBCAMERA_IPA_FORCE_ISOLATION\", \"1\", 1);\n> \n> +\tcm_ = new CameraManager();\n> +\n> \tif (cm_->start()) {\n> \t\tcerr << \"Failed to start camera manager\" << endl;\n> \t\tstatus_ = TestFail;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A5F4C3237\n\tfor ;\n\tMon, 14 Jul 2025 13:21:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B80AC68F45;\n\tMon, 14 Jul 2025 15:21:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 542A46186C\n\tfor ;\n\tMon, 14 Jul 2025 15:21:27 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 61220166D; \n\tMon, 14 Jul 2025 15:20:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W82e5fC6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752499255;\n\tbh=xu3Hqcz41GZs2LbAj7UDolXEHt1Uvs48Yx1ss+uLixI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W82e5fC6NjTtG8Tz4UZ1W4qMKUY4L6ZsdnuIIMFIltLhFZP5HWV/x2Bieys/OloA7\n\t0LMpvuTAwjTZSEOWHX+mPv5uab9nqeQgpNIekBuODc45ed+NuVCYxzGEwNsBDwHKId\n\tKu+Ut/KaYfjjQZTCJVGxdPuahIcpF9Khq3H7GdM8=","Date":"Mon, 14 Jul 2025 16:20:55 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] test: libtest: CameraTest: Set env var before\n\tCameraManager","Message-ID":"<20250714132055.GF8243@pendragon.ideasonboard.com>","References":"<20250714131326.1279434-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250714131326.1279434-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34887,"web_url":"https://patchwork.libcamera.org/comment/34887/","msgid":"<175249983201.560048.7941370678416325279@ping.linuxembedded.co.uk>","date":"2025-07-14T13:30:32","subject":"Re: [PATCH v1] test: libtest: CameraTest: Set env var before\n\tCameraManager","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-07-14 14:20:55)\n> Hi Barnabás,\n> \n> Thank you for the patch.\n> \n> On Mon, Jul 14, 2025 at 03:13:26PM +0200, Barnabás Pőcze wrote:\n> > Set the `LIBCAMERA_IPA_FORCE_ISOLATION` environmental variable\n> \n> s/environmental/environment/\n> \n> (caring about environmental issues is important, but that's unrelated to\n> this patch :-))\n> \n> > before constructing the `CameraManager` object. This makes it\n> > available during construction (some components might want to\n> > query environmental variables at that time).\n> \n> Same here.\n> \n> > \n> > Signed-off-by: Barnabás Pőcze \n> \n> Reviewed-by: Laurent Pinchart \n> \n\n\nReviewed-by: Kieran Bingham \n\nShould be fine to fixup as you merge this - no need to send a v2 then ;-)\n\n\n\n> > ---\n> > test/libtest/camera_test.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/test/libtest/camera_test.cpp b/test/libtest/camera_test.cpp\n> > index fe13d6acf..6fb44989d 100644\n> > --- a/test/libtest/camera_test.cpp\n> > +++ b/test/libtest/camera_test.cpp\n> > @@ -15,11 +15,11 @@ using namespace std;\n> > \n> > CameraTest::CameraTest(const char *name, bool isolate)\n> > {\n> > - cm_ = new CameraManager();\n> > -\n> > if (isolate)\n> > setenv(\"LIBCAMERA_IPA_FORCE_ISOLATION\", \"1\", 1);\n> > \n> > + cm_ = new CameraManager();\n> > +\n> > if (cm_->start()) {\n> > cerr << \"Failed to start camera manager\" << endl;\n> > status_ = TestFail;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 208AFBE175\n\tfor ;\n\tMon, 14 Jul 2025 13:30:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C60168F46;\n\tMon, 14 Jul 2025 15:30:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 429286186C\n\tfor ;\n\tMon, 14 Jul 2025 15:30:35 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A25E5304;\n\tMon, 14 Jul 2025 15:30:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PUDUSN2f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752499803;\n\tbh=2i0s1BJAjBDeLAEf+YPFB9hc+rUDfdNPJEM0i2DS400=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=PUDUSN2fNcUEihKgbfj3amdwV2QXzi2Tp3A/0ezyC1Ga6u9XuyFdr7Rbed5iLR3AP\n\t5TX/xgyh4Hb/Ma2HAneV9vUN3TpWCWxU5oMnKlbY7U8pbIzQ//jqy5jGkh/0dj1HUO\n\tK5OaDFvOouThF2CGzwO1Qp+bWCSH/ldQ94sUASiM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250714132055.GF8243@pendragon.ideasonboard.com>","References":"<20250714131326.1279434-1-barnabas.pocze@ideasonboard.com>\n\t<20250714132055.GF8243@pendragon.ideasonboard.com>","Subject":"Re: [PATCH v1] test: libtest: CameraTest: Set env var before\n\tCameraManager","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","Date":"Mon, 14 Jul 2025 14:30:32 +0100","Message-ID":"<175249983201.560048.7941370678416325279@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]