[{"id":34873,"web_url":"https://patchwork.libcamera.org/comment/34873/","msgid":"","date":"2025-07-14T03:59:20","subject":"Re: [PATCH v3] libcamera: camera_manager: Log info message to report\n\tcamera creation","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"On Sun, Jul 13, 2025 at 03:16:45PM +0300, Laurent Pinchart wrote:\n> Camera creation is one of the most important events generated by\n> libcamera, but we are completely silent about it. The lack of a log\n> message makes it more difficult to identify problems and provide\n> support. Fix it by adding an Info message that reports the camera id and\n> its pipeline handler when the camera is added.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n\n> ---\n> Changes since v2:\n> \n> - Rebase on latest master branch\n> ---\n> src/libcamera/camera_manager.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index e62e7193cfdc..f81794bfd6fe 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -217,6 +217,10 @@ void CameraManager::Private::addCamera(std::shared_ptr camera)\n> \t\tcameras_.push_back(camera);\n> \t}\n> \n> +\tLOG(Camera, Info)\n> +\t\t<< \"Adding camera '\" << camera->id() << \"' for pipeline handler \"\n> +\t\t<< camera->_d()->pipe()->name();\n> +\n> \t/* Report the addition to the public signal */\n> \tCameraManager *const o = LIBCAMERA_O_PTR();\n> \to->cameraAdded.emit(camera);\n> \n> base-commit: afd9890b7b9a65d95ef3295f52e01e0ec9ce7b3f\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97E62C3237\n\tfor ;\n\tMon, 14 Jul 2025 03:59:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4AB368F30;\n\tMon, 14 Jul 2025 05:59:20 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BC226150F\n\tfor ;\n\tMon, 14 Jul 2025 05:59:17 +0200 (CEST)","from [49.36.69.193] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1ubALU-00GGSE-6n; Mon, 14 Jul 2025 05:59:16 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"Ar8vLQi0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=4Qgr6LVQ5W8uqVUVKooLOeRSF6tE9aWPMLeQwfHGrfA=;\n\tb=Ar8vLQi0Y8yP0VbzC9OMh9extX\n\tLTOFfwYT2s5YQB2kt/JCDBqRG6IrljYLOgtytVfRkhUu8C3X9G0oy41m+zEDRjwq77WDUoLj3U5ix\n\t0eO+IIOudZhn/4/3abzzqZzDsHdmQC3iO5fjzNR3kKTGzTSIXNxmzjvniDUHU90k0vWo9mOZk5Fnb\n\t78SHlmo/9o2QDrdjGATKCn55rf9DTBrg1e9GcwgqI+tVOVvNk7Ut/EsnChti8I2SkaZ425V2xSTW6\n\taWMDl38DlHg4taJyDJai6/AUijsUYGffWNhdcUVbH55z22LoDcYytxs/g4ejl2O8ISHsRdWaSYDbR\n\tLBB+Fqfw==;","Date":"Mon, 14 Jul 2025 09:29:20 +0530","From":"Umang Jain ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ","Subject":"Re: [PATCH v3] libcamera: camera_manager: Log info message to report\n\tcamera creation","Message-ID":"","References":"<20250713121645.11776-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250713121645.11776-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20250510-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34874,"web_url":"https://patchwork.libcamera.org/comment/34874/","msgid":"<5507c855-4dc2-4425-bd7a-23dc5d353944@ideasonboard.com>","date":"2025-07-14T08:22:54","subject":"Re: [PATCH v3] libcamera: camera_manager: Log info message to report\n\tcamera creation","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 07. 13. 14:16 keltezéssel, Laurent Pinchart írta:\n> Camera creation is one of the most important events generated by\n> libcamera, but we are completely silent about it. The lack of a log\n> message makes it more difficult to identify problems and provide\n> support. Fix it by adding an Info message that reports the camera id and\n> its pipeline handler when the camera is added.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Barnabás Pőcze \n\n\n> ---\n> Changes since v2:\n> \n> - Rebase on latest master branch\n> ---\n> src/libcamera/camera_manager.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index e62e7193cfdc..f81794bfd6fe 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -217,6 +217,10 @@ void CameraManager::Private::addCamera(std::shared_ptr camera)\n> \t\tcameras_.push_back(camera);\n> \t}\n> \n> +\tLOG(Camera, Info)\n> +\t\t<< \"Adding camera '\" << camera->id() << \"' for pipeline handler \"\n> +\t\t<< camera->_d()->pipe()->name();\n> +\n> \t/* Report the addition to the public signal */\n> \tCameraManager *const o = LIBCAMERA_O_PTR();\n> \to->cameraAdded.emit(camera);\n> \n> base-commit: afd9890b7b9a65d95ef3295f52e01e0ec9ce7b3f\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F077BC3237\n\tfor ;\n\tMon, 14 Jul 2025 08:22:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED8FF68F30;\n\tMon, 14 Jul 2025 10:22:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CCD361518\n\tfor ;\n\tMon, 14 Jul 2025 10:22:57 +0200 (CEST)","from [192.168.33.16] (185.221.140.39.nat.pool.zt.hu\n\t[185.221.140.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C88B76BE;\n\tMon, 14 Jul 2025 10:22:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"adJC5r/Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752481345;\n\tbh=4sx9w0d8DMfWSUkAdSVmA1qh+Qd9Ng35msth6CP/rK4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=adJC5r/QFNIzDEpn1YfBtdtq4GFSRz+odp4Nd5v9lX+PvNyRp9ZUyP6I7GKL9tzqw\n\tOsbCCrLD4B+Gz5T/T9wWDXlx6v+XZlM4Kcsp1cuwhkp76Uo8O2LRfvSbAyQOxE6Eo7\n\tugpBGGRSj5PPXqkX/1QC++3aFNsu79wMkSTX2XUk=","Message-ID":"<5507c855-4dc2-4425-bd7a-23dc5d353944@ideasonboard.com>","Date":"Mon, 14 Jul 2025 10:22:54 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3] libcamera: camera_manager: Log info message to report\n\tcamera creation","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250713121645.11776-1-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250713121645.11776-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]