[{"id":3140,"web_url":"https://patchwork.libcamera.org/comment/3140/","msgid":"<20191127092746.xcyyzf4ghp73ni5a@uno.localdomain>","date":"2019-11-27T09:27:57","subject":"Re: [libcamera-devel] [PATCH 1/5] test: message: Fix message\n\thandling in MessageReceiver","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, Nov 27, 2019 at 10:49:05AM +0200, Laurent Pinchart wrote:\n> Forward messages that we don't handle to the base Object class, to avoid\n> both blocking the ThreadMove message and mistaking it as the test\n> message.\n\nI've not been following the issue too closely, so I can only partially\ngrasp it, but all the patches look sane to me\n\nFor the series:\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> test/message.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/test/message.cpp b/test/message.cpp\n> index 3775c30a20b3..cf21d5ca50d1 100644\n> --- a/test/message.cpp\n> +++ b/test/message.cpp\n> @@ -37,6 +37,11 @@ public:\n> protected:\n> \tvoid message(Message *msg)\n> \t{\n> +\t\tif (msg->type() != Message::None) {\n> +\t\t\tObject::message(msg);\n> +\t\t\treturn;\n> +\t\t}\n> +\n> \t\tif (thread() != Thread::current())\n> \t\t\tstatus_ = InvalidThread;\n> \t\telse\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C3B060BB8\n\tfor ;\n\tWed, 27 Nov 2019 10:25:56 +0100 (CET)","from uno.localdomain (93-34-114-233.ip49.fastwebnet.it\n\t[93.34.114.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id AD1F440005;\n\tWed, 27 Nov 2019 09:25:55 +0000 (UTC)"],"X-Originating-IP":"93.34.114.233","Date":"Wed, 27 Nov 2019 10:27:57 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191127092746.xcyyzf4ghp73ni5a@uno.localdomain>","References":"<20191127084909.10612-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"am3yvtawqqcokpm7\"","Content-Disposition":"inline","In-Reply-To":"<20191127084909.10612-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 1/5] test: message: Fix message\n\thandling in MessageReceiver","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 27 Nov 2019 09:25:56 -0000"}},{"id":3153,"web_url":"https://patchwork.libcamera.org/comment/3153/","msgid":"<20191127150111.GF12879@bigcity.dyn.berto.se>","date":"2019-11-27T15:01:11","subject":"Re: [libcamera-devel] [PATCH 1/5] test: message: Fix message\n\thandling in MessageReceiver","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-11-27 10:49:05 +0200, Laurent Pinchart wrote:\n> Forward messages that we don't handle to the base Object class, to avoid\n> both blocking the ThreadMove message and mistaking it as the test\n> message.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/message.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/test/message.cpp b/test/message.cpp\n> index 3775c30a20b3..cf21d5ca50d1 100644\n> --- a/test/message.cpp\n> +++ b/test/message.cpp\n> @@ -37,6 +37,11 @@ public:\n> protected:\n> \tvoid message(Message *msg)\n> \t{\n> +\t\tif (msg->type() != Message::None) {\n> +\t\t\tObject::message(msg);\n> +\t\t\treturn;\n> +\t\t}\n> +\n> \t\tif (thread() != Thread::current())\n> \t\t\tstatus_ = InvalidThread;\n> \t\telse\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 961DE60C33\n\tfor ;\n\tWed, 27 Nov 2019 16:01:13 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id b20so17429398lfp.4\n\tfor ;\n\tWed, 27 Nov 2019 07:01:13 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\ty192sm2293818lfa.63.2019.11.27.07.01.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 27 Nov 2019 07:01:12 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=xe3EoSFLjRSY1uuVC5CxQioiYFcdv+SztESQScy6ozI=;\n\tb=jEKUc5qS8yi3aKFA4x3SoIPQzjOjngmglzsTn3UTwvbz7YjqrGtpgAYPmiZ5BkPV6/\n\tdzjeE45rQfjn8mErDKOvZJkHF92kRCu4IUjNF8DaT8E6CxCbiIOxsFxrO8ki2koYyHqT\n\t+/LKHEG3SetscRptWY0S/QQ/19kYMusJ2ypDEMtcppYV5Q3yO1jIlhk9Bzzi7lb11tFQ\n\tatDaAjN8/HDFlKEBXiXvz4AiGL0uQuJ5IQY7A9pUeEZLgAU1cYT2rdfHD9EwBNf3wOTM\n\tnC+7xX/o3WdPOo4rtoxlfIgFyTDgk39d317OcNz8WFpFhFfh1bBXrIPNY5LjnEHMviq6\n\tpAYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=xe3EoSFLjRSY1uuVC5CxQioiYFcdv+SztESQScy6ozI=;\n\tb=uTQYzpGg+GzyNOdMj4L9OUcAT9uo4Wx+gy3jwz0z7nULiBF8DnuQXjPiJyvA8P8tt0\n\tldJfaluIFqXEsN5wo1N6tVOZYRbPzyQhsnFYDMY8zQhWGnbs/X0a6fpZrcP9G2lp1m3z\n\tLrcipeY4ZMUpNPmTtFQRgMmI8rw72Y9aCpl/3n8cogkpUnX7yzsY/5vjhbw2zZJglxJM\n\tT4QW/Lf0yrTGI9QI4cgs0Au12wnDkVlN+oC06aHYvDDErkA9+9Lsr+z1uV6lQgoRPwfd\n\toPwD0e+0f90jx15C2Y8xHkkDbuzowZvKjw5d0tV9KmU9crHunzATFpZg8SeJ2HzHGIzJ\n\tn76w==","X-Gm-Message-State":"APjAAAXBRmVe+nFa8sm8MDep3RhvIJSoCFLQpi7wqcP9R7gSjIVVE9ME\n\t5BXSCwXw7+/YQxQI9LD17+rZ/A==","X-Google-Smtp-Source":"APXvYqwwNX/bD1huAB4SI2xOcQDUN6F27n7dRdAR2GusCsMkgfqBdSpMLxK5D2C5A9kNrslpaVjAvw==","X-Received":"by 2002:ac2:4312:: with SMTP id\n\tl18mr29157057lfh.38.1574866872884; \n\tWed, 27 Nov 2019 07:01:12 -0800 (PST)","Date":"Wed, 27 Nov 2019 16:01:11 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191127150111.GF12879@bigcity.dyn.berto.se>","References":"<20191127084909.10612-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191127084909.10612-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 1/5] test: message: Fix message\n\thandling in MessageReceiver","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 27 Nov 2019 15:01:13 -0000"}}]