[{"id":34821,"web_url":"https://patchwork.libcamera.org/comment/34821/","msgid":"","date":"2025-07-08T09:06:57","subject":"Re: [PATCH v1 1/2] libcamera: controls: Remove hypenation in control\n\tdescription text","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch.\n\nOn Tue, 8 Jul 2025 at 09:52, Naushir Patuck wrote:\n>\n> Remove the hypenation in \"micro-seconds\" in the description for the\n\ns/hypenation/hyphenation/\n\n(sorry!)\n\n> ExposureTime control to match the rest of the document.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids_core.yaml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index 46f51436c215..566e1533702f 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -212,7 +212,7 @@ controls:\n> description: |\n> Exposure time for the frame applied in the sensor device.\n>\n> - This value is specified in micro-seconds.\n> + This value is specified in microseconds.\n\nWith the typo fixed:\n\nReviewed-by: David Plowman \n\nThanks\nDavid\n\n>\n> This control will only take effect if ExposureTimeMode is Manual. If\n> this control is set when ExposureTimeMode is Auto, the value will be\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2B6FC0DA4\n\tfor ;\n\tTue, 8 Jul 2025 09:07:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 385DE68EDC;\n\tTue, 8 Jul 2025 11:07:12 +0200 (CEST)","from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com\n\t[IPv6:2607:f8b0:4864:20::82e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C855468E3A\n\tfor ;\n\tTue, 8 Jul 2025 11:07:09 +0200 (CEST)","by mail-qt1-x82e.google.com with SMTP id\n\td75a77b69052e-4a77ffcb795so38620021cf.0\n\tfor ;\n\tTue, 08 Jul 2025 02:07:09 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"EcajpLoe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1751965628; x=1752570428;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=awdqo6QCGoXQH4IJ+Yxsa2e8o/0b1h3F+W0ggNlimEg=;\n\tb=EcajpLoexVJeqTKc8JrAYt4BuvQU2Vt28Ba8JnMjx3Hg9Jr1/VaY+fVJnKzw3KYWVK\n\tw3NDELPA795G5gAaEMiFK3nE/oFbCxWFg6X9ru8d9KE1ocd/F06OoPQDznrrH+fGnnAb\n\tkyTNENCdr+fxycOc5YxRod+Lyx0ILV0FHZFodgP6elx5RN0UQhvpsVCR1A4SfUnSHamu\n\t0h8fvVFEC+HdSkIALQ7nYpU+CFf0fTGUwyDY91HTI5uF3ZglhhyvPHIGyo8nrehSvWo3\n\tZv6AQ3mCBh+1Zq03S1nrlgmAjIXZR4jyg4nkmT5/hnqNq3RTi/JBhhXg2NjPZAvjzUjb\n\tA8CQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1751965628; x=1752570428;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=awdqo6QCGoXQH4IJ+Yxsa2e8o/0b1h3F+W0ggNlimEg=;\n\tb=d3iGDIdYdOgM0FC3CgWyCVVcxDzzc3lZ92XEG3mTX66RnmuDzps5XhZMkkP5WTE4I8\n\tvl9Ly3uWsYNIa1x2yJT6CPYqXvUAabAt85ecirtgzOBYeQm4GF5izd8dWZOG0SRxJp3j\n\tn3hwz3Wsg1v0ez3a3HpaWakJi6VYVRq6rnbxmsmzu+L9AbTBoPi/Q0tAqp3NVbFOBaAu\n\tzySbDluBJQ/DSzVA4XEc8tOK/Xym3s45hMcfqsu/brdvlC5hfSlHWTQvt/tRksVBnkul\n\tKQKHcn7X2V/vRwqNH7BdngdBO4EpSRml5O5gfYMRvC2TteeLvEtR7mMLUFzafm9Yl/Ob\n\tRVgg==","X-Gm-Message-State":"AOJu0Yyb+TnQdQIDzUx44yl+wDTDHmc6vOLtE5dQidX8EYRvQ9RqmK6N\n\t05ikUNR8t5iElqHvnERiBjSYmw0mGtLaCqH/lAntGVB1dDtbKOnxW8OoCqyLmHEI69M8+UhsPnp\n\t15PrhX7/giYuFKgaJXst3YDc8Yuo0l6Pe20RK8WtzvA==","X-Gm-Gg":"ASbGnct4ECNFBf1v0QMlwPSP5dxGfPb05GVL6aSJhd6XIYBPIAjqXaEshzRVzcI6kBe\n\tgxVeKUKLE6ewCc3iAtZqYARwxBSWmMjx8j4zaWu6/Z5QthVNcEKq9S5eb9S3pqEfIIv19W9GdGk\n\tLWoDoXClYuiZvyUeh/ZUIiBBqXo9AiVUk6z+OFQlMVAORQP40IuHUQwHzjHzRbDKyjWOuwpJqqq\n\tMS+lIRzkDpMRg==","X-Google-Smtp-Source":"AGHT+IHhyC4PK6u8IfGQkaH0qUA1NVrF0fePF9bw86IBQ6S1msoALh8cU63hI5el8V+0uJQCW4aeswrT/bU5om40PZw=","X-Received":"by 2002:ac8:7f42:0:b0:4a9:a7c1:2d93 with SMTP id\n\td75a77b69052e-4a9cd6cede1mr31748721cf.17.1751965628238;\n\tTue, 08 Jul 2025 02:07:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20250708085147.752248-1-naush@raspberrypi.com>\n\t<20250708085147.752248-2-naush@raspberrypi.com>","In-Reply-To":"<20250708085147.752248-2-naush@raspberrypi.com>","From":"David Plowman ","Date":"Tue, 8 Jul 2025 10:06:57 +0100","X-Gm-Features":"Ac12FXw34_qI2QSqBVCdEODBgUNqm8OUb8ZHkiD8gINymgJrSCyPtkQKsb6jEGg","Message-ID":"","Subject":"Re: [PATCH v1 1/2] libcamera: controls: Remove hypenation in control\n\tdescription text","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34824,"web_url":"https://patchwork.libcamera.org/comment/34824/","msgid":"<175196749034.2340557.12457466739328682366@ping.linuxembedded.co.uk>","date":"2025-07-08T09:38:10","subject":"Re: [PATCH v1 1/2] libcamera: controls: Remove hypenation in control\n\tdescription text","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting David Plowman (2025-07-08 10:06:57)\n> Hi Naush\n> \n> Thanks for the patch.\n> \n> On Tue, 8 Jul 2025 at 09:52, Naushir Patuck wrote:\n> >\n> > Remove the hypenation in \"micro-seconds\" in the description for the\n> \n> s/hypenation/hyphenation/\n> \n> (sorry!)\n\nI think we need to hype this up :-)\n\n\nReviewed-by: Kieran Bingham \n\n> \n> > ExposureTime control to match the rest of the document.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/control_ids_core.yaml | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> > index 46f51436c215..566e1533702f 100644\n> > --- a/src/libcamera/control_ids_core.yaml\n> > +++ b/src/libcamera/control_ids_core.yaml\n> > @@ -212,7 +212,7 @@ controls:\n> > description: |\n> > Exposure time for the frame applied in the sensor device.\n> >\n> > - This value is specified in micro-seconds.\n> > + This value is specified in microseconds.\n> \n> With the typo fixed:\n> \n> Reviewed-by: David Plowman \n> \n> Thanks\n> David\n> \n> >\n> > This control will only take effect if ExposureTimeMode is Manual. If\n> > this control is set when ExposureTimeMode is Auto, the value will be\n> > --\n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B131EC0DA4\n\tfor ;\n\tTue, 8 Jul 2025 09:38:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D9A468EE5;\n\tTue, 8 Jul 2025 11:38:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F358E68EDC\n\tfor ;\n\tTue, 8 Jul 2025 11:38:12 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1B1A667;\n\tTue, 8 Jul 2025 11:37:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oWaa+NdH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751967465;\n\tbh=yZgMyFu7NEAhJzQNGkX3vxvcQuFZA4ElwEFs7kukuIQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=oWaa+NdHcxrTTSp50xo+UTOy9mdXz1G37biGhFDoFQogTBozkeeliq4VVW96agmv6\n\tEKrDhzT2MeXgVwdBDG4WDtu2EUevoaHdfPL6rJ2W5yZQ1y1gCMRxyi0+jz4u0T4EPo\n\tUFTi74Orrsgv+Hlv48PHyDy74NC3X6x+H4XT1zmA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250708085147.752248-1-naush@raspberrypi.com>\n\t<20250708085147.752248-2-naush@raspberrypi.com>\n\t","Subject":"Re: [PATCH v1 1/2] libcamera: controls: Remove hypenation in control\n\tdescription text","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"David Plowman ,\n\tNaushir Patuck ","Date":"Tue, 08 Jul 2025 10:38:10 +0100","Message-ID":"<175196749034.2340557.12457466739328682366@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]