[{"id":34846,"web_url":"https://patchwork.libcamera.org/comment/34846/","msgid":"","date":"2025-07-10T14:37:08","subject":"Re: [PATCH v9 03/10] libcamera: simple: Don't use raw output formats\n\twith conversions","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"Hi Milan,\n\nOn Mon, Jul 07, 2025 at 05:58:48PM +0200, Milan Zamazal wrote:\n> In order to support raw streams, we need to add raw formats to software\n> ISP configurations. In this preparatory patch, the raw formats are\n> excluded from output configurations for conversions.\n> \n> Signed-off-by: Milan Zamazal \n\nnit: Commit subject could be more clear and concise:\n\"libcamera: simple: Exclude raw configurations from output conversions\"\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index a900918db..368bf3020 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -27,6 +27,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> \n> @@ -261,6 +262,12 @@ static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"sun6i-csi\", {}, false },\n> };\n> \n> +bool isFormatRaw(const libcamera::PixelFormat &pixFmt)\n> +{\n> +\treturn libcamera::PixelFormatInfo::info(pixFmt).colourEncoding ==\n> +\t libcamera::PixelFormatInfo::ColourEncodingRAW;\n> +}\n> +\n> } /* namespace */\n> \n> class SimpleCameraData : public Camera::Private\n> @@ -1424,7 +1431,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \n> \t\tcfg.setStream(&data->streams_[i]);\n> \n> -\t\tif (data->useConversion_)\n> +\t\tif (data->useConversion_ && !isFormatRaw(cfg.pixelFormat))\n> \t\t\toutputCfgs.push_back(cfg);\n> \t}\n> \n> -- \n> 2.50.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59A6ABE175\n\tfor ;\n\tThu, 10 Jul 2025 14:37:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A61B068F02;\n\tThu, 10 Jul 2025 16:37:08 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F72168EE7\n\tfor ;\n\tThu, 10 Jul 2025 16:37:06 +0200 (CEST)","from [49.36.69.85] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uZsOX-00Ey9r-3W; Thu, 10 Jul 2025 16:37:05 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"AFNm3uHw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=MUil+50F07D+ZyzTy82pGQLVgigINyCh1HFiHvKf0l4=;\n\tb=AFNm3uHws8ecvKT2wkTNoij7qH\n\tIWCj/4zDtiYmsRMsQ3JpjVARRbEh6e6HmvRGRGCQfCkhTyzLozv5OXG2GDx7PWI/DDBFfssDGGGJ/\n\t4rSX2/kE+0xWRYj6oGkT8g80o5wBpCh+ik7VMbFBvmlb/116WGzNMnfD/NqJufmioI2BrNwoHmyoe\n\tkDqdjAaNJNlnijIbszuK6EOkMOAaryQHG/KcJr/hn9JaeDVdHJjC6pd0gTj95T6OTx7lCsnoNsrkC\n\t8GuAAf3rxN61qcQtq6OqnbSC0jjT7J3w0IDsvXz5ElOQcEvYo3PbFpyrE15VzYHFYZd0WDETn5MJl\n\tgNkLJDww==;","Date":"Thu, 10 Jul 2025 20:07:08 +0530","From":"Umang Jain ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t","Subject":"Re: [PATCH v9 03/10] libcamera: simple: Don't use raw output formats\n\twith conversions","Message-ID":"","References":"<20250707155856.33436-1-mzamazal@redhat.com>\n\t<20250707155856.33436-4-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250707155856.33436-4-mzamazal@redhat.com>","User-Agent":"NeoMutt/20250510-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]