[{"id":34791,"web_url":"https://patchwork.libcamera.org/comment/34791/","msgid":"<175188243129.1668806.12699254029903646560@ping.linuxembedded.co.uk>","date":"2025-07-07T10:00:31","subject":"Re: [PATCH v3 7/9] pipeline: v4l2_subdevice: Add color space to\n\tformat string representation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-07-07 09:55:10)\n> Add the color space to the string representation of V4L2SubdeviceFormat\n> that is returned by toString() and operator<<().\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n> \n> Changes in v3:\n> - Moved color space output to V4L2SubdeviceFormat\n> - Dropped tags, as the patch changed a bit more\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 33279654db8c..ce6b0d38cbf1 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -949,6 +949,8 @@ std::ostream &operator<<(std::ostream &out, const V4L2SubdeviceFormat &f)\n> else\n> out << it->second.name;\n> \n> + out << \"/\" << ColorSpace::toString(f.colorSpace);\n> +\n\nLooks good to me.\n\nI assume the toString will deal with cases if f.colorSpace is invalid.\n\n\nReviewed-by: Kieran Bingham \n\n> return out;\n> }\n> \n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DA0DC0DA4\n\tfor ;\n\tMon, 7 Jul 2025 10:00:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D8A968E74;\n\tMon, 7 Jul 2025 12:00:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5534068E74\n\tfor ;\n\tMon, 7 Jul 2025 12:00:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADD7F524;\n\tMon, 7 Jul 2025 12:00:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FHYrN0Nt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751882407;\n\tbh=lAqd4Uc2y0nE4BXc4/IljOa1sCge85jZWoNEnpZcsKw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=FHYrN0Nt/8TNS1cd3Eec4/KWeMNCRfZjyUFwhENKQqgLOSD4ppF8VwBKl68CFe+WT\n\tRzf9sW277LLUtyjM+y0u1cuY0orwpBy8ObPoIQXhddP7V9czVO6PxErFbEOKJUIZkD\n\tRw/XkSJbDMZWwhQMdHCXUZBNUBFRsf+orBr3DocE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250707085520.39777-8-stefan.klug@ideasonboard.com>","References":"<20250707085520.39777-1-stefan.klug@ideasonboard.com>\n\t<20250707085520.39777-8-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v3 7/9] pipeline: v4l2_subdevice: Add color space to\n\tformat string representation","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 07 Jul 2025 11:00:31 +0100","Message-ID":"<175188243129.1668806.12699254029903646560@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34796,"web_url":"https://patchwork.libcamera.org/comment/34796/","msgid":"<0cee786b74af214cf57a4cced547c5de68d552ad.camel@ideasonboard.com>","date":"2025-07-07T10:37:23","subject":"Re: [PATCH v3 7/9] pipeline: v4l2_subdevice: Add color space to\n\tformat string representation","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch!\n\nOn Mon, 2025-07-07 at 10:55 +0200, Stefan Klug wrote:\n> Add the color space to the string representation of\n> V4L2SubdeviceFormat\n> that is returned by toString() and operator<<().\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n> \n> Changes in v3:\n> - Moved color space output to V4L2SubdeviceFormat\n> - Dropped tags, as the patch changed a bit more\n> \n> Changes in v2:\n> - Collected tag\n> ---\n>  src/libcamera/v4l2_subdevice.cpp | 2 ++\n>  1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp\n> b/src/libcamera/v4l2_subdevice.cpp\n> index 33279654db8c..ce6b0d38cbf1 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -949,6 +949,8 @@ std::ostream &operator<<(std::ostream &out, const\n> V4L2SubdeviceFormat &f)\n>  \telse\n>  \t\tout << it->second.name;\n>  \n> +\tout << \"/\" << ColorSpace::toString(f.colorSpace);\n> +\n\nReviewed-by: Isaac Scott \n\n>  \treturn out;\n>  }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EAEBC0DA4\n\tfor ;\n\tMon, 7 Jul 2025 10:37:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D63CE68E93;\n\tMon, 7 Jul 2025 12:37:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ADC568E74\n\tfor ;\n\tMon, 7 Jul 2025 12:37:27 +0200 (CEST)","from isaac-ThinkPad-T16-Gen-2.lan\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E19056D;\n\tMon, 7 Jul 2025 12:37:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lkvhbPbj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751884620;\n\tbh=C+Pa4nsYxN9yaZZq5otzjc3Dfyqdpmd+SRkUzARt/ik=;\n\th=Subject:From:To:Date:In-Reply-To:References:From;\n\tb=lkvhbPbji34Gxf7jcInd+TJYmL426qfOy8B8eIz/8IL/WaalxOsGO0mbFgqKLHkKi\n\teZuzCFvxfUIp6ZlpQeHpy1RVmDDK8TDTxqP/CylQVp9H5IRFcCr2KSTL0DnXP2Yhnf\n\tDN69AaYY6TwC2N7BwbnmoL5CLkK1fAidIYXSM394=","Message-ID":"<0cee786b74af214cf57a4cced547c5de68d552ad.camel@ideasonboard.com>","Subject":"Re: [PATCH v3 7/9] pipeline: v4l2_subdevice: Add color space to\n\tformat string representation","From":"Isaac Scott ","To":"Stefan Klug , \n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 07 Jul 2025 11:37:23 +0100","In-Reply-To":"<20250707085520.39777-8-stefan.klug@ideasonboard.com>","References":"<20250707085520.39777-1-stefan.klug@ideasonboard.com>\n\t<20250707085520.39777-8-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.56.1 (by Flathub.org) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34808,"web_url":"https://patchwork.libcamera.org/comment/34808/","msgid":"<20250707131131.GC14963@pendragon.ideasonboard.com>","date":"2025-07-07T13:11:31","subject":"Re: [PATCH v3 7/9] pipeline: v4l2_subdevice: Add color space to\n\tformat string representation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Mon, Jul 07, 2025 at 10:55:10AM +0200, Stefan Klug wrote:\n> Add the color space to the string representation of V4L2SubdeviceFormat\n> that is returned by toString() and operator<<().\n\nA *why* would be good here too.\n\nAny reason not to do the same for V4L2DeviceFormat ?\n\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n> \n> Changes in v3:\n> - Moved color space output to V4L2SubdeviceFormat\n> - Dropped tags, as the patch changed a bit more\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 33279654db8c..ce6b0d38cbf1 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -949,6 +949,8 @@ std::ostream &operator<<(std::ostream &out, const V4L2SubdeviceFormat &f)\n> \telse\n> \t\tout << it->second.name;\n> \n> +\tout << \"/\" << ColorSpace::toString(f.colorSpace);\n> +\n> \treturn out;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2023C0DA4\n\tfor ;\n\tMon, 7 Jul 2025 13:12:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1CB768EB9;\n\tMon, 7 Jul 2025 15:12:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 815A46151E\n\tfor ;\n\tMon, 7 Jul 2025 15:11:59 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 80389664;\n\tMon, 7 Jul 2025 15:11:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M5x5FIJJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751893892;\n\tbh=wTp8ei1CeITXINIyiZ4t3fSDcYej+1d6PW8SSXhrtzU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M5x5FIJJ43BY9/UOtL8ggq0+r3JA/J3xNb2aIL0ygfbYOS2JemOUQgTaokHgp1xH6\n\tzWDocIod7t0sD4eTjDEM0l70ogKckJpimcIy/FJKX4jrNZVQJb2S1IN+DAr+VGpLPU\n\t6CqghxzFU9/k2Rfwkq/iWDmcfnuRybT03ZRIkYeU=","Date":"Mon, 7 Jul 2025 16:11:31 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 7/9] pipeline: v4l2_subdevice: Add color space to\n\tformat string representation","Message-ID":"<20250707131131.GC14963@pendragon.ideasonboard.com>","References":"<20250707085520.39777-1-stefan.klug@ideasonboard.com>\n\t<20250707085520.39777-8-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250707085520.39777-8-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34809,"web_url":"https://patchwork.libcamera.org/comment/34809/","msgid":"<175189495583.40598.12796303830889559344@localhost>","date":"2025-07-07T13:29:15","subject":"Re: [PATCH v3 7/9] pipeline: v4l2_subdevice: Add color space to\n\tformat string representation","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the comment.\n\nQuoting Laurent Pinchart (2025-07-07 15:11:31)\n> Hi Stefan,\n> \n> Thank you for the patch.\n> \n> On Mon, Jul 07, 2025 at 10:55:10AM +0200, Stefan Klug wrote:\n> > Add the color space to the string representation of V4L2SubdeviceFormat\n> > that is returned by toString() and operator<<().\n> \n> A *why* would be good here too.\n\nI thought about writing all the history about the bug in linux <= 6.13\nand why that information is useful to debug that issue. Then I got\ninspired by the concise commit message of\nhttps://git.libcamera.org/libcamera/libcamera.git/commit/?id=9b50d3c23dea1bc2882cd3e6566a3d4cb9f7296f\nwhich was proposed as base for the rework of this commit...\n\nI can extend the message.\n\n> \n> Any reason not to do the same for V4L2DeviceFormat ?\n\nNo reason other than I didn't need it.\n\nBest regards,\nStefan\n\n> \n> > \n> > Signed-off-by: Stefan Klug \n> > \n> > ---\n> > \n> > Changes in v3:\n> > - Moved color space output to V4L2SubdeviceFormat\n> > - Dropped tags, as the patch changed a bit more\n> > \n> > Changes in v2:\n> > - Collected tag\n> > ---\n> > src/libcamera/v4l2_subdevice.cpp | 2 ++\n> > 1 file changed, 2 insertions(+)\n> > \n> > diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> > index 33279654db8c..ce6b0d38cbf1 100644\n> > --- a/src/libcamera/v4l2_subdevice.cpp\n> > +++ b/src/libcamera/v4l2_subdevice.cpp\n> > @@ -949,6 +949,8 @@ std::ostream &operator<<(std::ostream &out, const V4L2SubdeviceFormat &f)\n> > else\n> > out << it->second.name;\n> > \n> > + out << \"/\" << ColorSpace::toString(f.colorSpace);\n> > +\n> > return out;\n> > }\n> > \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DEF8C3237\n\tfor ;\n\tMon, 7 Jul 2025 13:29:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5B4868EB6;\n\tMon, 7 Jul 2025 15:29:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9227C6151E\n\tfor ;\n\tMon, 7 Jul 2025 15:29:18 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c79f:85df:e7f5:4c31])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A584E89A;\n\tMon, 7 Jul 2025 15:28:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l8dfas7W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751894931;\n\tbh=feRqq2t9vAvgmZjneeYmcGzg+qwjJm0qO1sCYg06pnk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=l8dfas7WPQH9I5yx5sEXyymuMb5ARljOv8oHXbdlXftHwYL1F18wCVWozEhCtbXbt\n\tzopSlaTS+vAP5/cCV56xg+DcBwIX9QvFIlsduzXHfzGWITGK7v2b9pbT5naTLMlTRR\n\tFs+qfNq7eHdUYzRkB+0DOUKSMjH9TJJJG+wC/IpI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250707131131.GC14963@pendragon.ideasonboard.com>","References":"<20250707085520.39777-1-stefan.klug@ideasonboard.com>\n\t<20250707085520.39777-8-stefan.klug@ideasonboard.com>\n\t<20250707131131.GC14963@pendragon.ideasonboard.com>","Subject":"Re: [PATCH v3 7/9] pipeline: v4l2_subdevice: Add color space to\n\tformat string representation","From":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart ","Date":"Mon, 07 Jul 2025 15:29:15 +0200","Message-ID":"<175189495583.40598.12796303830889559344@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]