[{"id":34806,"web_url":"https://patchwork.libcamera.org/comment/34806/","msgid":"<20250707130125.GA14963@pendragon.ideasonboard.com>","date":"2025-07-07T13:01:25","subject":"Re: [PATCH v3 5/9] ipa: rkisp1: params: Check for empty parameters","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Mon, Jul 07, 2025 at 10:55:08AM +0200, Stefan Klug wrote:\n> Add functions to check for empty parameter blocks. Modify the constructor\n> so that a parameter block constructed from an empty span stays empty.\n\nI'd say that a block constructed from an empty span \"is invalid\", as\nthere's no \"empty block\" concept. Also, please explain in the commit\nmessage why/when this can happen.\n\n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Paul Elder \n> \n> ---\n> \n> Changes in v3:\n> - Collected tags\n> \n> Changes in v2:\n> - Removed unrelated get() functions\n> ---\n> src/ipa/rkisp1/params.cpp | 3 +++\n> src/ipa/rkisp1/params.h | 3 +++\n> 2 files changed, 6 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/params.cpp b/src/ipa/rkisp1/params.cpp\n> index 4c0b051ce65d..b4a889e415fc 100644\n> --- a/src/ipa/rkisp1/params.cpp\n> +++ b/src/ipa/rkisp1/params.cpp\n> @@ -82,6 +82,9 @@ RkISP1ParamsBlockBase::RkISP1ParamsBlockBase(RkISP1Params *params, BlockType typ\n> \t\t\t\t\t const Span &data)\n> \t: params_(params), type_(type)\n> {\n> +\tif (data.empty())\n> +\t\treturn;\n> +\n> \tif (params_->format() == V4L2_META_FMT_RK_ISP1_EXT_PARAMS) {\n> \t\theader_ = data.subspan(0, sizeof(rkisp1_ext_params_block_header));\n> \t\tdata_ = data.subspan(sizeof(rkisp1_ext_params_block_header));\n> diff --git a/src/ipa/rkisp1/params.h b/src/ipa/rkisp1/params.h\n> index 40450e34497a..04b06c2a6266 100644\n> --- a/src/ipa/rkisp1/params.h\n> +++ b/src/ipa/rkisp1/params.h\n> @@ -89,6 +89,9 @@ public:\n> \n> \tvoid setEnabled(bool enabled);\n> \n> +\tbool isValid() const { return !data_.empty(); }\n\nThis function doesn't seem to be used, neither in this series nor in the\n\"[PATCH 0/8] Implement WDR algorithm\" series.\n\n> +\texplicit operator bool() const { return !data_.empty(); }\n> +\n> private:\n> \tLIBCAMERA_DISABLE_COPY(RkISP1ParamsBlockBase)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78F43C3237\n\tfor ;\n\tMon, 7 Jul 2025 13:01:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A17C268EB5;\n\tMon, 7 Jul 2025 15:01:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4FE56151E\n\tfor ;\n\tMon, 7 Jul 2025 15:01:53 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7DCC59CA;\n\tMon, 7 Jul 2025 15:01:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nzqiyAcX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751893286;\n\tbh=1q+3tgHkMCOJaJ6EhGZBOvhixIIq6gSSmY8hh8JgqY8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nzqiyAcXzX4whtigHrlRsqVLO5BQjUxTMBwkna56DrXQDkThT5Sd+OvtLfeIsljOG\n\tO1V147NDJyzUFO9lFiFG2sXgPYLeKF3NPrnWdotg6t5FG20S117gM+iIPa1/94Jf+Z\n\t6iGWH05oGcD9ru1YA/m8EjozKY++5za54k3ejICA=","Date":"Mon, 7 Jul 2025 16:01:25 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tPaul Elder ","Subject":"Re: [PATCH v3 5/9] ipa: rkisp1: params: Check for empty parameters","Message-ID":"<20250707130125.GA14963@pendragon.ideasonboard.com>","References":"<20250707085520.39777-1-stefan.klug@ideasonboard.com>\n\t<20250707085520.39777-6-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250707085520.39777-6-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]